From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kees Cook Subject: Re: [PATCH v2 01/29] powerpc: Rename "notes" PT_NOTE to "note" Date: Fri, 11 Oct 2019 09:11:43 -0700 Message-ID: <201910110910.48270FC97@keescook> References: <20191011000609.29728-1-keescook@chromium.org> <20191011000609.29728-2-keescook@chromium.org> <20191011082519.GI9749@gate.crashing.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20191011082519.GI9749@gate.crashing.org> Sender: linux-kernel-owner@vger.kernel.org To: Segher Boessenkool Cc: Borislav Petkov , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Michal Simek , x86@kernel.org, linux-ia64@vger.kernel.org, Arnd Bergmann , linux-xtensa@linux-xtensa.org, Dave Hansen , Heiko Carstens , linuxppc-dev@lists.ozlabs.org, Yoshinori Sato , linux-parisc@vger.kernel.org, Andy Lutomirski , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, Rick Edgecombe , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org List-Id: linux-arch.vger.kernel.org On Fri, Oct 11, 2019 at 03:25:19AM -0500, Segher Boessenkool wrote: > On Thu, Oct 10, 2019 at 05:05:41PM -0700, Kees Cook wrote: > > The Program Header identifiers are internal to the linker scripts. In > > preparation for moving the NOTES segment declaration into RO_DATA, > > standardize the identifier for the PT_NOTE entry to "note" as used by > > all other architectures that emit PT_NOTE. > > All other archs are wrong, and "notes" is a much better name. This > segment does not contain a single "note", but multiple "notes". True, but the naming appears to be based off the Program Header name of "PT_NOTE". Regardless, it is an entirely internal-to-the-linker-script identifier, so I am just consolidating on a common name with the least number of collateral changes. -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f196.google.com ([209.85.214.196]:41321 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728154AbfJKQLs (ORCPT ); Fri, 11 Oct 2019 12:11:48 -0400 Received: by mail-pl1-f196.google.com with SMTP id t10so4678108plr.8 for ; Fri, 11 Oct 2019 09:11:46 -0700 (PDT) Date: Fri, 11 Oct 2019 09:11:43 -0700 From: Kees Cook Subject: Re: [PATCH v2 01/29] powerpc: Rename "notes" PT_NOTE to "note" Message-ID: <201910110910.48270FC97@keescook> References: <20191011000609.29728-1-keescook@chromium.org> <20191011000609.29728-2-keescook@chromium.org> <20191011082519.GI9749@gate.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191011082519.GI9749@gate.crashing.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Segher Boessenkool Cc: Borislav Petkov , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Michal Simek , x86@kernel.org, linux-ia64@vger.kernel.org, Arnd Bergmann , linux-xtensa@linux-xtensa.org, Dave Hansen , Heiko Carstens , linuxppc-dev@lists.ozlabs.org, Yoshinori Sato , linux-parisc@vger.kernel.org, Andy Lutomirski , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, Rick Edgecombe , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org Message-ID: <20191011161143.NDQjouSPWBBII0i3azoejIIgIlVw2Vqa8LY01AVRkOo@z> On Fri, Oct 11, 2019 at 03:25:19AM -0500, Segher Boessenkool wrote: > On Thu, Oct 10, 2019 at 05:05:41PM -0700, Kees Cook wrote: > > The Program Header identifiers are internal to the linker scripts. In > > preparation for moving the NOTES segment declaration into RO_DATA, > > standardize the identifier for the PT_NOTE entry to "note" as used by > > all other architectures that emit PT_NOTE. > > All other archs are wrong, and "notes" is a much better name. This > segment does not contain a single "note", but multiple "notes". True, but the naming appears to be based off the Program Header name of "PT_NOTE". Regardless, it is an entirely internal-to-the-linker-script identifier, so I am just consolidating on a common name with the least number of collateral changes. -- Kees Cook