From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Martin Subject: Re: [PATCH v2 08/12] arm64: BTI: Decode BYTPE bits when printing PSTATE Date: Fri, 11 Oct 2019 16:33:46 +0100 Message-ID: <20191011153346.GM27757@arm.com> References: <1570733080-21015-1-git-send-email-Dave.Martin@arm.com> <1570733080-21015-9-git-send-email-Dave.Martin@arm.com> <18c9318c-d122-b534-b526-318935d9e2cc@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <18c9318c-d122-b534-b526-318935d9e2cc@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Richard Henderson Cc: linux-kernel@vger.kernel.org, Florian Weimer , "H.J. Lu" , Andrew Jones , Kees Cook , Arnd Bergmann , Jann Horn , Peter Zijlstra , Catalin Marinas , Will Deacon , Eugene Syromiatnikov , Kristina =?utf-8?Q?Mart=C5=A1enko?= , Szabolcs Nagy , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, Amit Kachhap , Paul Elliott , Vincenzo Frascino , Sudakshina Das , Thomas Gleixner List-Id: linux-arch.vger.kernel.org On Fri, Oct 11, 2019 at 11:31:02AM -0400, Richard Henderson wrote: > On 10/10/19 2:44 PM, Dave Martin wrote: > > #define PSR_IL_BIT (1 << 20) > > -#define PSR_BTYPE_CALL (2 << PSR_BTYPE_SHIFT) > > + > > +/* Convenience names for the values of PSTATE.BTYPE */ > > +#define PSR_BTYPE_NONE (0b00 << PSR_BTYPE_SHIFT) > > +#define PSR_BTYPE_JC (0b01 << PSR_BTYPE_SHIFT) > > +#define PSR_BTYPE_C (0b10 << PSR_BTYPE_SHIFT) > > +#define PSR_BTYPE_J (0b11 << PSR_BTYPE_SHIFT) > > It'd be nice to sort this patch earlier, so that ... > > > diff --git a/arch/arm64/kernel/signal.c b/arch/arm64/kernel/signal.c > > index 4a3bd32..452ac5b 100644 > > --- a/arch/arm64/kernel/signal.c > > +++ b/arch/arm64/kernel/signal.c > > @@ -732,7 +732,7 @@ static void setup_return(struct pt_regs *regs, struct k_sigaction *ka, > > > > if (system_supports_bti()) { > > regs->pstate &= ~PSR_BTYPE_MASK; > > - regs->pstate |= PSR_BTYPE_CALL; > > + regs->pstate |= PSR_BTYPE_C; > > } > > > > if (ka->sa.sa_flags & SA_RESTORER) > > ... setup_return does not need to be adjusted a second time. > > I don't see any other conflicts vs patch 5. Ack, looks like I mis-split this during rebase. Will fix. Cheers ---Dave From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com ([217.140.110.172]:36002 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727682AbfJKPdw (ORCPT ); Fri, 11 Oct 2019 11:33:52 -0400 Date: Fri, 11 Oct 2019 16:33:46 +0100 From: Dave Martin Subject: Re: [PATCH v2 08/12] arm64: BTI: Decode BYTPE bits when printing PSTATE Message-ID: <20191011153346.GM27757@arm.com> References: <1570733080-21015-1-git-send-email-Dave.Martin@arm.com> <1570733080-21015-9-git-send-email-Dave.Martin@arm.com> <18c9318c-d122-b534-b526-318935d9e2cc@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18c9318c-d122-b534-b526-318935d9e2cc@linaro.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Richard Henderson Cc: linux-kernel@vger.kernel.org, Florian Weimer , "H.J. Lu" , Andrew Jones , Kees Cook , Arnd Bergmann , Jann Horn , Peter Zijlstra , Catalin Marinas , Will Deacon , Eugene Syromiatnikov , Kristina =?utf-8?Q?Mart=C5=A1enko?= , Szabolcs Nagy , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, Amit Kachhap , Paul Elliott , Vincenzo Frascino , Sudakshina Das , Thomas Gleixner , Yu-cheng Yu Message-ID: <20191011153346.nXVwhBlqLFEJXXGu5UWpaOoJDjJjUIuPtkwzHgmvfPw@z> On Fri, Oct 11, 2019 at 11:31:02AM -0400, Richard Henderson wrote: > On 10/10/19 2:44 PM, Dave Martin wrote: > > #define PSR_IL_BIT (1 << 20) > > -#define PSR_BTYPE_CALL (2 << PSR_BTYPE_SHIFT) > > + > > +/* Convenience names for the values of PSTATE.BTYPE */ > > +#define PSR_BTYPE_NONE (0b00 << PSR_BTYPE_SHIFT) > > +#define PSR_BTYPE_JC (0b01 << PSR_BTYPE_SHIFT) > > +#define PSR_BTYPE_C (0b10 << PSR_BTYPE_SHIFT) > > +#define PSR_BTYPE_J (0b11 << PSR_BTYPE_SHIFT) > > It'd be nice to sort this patch earlier, so that ... > > > diff --git a/arch/arm64/kernel/signal.c b/arch/arm64/kernel/signal.c > > index 4a3bd32..452ac5b 100644 > > --- a/arch/arm64/kernel/signal.c > > +++ b/arch/arm64/kernel/signal.c > > @@ -732,7 +732,7 @@ static void setup_return(struct pt_regs *regs, struct k_sigaction *ka, > > > > if (system_supports_bti()) { > > regs->pstate &= ~PSR_BTYPE_MASK; > > - regs->pstate |= PSR_BTYPE_CALL; > > + regs->pstate |= PSR_BTYPE_C; > > } > > > > if (ka->sa.sa_flags & SA_RESTORER) > > ... setup_return does not need to be adjusted a second time. > > I don't see any other conflicts vs patch 5. Ack, looks like I mis-split this during rebase. Will fix. Cheers ---Dave