From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Henderson Subject: [PATCH 1/6] random: Mark CONFIG_ARCH_RANDOM functions __must_check Date: Mon, 28 Oct 2019 22:05:54 +0100 Message-ID: <20191028210559.8289-2-rth@twiddle.net> References: <20191028210559.8289-1-rth@twiddle.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20191028210559.8289-1-rth@twiddle.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: linux-arch@vger.kernel.org Cc: linux-s390@vger.kernel.org, Kees Cook , x86@kernel.org, "H. Peter Anvin" , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org List-Id: linux-arch.vger.kernel.org We cannot use the pointer output without validating the success of the random read. Signed-off-by: Richard Henderson --- Cc: Kees Cook Cc: "H. Peter Anvin" Cc: linux-arch@vger.kernel.org --- include/linux/random.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/random.h b/include/linux/random.h index f189c927fdea..84947b489649 100644 --- a/include/linux/random.h +++ b/include/linux/random.h @@ -167,11 +167,11 @@ static inline void prandom_seed_state(struct rnd_state *state, u64 seed) #ifdef CONFIG_ARCH_RANDOM # include #else -static inline bool arch_get_random_long(unsigned long *v) +static inline bool __must_check arch_get_random_long(unsigned long *v) { return 0; } -static inline bool arch_get_random_int(unsigned int *v) +static inline bool __must_check arch_get_random_int(unsigned int *v) { return 0; } @@ -179,11 +179,11 @@ static inline bool arch_has_random(void) { return 0; } -static inline bool arch_get_random_seed_long(unsigned long *v) +static inline bool __must_check arch_get_random_seed_long(unsigned long *v) { return 0; } -static inline bool arch_get_random_seed_int(unsigned int *v) +static inline bool __must_check arch_get_random_seed_int(unsigned int *v) { return 0; } -- 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f68.google.com ([209.85.128.68]:52739 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389535AbfJ1VGG (ORCPT ); Mon, 28 Oct 2019 17:06:06 -0400 Received: by mail-wm1-f68.google.com with SMTP id p21so423934wmg.2 for ; Mon, 28 Oct 2019 14:06:04 -0700 (PDT) From: Richard Henderson Subject: [PATCH 1/6] random: Mark CONFIG_ARCH_RANDOM functions __must_check Date: Mon, 28 Oct 2019 22:05:54 +0100 Message-ID: <20191028210559.8289-2-rth@twiddle.net> In-Reply-To: <20191028210559.8289-1-rth@twiddle.net> References: <20191028210559.8289-1-rth@twiddle.net> Sender: linux-arch-owner@vger.kernel.org List-ID: To: linux-arch@vger.kernel.org Cc: x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Kees Cook , "H. Peter Anvin" Message-ID: <20191028210554.9ItYyhor4gGRC6YxJsr0FzmbYwL8iL0iQhS2tJVYkOU@z> We cannot use the pointer output without validating the success of the random read. Signed-off-by: Richard Henderson --- Cc: Kees Cook Cc: "H. Peter Anvin" Cc: linux-arch@vger.kernel.org --- include/linux/random.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/random.h b/include/linux/random.h index f189c927fdea..84947b489649 100644 --- a/include/linux/random.h +++ b/include/linux/random.h @@ -167,11 +167,11 @@ static inline void prandom_seed_state(struct rnd_state *state, u64 seed) #ifdef CONFIG_ARCH_RANDOM # include #else -static inline bool arch_get_random_long(unsigned long *v) +static inline bool __must_check arch_get_random_long(unsigned long *v) { return 0; } -static inline bool arch_get_random_int(unsigned int *v) +static inline bool __must_check arch_get_random_int(unsigned int *v) { return 0; } @@ -179,11 +179,11 @@ static inline bool arch_has_random(void) { return 0; } -static inline bool arch_get_random_seed_long(unsigned long *v) +static inline bool __must_check arch_get_random_seed_long(unsigned long *v) { return 0; } -static inline bool arch_get_random_seed_int(unsigned int *v) +static inline bool __must_check arch_get_random_seed_int(unsigned int *v) { return 0; } -- 2.17.1