From mboxrd@z Thu Jan 1 00:00:00 1970 From: Segher Boessenkool Subject: Re: [PATCH v2 01/29] powerpc: Rename "notes" PT_NOTE to "note" Date: Tue, 29 Oct 2019 20:01:17 -0500 Message-ID: <20191030010117.GJ28442@gate.crashing.org> References: <20191011000609.29728-1-keescook@chromium.org> <20191011000609.29728-2-keescook@chromium.org> <20191011082519.GI9749@gate.crashing.org> <201910110910.48270FC97@keescook> <20191011162552.GK9749@gate.crashing.org> <20191015165412.GD596@zn.tnic> <201910291414.F29F738B7@keescook> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <201910291414.F29F738B7@keescook> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Kees Cook Cc: linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Michal Simek , Dave Hansen , linux-ia64@vger.kernel.org, Yoshinori Sato , Arnd Bergmann , linux-xtensa@linux-xtensa.org, Will Deacon , x86@kernel.org, Heiko Carstens , linux-kernel@vger.kernel.org, Borislav Petkov , linux-parisc@vger.kernel.org, Andy Lutomirski , linux-alpha@vger.kernel.org, Rick Edgecombe , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org List-Id: linux-arch.vger.kernel.org On Tue, Oct 29, 2019 at 02:15:39PM -0700, Kees Cook wrote: > On Tue, Oct 15, 2019 at 06:54:13PM +0200, Borislav Petkov wrote: > > On Fri, Oct 11, 2019 at 11:25:52AM -0500, Segher Boessenkool wrote: > > > Names *matter*, internal names doubly so. So why replace a good name with > > > a worse name? Because it is slightly less work for you? > > > > So if we agree on the name "notes" and we decide to rename the other > > arches, this should all be done in a separate patchset anyway, and ontop > > of this one. And I believe Kees wouldn't mind doing it ontop since he's > > gotten his hands dirty already. :-P > > I've added more rationale to patch #1 in the just-sent v3 of this > series. If I still can't convince you Segher, I'm happy to send "patch > 30/29" to do a bulk rename to "notes". Let me know. :) I am still not convinced the worse name is a better name, no :-) But if you don't want to do the work, and instead prefer the much smaller change, that is of course a fine decision. Thank you! (I would be happy with such a 30/29 as well, of course.) Segher From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org ([63.228.1.57]:57584 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726094AbfJ3BCS (ORCPT ); Tue, 29 Oct 2019 21:02:18 -0400 Date: Tue, 29 Oct 2019 20:01:17 -0500 From: Segher Boessenkool Subject: Re: [PATCH v2 01/29] powerpc: Rename "notes" PT_NOTE to "note" Message-ID: <20191030010117.GJ28442@gate.crashing.org> References: <20191011000609.29728-1-keescook@chromium.org> <20191011000609.29728-2-keescook@chromium.org> <20191011082519.GI9749@gate.crashing.org> <201910110910.48270FC97@keescook> <20191011162552.GK9749@gate.crashing.org> <20191015165412.GD596@zn.tnic> <201910291414.F29F738B7@keescook> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201910291414.F29F738B7@keescook> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Kees Cook Cc: Borislav Petkov , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Michal Simek , x86@kernel.org, linux-ia64@vger.kernel.org, Arnd Bergmann , linux-xtensa@linux-xtensa.org, Dave Hansen , Heiko Carstens , linuxppc-dev@lists.ozlabs.org, Yoshinori Sato , linux-parisc@vger.kernel.org, Andy Lutomirski , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, Rick Edgecombe , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org Message-ID: <20191030010117.5MbpmOz6XELhjUIFxflMvWjnicmwqFOqRX8TF8OClZA@z> On Tue, Oct 29, 2019 at 02:15:39PM -0700, Kees Cook wrote: > On Tue, Oct 15, 2019 at 06:54:13PM +0200, Borislav Petkov wrote: > > On Fri, Oct 11, 2019 at 11:25:52AM -0500, Segher Boessenkool wrote: > > > Names *matter*, internal names doubly so. So why replace a good name with > > > a worse name? Because it is slightly less work for you? > > > > So if we agree on the name "notes" and we decide to rename the other > > arches, this should all be done in a separate patchset anyway, and ontop > > of this one. And I believe Kees wouldn't mind doing it ontop since he's > > gotten his hands dirty already. :-P > > I've added more rationale to patch #1 in the just-sent v3 of this > series. If I still can't convince you Segher, I'm happy to send "patch > 30/29" to do a bulk rename to "notes". Let me know. :) I am still not convinced the worse name is a better name, no :-) But if you don't want to do the work, and instead prefer the much smaller change, that is of course a fine decision. Thank you! (I would be happy with such a 30/29 as well, of course.) Segher