From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [RFC] errno.h: Provide EFSCORRUPTED for everybody Date: Sat, 2 Nov 2019 08:38:23 +1100 Message-ID: <20191101213823.GW4614@dread.disaster.area> References: <20191031010736.113783-1-Valdis.Kletnieks@vt.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Geert Uytterhoeven Cc: driverdevel , Linux-Arch , Valdis Kletnieks , Arnd Bergmann , "Darrick J. Wong" , Greg Kroah-Hartman , Chao Yu , Linux Kernel Mailing List , linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, Andreas Dilger , Jaegeuk Kim , Linux FS Devel , Theodore Ts'o , Gao Xiang , Ext4 Developers List , linux-erofs@lists.ozlabs.org, Jan Kara List-Id: linux-arch.vger.kernel.org On Fri, Nov 01, 2019 at 09:57:31PM +0100, Geert Uytterhoeven wrote: > Hi Valdis, > > On Thu, Oct 31, 2019 at 2:11 AM Valdis Kletnieks > wrote: > > Three questions: (a) ACK/NAK on this patch, (b) should it be all in one > > patch, or one to add to errno.h and 6 patches for 6 filesystems?), and > > (c) if one patch, who gets to shepherd it through? > > > > There's currently 6 filesystems that have the same #define. Move it > > into errno.h so it's defined in just one place. > > > > Signed-off-by: Valdis Kletnieks > > Thanks for your patch! > > > --- a/include/uapi/asm-generic/errno.h > > +++ b/include/uapi/asm-generic/errno.h > > @@ -98,6 +98,7 @@ > > #define EINPROGRESS 115 /* Operation now in progress */ > > #define ESTALE 116 /* Stale file handle */ > > #define EUCLEAN 117 /* Structure needs cleaning */ > > +#define EFSCORRUPTED EUCLEAN > > I have two questions: > a) Why not use EUCLEAN everywhere instead? > Having two different names for the same errno complicates grepping. Because: a) EUCLEAN is horrible for code documentation. EFSCORRUPTED describes exactly the error being returned and/or checked for. b) we've used EFSCORRUPTED in XFS since 1993. i.e. it was an official, published error value on Irix, and we've kept it in the linux code for the past ~20 years because of a) c) Userspace programs that include filesystem specific headers have already been exposed to and use EFSCORRUPTED, so we can't remove/change it without breaking userspace. d) EUCLEAN has a convenient userspace string description that is appropriate for filesystem corruption: "Structure needs cleaning" is precisely what needs to happen. Repair of the filesystem (i.e. recovery to a clean state) is what is required to fix the error.... > b) Perhaps both errors should use different values? That horse bolted to userspace years ago - this is just formalising the practice that has spread across multiple linux filesystems from XFS over the past ~10 years.. Cheers, Dave. -- Dave Chinner david@fromorbit.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail105.syd.optusnet.com.au ([211.29.132.249]:33897 "EHLO mail105.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725989AbfKAVig (ORCPT ); Fri, 1 Nov 2019 17:38:36 -0400 Date: Sat, 2 Nov 2019 08:38:23 +1100 From: Dave Chinner Subject: Re: [RFC] errno.h: Provide EFSCORRUPTED for everybody Message-ID: <20191101213823.GW4614@dread.disaster.area> References: <20191031010736.113783-1-Valdis.Kletnieks@vt.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Geert Uytterhoeven Cc: Valdis Kletnieks , Greg Kroah-Hartman , Gao Xiang , Chao Yu , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , "Darrick J. Wong" , linux-xfs@vger.kernel.org, Jan Kara , Arnd Bergmann , Linux FS Devel , driverdevel , Linux Kernel Mailing List , linux-erofs@lists.ozlabs.org, Ext4 Developers List , linux-f2fs-devel@lists.sourceforge.net, Linux-Arch Message-ID: <20191101213823.ANdaW9S00SwTyyf-1XpDbYMN-vUyP9omxDJ0X0GDkuo@z> On Fri, Nov 01, 2019 at 09:57:31PM +0100, Geert Uytterhoeven wrote: > Hi Valdis, > > On Thu, Oct 31, 2019 at 2:11 AM Valdis Kletnieks > wrote: > > Three questions: (a) ACK/NAK on this patch, (b) should it be all in one > > patch, or one to add to errno.h and 6 patches for 6 filesystems?), and > > (c) if one patch, who gets to shepherd it through? > > > > There's currently 6 filesystems that have the same #define. Move it > > into errno.h so it's defined in just one place. > > > > Signed-off-by: Valdis Kletnieks > > Thanks for your patch! > > > --- a/include/uapi/asm-generic/errno.h > > +++ b/include/uapi/asm-generic/errno.h > > @@ -98,6 +98,7 @@ > > #define EINPROGRESS 115 /* Operation now in progress */ > > #define ESTALE 116 /* Stale file handle */ > > #define EUCLEAN 117 /* Structure needs cleaning */ > > +#define EFSCORRUPTED EUCLEAN > > I have two questions: > a) Why not use EUCLEAN everywhere instead? > Having two different names for the same errno complicates grepping. Because: a) EUCLEAN is horrible for code documentation. EFSCORRUPTED describes exactly the error being returned and/or checked for. b) we've used EFSCORRUPTED in XFS since 1993. i.e. it was an official, published error value on Irix, and we've kept it in the linux code for the past ~20 years because of a) c) Userspace programs that include filesystem specific headers have already been exposed to and use EFSCORRUPTED, so we can't remove/change it without breaking userspace. d) EUCLEAN has a convenient userspace string description that is appropriate for filesystem corruption: "Structure needs cleaning" is precisely what needs to happen. Repair of the filesystem (i.e. recovery to a clean state) is what is required to fix the error.... > b) Perhaps both errors should use different values? That horse bolted to userspace years ago - this is just formalising the practice that has spread across multiple linux filesystems from XFS over the past ~10 years.. Cheers, Dave. -- Dave Chinner david@fromorbit.com