From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH v4 13/13] mm: remove __ARCH_HAS_4LEVEL_HACK and include/asm-generic/4level-fixup.h Date: Tue, 5 Nov 2019 17:13:09 -0800 Message-ID: <20191105171309.9a5ccf9cf14d7288f7adf198@linux-foundation.org> References: <1572938135-31886-1-git-send-email-rppt@kernel.org> <1572938135-31886-14-git-send-email-rppt@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1572938135-31886-14-git-send-email-rppt@kernel.org> Sender: linux-kernel-owner@vger.kernel.org To: Mike Rapoport Cc: linux-mm@kvack.org, Anton Ivanov , Arnd Bergmann , "David S. Miller" , Geert Uytterhoeven , Greentime Hu , Greg Ungerer , Helge Deller , "James E.J. Bottomley" , Jeff Dike , "Kirill A. Shutemov" , Linus Torvalds , Mark Salter , Matt Turner , Michal Simek , Peter Rosin , Richard Weinberger , Rolf Eike Beer , Russell King , Sam Creasey , Vi List-Id: linux-arch.vger.kernel.org On Tue, 5 Nov 2019 09:15:35 +0200 Mike Rapoport wrote: > There are no architectures that use include/asm-generic/4level-fixup.h > therefore it can be removed along with __ARCH_HAS_4LEVEL_HACK define. Conflicts a bit with Vineet's "asm-generic/tlb: stub out pud_free_tlb() if nopud ...", from http://lkml.kernel.org/r/20191016162400.14796-2-vgupta@synopsys.com I fixed it up by removing include/asm-generic/4level-fixup.h anyway and removing the removal of "#ifndef __ARCH_HAS_4LEVEL_HAC" from include/asm-generic/tlb.h. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 5 Nov 2019 17:13:09 -0800 From: Andrew Morton Subject: Re: [PATCH v4 13/13] mm: remove __ARCH_HAS_4LEVEL_HACK and include/asm-generic/4level-fixup.h Message-ID: <20191105171309.9a5ccf9cf14d7288f7adf198@linux-foundation.org> In-Reply-To: <1572938135-31886-14-git-send-email-rppt@kernel.org> References: <1572938135-31886-1-git-send-email-rppt@kernel.org> <1572938135-31886-14-git-send-email-rppt@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit To: Mike Rapoport Cc: linux-mm@kvack.org, Anton Ivanov , Arnd Bergmann , "David S. Miller" , Geert Uytterhoeven , Greentime Hu , Greg Ungerer , Helge Deller , "James E.J. Bottomley" , Jeff Dike , "Kirill A. Shutemov" , Linus Torvalds , Mark Salter , Matt Turner , Michal Simek , Peter Rosin , Richard Weinberger , Rolf Eike Beer , Russell King , Sam Creasey , Vincent Chen , Vineet Gupta , linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org, linux-kernel@vger.kernel.org, linux-m68k@vger.kernel.org, linux-parisc@vger.kernel.org, linux-um@lists.infradead.org, sparclinux@vger.kernel.org, Mike Rapoport List-ID: Message-ID: <20191106011309.gyPkEq90Ju8vax4NTPO2SDPDvCbV5Z9xD9thN-Ny8NY@z> On Tue, 5 Nov 2019 09:15:35 +0200 Mike Rapoport wrote: > There are no architectures that use include/asm-generic/4level-fixup.h > therefore it can be removed along with __ARCH_HAS_4LEVEL_HACK define. Conflicts a bit with Vineet's "asm-generic/tlb: stub out pud_free_tlb() if nopud ...", from http://lkml.kernel.org/r/20191016162400.14796-2-vgupta@synopsys.com I fixed it up by removing include/asm-generic/4level-fixup.h anyway and removing the removal of "#ifndef __ARCH_HAS_4LEVEL_HAC" from include/asm-generic/tlb.h.