From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH 1/1] errno.h: Provide EFSBADCRC for everybody Date: Wed, 6 Nov 2019 07:07:38 +1100 Message-ID: <20191105200045.GD4614@dread.disaster.area> References: <20191105024618.194134-1-Valdis.Kletnieks@vt.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20191105024618.194134-1-Valdis.Kletnieks@vt.edu> Sender: linux-kernel-owner@vger.kernel.org To: Valdis Kletnieks Cc: Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , Chao Yu , "Darrick J. Wong" , linux-xfs@vger.kernel.org, Jan Kara , Arnd Bergmann , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-arch@vger.kernel.org List-Id: linux-arch.vger.kernel.org On Mon, Nov 04, 2019 at 09:46:14PM -0500, Valdis Kletnieks wrote: > Four filesystems have their own defines for this. Move it > into errno.h so it's defined in just one place. > > Signed-off-by: Valdis Kletnieks Looks good, minor nit below: > diff --git a/include/uapi/asm-generic/errno.h b/include/uapi/asm-generic/errno.h > index 1d5ffdf54cb0..e4cae9a9ae79 100644 > --- a/include/uapi/asm-generic/errno.h > +++ b/include/uapi/asm-generic/errno.h > @@ -55,6 +55,7 @@ > #define EMULTIHOP 72 /* Multihop attempted */ > #define EDOTDOT 73 /* RFS specific error */ > #define EBADMSG 74 /* Not a data message */ > +#define EFSBADCRC EBADMSG /* Bad CRC detected */ Inconsistent whitespace here. When you get tab vs space after #define wrong it only shows up in patches. :/ Cheers, Dave. -- Dave Chinner david@fromorbit.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail104.syd.optusnet.com.au ([211.29.132.246]:45534 "EHLO mail104.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726141AbfKEUHp (ORCPT ); Tue, 5 Nov 2019 15:07:45 -0500 Date: Wed, 6 Nov 2019 07:07:38 +1100 From: Dave Chinner Subject: Re: [PATCH 1/1] errno.h: Provide EFSBADCRC for everybody Message-ID: <20191105200045.GD4614@dread.disaster.area> References: <20191105024618.194134-1-Valdis.Kletnieks@vt.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191105024618.194134-1-Valdis.Kletnieks@vt.edu> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Valdis Kletnieks Cc: Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , Chao Yu , "Darrick J. Wong" , linux-xfs@vger.kernel.org, Jan Kara , Arnd Bergmann , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-arch@vger.kernel.org Message-ID: <20191105200738.j8s0kSgGPI53_Ko8OKsBdryWkt3TwQKFSLI-RE6eRFE@z> On Mon, Nov 04, 2019 at 09:46:14PM -0500, Valdis Kletnieks wrote: > Four filesystems have their own defines for this. Move it > into errno.h so it's defined in just one place. > > Signed-off-by: Valdis Kletnieks Looks good, minor nit below: > diff --git a/include/uapi/asm-generic/errno.h b/include/uapi/asm-generic/errno.h > index 1d5ffdf54cb0..e4cae9a9ae79 100644 > --- a/include/uapi/asm-generic/errno.h > +++ b/include/uapi/asm-generic/errno.h > @@ -55,6 +55,7 @@ > #define EMULTIHOP 72 /* Multihop attempted */ > #define EDOTDOT 73 /* RFS specific error */ > #define EBADMSG 74 /* Not a data message */ > +#define EFSBADCRC EBADMSG /* Bad CRC detected */ Inconsistent whitespace here. When you get tab vs space after #define wrong it only shows up in patches. :/ Cheers, Dave. -- Dave Chinner david@fromorbit.com