From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 11/21] asm-generic: don't provide ioremap for CONFIG_MMU Date: Wed, 6 Nov 2019 19:28:57 +0100 Message-ID: <20191106182857.GA21062@lst.de> References: <20191029064834.23438-12-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Palmer Dabbelt , Christoph Hellwig , "linux-ia64@vger.kernel.org" , Linux-sh list , Linux Kernel Mailing List , Guo Ren , sparclinux , linux-riscv@lists.infradead.org, Vincent Chen , Linux-Arch , linux-s390 , "open list:QUALCOMM HEXAGON..." , the arch/x86 maintainers , arcml , linux-xtensa@linux-xtensa.org, Arnd Bergmann , linux-m68k , Openrisc , Greentime List-Id: linux-arch.vger.kernel.org On Wed, Nov 06, 2019 at 07:16:38PM +0100, Geert Uytterhoeven wrote: > > shouldn't they all just be that first one? In other words, wouldn't it be > > better to always provide the generic ioremap prototype and unify the ports > > instead? > > Agreed. But I'd go for the second one. Eventually we should unify it and only have a single prototype. But we have lots of implementations including inline functions, so this will take a few more steps. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:52707 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727276AbfKFS3C (ORCPT ); Wed, 6 Nov 2019 13:29:02 -0500 Date: Wed, 6 Nov 2019 19:28:57 +0100 From: Christoph Hellwig Subject: Re: [PATCH 11/21] asm-generic: don't provide ioremap for CONFIG_MMU Message-ID: <20191106182857.GA21062@lst.de> References: <20191029064834.23438-12-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Geert Uytterhoeven Cc: Palmer Dabbelt , Christoph Hellwig , "linux-ia64@vger.kernel.org" , Linux-sh list , Linux Kernel Mailing List , Guo Ren , sparclinux , linux-riscv@lists.infradead.org, Vincent Chen , Linux-Arch , linux-s390 , "open list:QUALCOMM HEXAGON..." , the arch/x86 maintainers , arcml , linux-xtensa@linux-xtensa.org, Arnd Bergmann , linux-m68k , Openrisc , Greentime Hu , MTD Maling List , Guan Xuetao , Linux ARM , Michal Simek , Parisc List , linux-mips@vger.kernel.org, alpha , nios2-dev@lists.rocketboards.org Message-ID: <20191106182857.SanIOlvQ6igyBwr5QoGn-bqma9bP2OUv3wIxtkaFAQA@z> On Wed, Nov 06, 2019 at 07:16:38PM +0100, Geert Uytterhoeven wrote: > > shouldn't they all just be that first one? In other words, wouldn't it be > > better to always provide the generic ioremap prototype and unify the ports > > instead? > > Agreed. But I'd go for the second one. Eventually we should unify it and only have a single prototype. But we have lots of implementations including inline functions, so this will take a few more steps.