* [PATCH 10/10] errno.h: Provide EFSCORRUPTED for everybody
2019-11-04 1:45 ` [PATCH 10/10] errno.h: Provide EFSCORRUPTED for everybody Valdis Kletnieks
@ 2019-11-04 1:45 ` Valdis Kletnieks
2019-11-04 2:09 ` Gao Xiang
` (2 subsequent siblings)
3 siblings, 0 replies; 12+ messages in thread
From: Valdis Kletnieks @ 2019-11-04 1:45 UTC (permalink / raw)
To: Valdis Kletnieks
Cc: Darrick J . Wong, Jan Kara, Theodore Ts'o, Valdis Kletnieks,
Greg Kroah-Hartman, Gao Xiang, Chao Yu, Andreas Dilger,
Jaegeuk Kim, linux-xfs, Jan Kara, Arnd Bergmann, linux-fsdevel,
devel, linux-kernel, linux-erofs, linux-ext4, linux-f2fs-devel,
linux-arch
There's currently 6 filesystems that have the same #define. Move it
into errno.h so it's defined in just one place.
Signed-off-by: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
Acked-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Acked-by: Theodore Ts'o <tytso@mit.edu>
---
drivers/staging/exfat/exfat.h | 2 --
fs/erofs/internal.h | 2 --
fs/ext4/ext4.h | 1 -
fs/f2fs/f2fs.h | 1 -
fs/xfs/xfs_linux.h | 1 -
include/linux/jbd2.h | 1 -
include/uapi/asm-generic/errno.h | 1 +
7 files changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
index 72cf40e123de..58b091a077e8 100644
--- a/drivers/staging/exfat/exfat.h
+++ b/drivers/staging/exfat/exfat.h
@@ -30,8 +30,6 @@
#undef DEBUG
#endif
-#define EFSCORRUPTED EUCLEAN /* Filesystem is corrupted */
-
#define DENTRY_SIZE 32 /* dir entry size */
#define DENTRY_SIZE_BITS 5
diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h
index 544a453f3076..3980026a8882 100644
--- a/fs/erofs/internal.h
+++ b/fs/erofs/internal.h
@@ -425,7 +425,5 @@ static inline int z_erofs_init_zip_subsystem(void) { return 0; }
static inline void z_erofs_exit_zip_subsystem(void) {}
#endif /* !CONFIG_EROFS_FS_ZIP */
-#define EFSCORRUPTED EUCLEAN /* Filesystem is corrupted */
-
#endif /* __EROFS_INTERNAL_H */
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 03db3e71676c..a86c2585457d 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -3396,6 +3396,5 @@ static inline int ext4_buffer_uptodate(struct buffer_head *bh)
#endif /* __KERNEL__ */
#define EFSBADCRC EBADMSG /* Bad CRC detected */
-#define EFSCORRUPTED EUCLEAN /* Filesystem is corrupted */
#endif /* _EXT4_H */
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index 4024790028aa..04ebe77569a3 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -3752,6 +3752,5 @@ static inline bool is_journalled_quota(struct f2fs_sb_info *sbi)
}
#define EFSBADCRC EBADMSG /* Bad CRC detected */
-#define EFSCORRUPTED EUCLEAN /* Filesystem is corrupted */
#endif /* _LINUX_F2FS_H */
diff --git a/fs/xfs/xfs_linux.h b/fs/xfs/xfs_linux.h
index ca15105681ca..3409d02a7d21 100644
--- a/fs/xfs/xfs_linux.h
+++ b/fs/xfs/xfs_linux.h
@@ -123,7 +123,6 @@ typedef __u32 xfs_nlink_t;
#define ENOATTR ENODATA /* Attribute not found */
#define EWRONGFS EINVAL /* Mount with wrong filesystem type */
-#define EFSCORRUPTED EUCLEAN /* Filesystem is corrupted */
#define EFSBADCRC EBADMSG /* Bad CRC detected */
#define SYNCHRONIZE() barrier()
diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
index 603fbc4e2f70..69411d7e0431 100644
--- a/include/linux/jbd2.h
+++ b/include/linux/jbd2.h
@@ -1657,6 +1657,5 @@ static inline tid_t jbd2_get_latest_transaction(journal_t *journal)
#endif /* __KERNEL__ */
#define EFSBADCRC EBADMSG /* Bad CRC detected */
-#define EFSCORRUPTED EUCLEAN /* Filesystem is corrupted */
#endif /* _LINUX_JBD2_H */
diff --git a/include/uapi/asm-generic/errno.h b/include/uapi/asm-generic/errno.h
index cf9c51ac49f9..1d5ffdf54cb0 100644
--- a/include/uapi/asm-generic/errno.h
+++ b/include/uapi/asm-generic/errno.h
@@ -98,6 +98,7 @@
#define EINPROGRESS 115 /* Operation now in progress */
#define ESTALE 116 /* Stale file handle */
#define EUCLEAN 117 /* Structure needs cleaning */
+#define EFSCORRUPTED EUCLEAN
#define ENOTNAM 118 /* Not a XENIX named type file */
#define ENAVAIL 119 /* No XENIX semaphores available */
#define EISNAM 120 /* Is a named type file */
--
2.24.0.rc1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 10/10] errno.h: Provide EFSCORRUPTED for everybody
2019-11-04 1:45 ` [PATCH 10/10] errno.h: Provide EFSCORRUPTED for everybody Valdis Kletnieks
2019-11-04 1:45 ` Valdis Kletnieks
@ 2019-11-04 2:09 ` Gao Xiang
2019-11-04 2:09 ` Gao Xiang
2019-11-05 0:33 ` Christoph Hellwig
2019-11-05 3:43 ` Chao Yu
3 siblings, 1 reply; 12+ messages in thread
From: Gao Xiang @ 2019-11-04 2:09 UTC (permalink / raw)
To: Valdis Kletnieks
Cc: Darrick J . Wong, Jan Kara, Theodore Ts'o, Greg Kroah-Hartman,
Gao Xiang, Chao Yu, Andreas Dilger, Jaegeuk Kim, linux-xfs,
Jan Kara, Arnd Bergmann, linux-fsdevel, devel, linux-kernel,
linux-erofs, linux-ext4, linux-f2fs-devel, linux-arch
On Sun, Nov 03, 2019 at 08:45:06PM -0500, Valdis Kletnieks wrote:
> There's currently 6 filesystems that have the same #define. Move it
> into errno.h so it's defined in just one place.
>
> Signed-off-by: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
> Acked-by: Darrick J. Wong <darrick.wong@oracle.com>
> Reviewed-by: Jan Kara <jack@suse.cz>
> Acked-by: Theodore Ts'o <tytso@mit.edu>
For EROFS part,
Acked-by: Gao Xiang <gaoxiang25@huawei.com>
> ---
> drivers/staging/exfat/exfat.h | 2 --
> fs/erofs/internal.h | 2 --
> fs/ext4/ext4.h | 1 -
> fs/f2fs/f2fs.h | 1 -
> fs/xfs/xfs_linux.h | 1 -
> include/linux/jbd2.h | 1 -
> include/uapi/asm-generic/errno.h | 1 +
> 7 files changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
> index 72cf40e123de..58b091a077e8 100644
> --- a/drivers/staging/exfat/exfat.h
> +++ b/drivers/staging/exfat/exfat.h
> @@ -30,8 +30,6 @@
> #undef DEBUG
> #endif
>
> -#define EFSCORRUPTED EUCLEAN /* Filesystem is corrupted */
> -
> #define DENTRY_SIZE 32 /* dir entry size */
> #define DENTRY_SIZE_BITS 5
>
> diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h
> index 544a453f3076..3980026a8882 100644
> --- a/fs/erofs/internal.h
> +++ b/fs/erofs/internal.h
> @@ -425,7 +425,5 @@ static inline int z_erofs_init_zip_subsystem(void) { return 0; }
> static inline void z_erofs_exit_zip_subsystem(void) {}
> #endif /* !CONFIG_EROFS_FS_ZIP */
>
> -#define EFSCORRUPTED EUCLEAN /* Filesystem is corrupted */
> -
> #endif /* __EROFS_INTERNAL_H */
>
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index 03db3e71676c..a86c2585457d 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -3396,6 +3396,5 @@ static inline int ext4_buffer_uptodate(struct buffer_head *bh)
> #endif /* __KERNEL__ */
>
> #define EFSBADCRC EBADMSG /* Bad CRC detected */
> -#define EFSCORRUPTED EUCLEAN /* Filesystem is corrupted */
>
> #endif /* _EXT4_H */
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index 4024790028aa..04ebe77569a3 100644
> --- a/fs/f2fs/f2fs.h
> +++ b/fs/f2fs/f2fs.h
> @@ -3752,6 +3752,5 @@ static inline bool is_journalled_quota(struct f2fs_sb_info *sbi)
> }
>
> #define EFSBADCRC EBADMSG /* Bad CRC detected */
> -#define EFSCORRUPTED EUCLEAN /* Filesystem is corrupted */
>
> #endif /* _LINUX_F2FS_H */
> diff --git a/fs/xfs/xfs_linux.h b/fs/xfs/xfs_linux.h
> index ca15105681ca..3409d02a7d21 100644
> --- a/fs/xfs/xfs_linux.h
> +++ b/fs/xfs/xfs_linux.h
> @@ -123,7 +123,6 @@ typedef __u32 xfs_nlink_t;
>
> #define ENOATTR ENODATA /* Attribute not found */
> #define EWRONGFS EINVAL /* Mount with wrong filesystem type */
> -#define EFSCORRUPTED EUCLEAN /* Filesystem is corrupted */
> #define EFSBADCRC EBADMSG /* Bad CRC detected */
>
> #define SYNCHRONIZE() barrier()
> diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
> index 603fbc4e2f70..69411d7e0431 100644
> --- a/include/linux/jbd2.h
> +++ b/include/linux/jbd2.h
> @@ -1657,6 +1657,5 @@ static inline tid_t jbd2_get_latest_transaction(journal_t *journal)
> #endif /* __KERNEL__ */
>
> #define EFSBADCRC EBADMSG /* Bad CRC detected */
> -#define EFSCORRUPTED EUCLEAN /* Filesystem is corrupted */
>
> #endif /* _LINUX_JBD2_H */
> diff --git a/include/uapi/asm-generic/errno.h b/include/uapi/asm-generic/errno.h
> index cf9c51ac49f9..1d5ffdf54cb0 100644
> --- a/include/uapi/asm-generic/errno.h
> +++ b/include/uapi/asm-generic/errno.h
> @@ -98,6 +98,7 @@
> #define EINPROGRESS 115 /* Operation now in progress */
> #define ESTALE 116 /* Stale file handle */
> #define EUCLEAN 117 /* Structure needs cleaning */
> +#define EFSCORRUPTED EUCLEAN
BTW, minor, how about adding some comments right after EFSCORRUPTED
like the other error codes although it's now an alias...
Just my personal thought.
Thanks,
Gao Xiang
> #define ENOTNAM 118 /* Not a XENIX named type file */
> #define ENAVAIL 119 /* No XENIX semaphores available */
> #define EISNAM 120 /* Is a named type file */
> --
> 2.24.0.rc1
>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 10/10] errno.h: Provide EFSCORRUPTED for everybody
2019-11-04 2:09 ` Gao Xiang
@ 2019-11-04 2:09 ` Gao Xiang
0 siblings, 0 replies; 12+ messages in thread
From: Gao Xiang @ 2019-11-04 2:09 UTC (permalink / raw)
To: Valdis Kletnieks
Cc: Darrick J . Wong, Jan Kara, Theodore Ts'o, Greg Kroah-Hartman,
Gao Xiang, Chao Yu, Andreas Dilger, Jaegeuk Kim, linux-xfs,
Jan Kara, Arnd Bergmann, linux-fsdevel, devel, linux-kernel,
linux-erofs, linux-ext4, linux-f2fs-devel, linux-arch
On Sun, Nov 03, 2019 at 08:45:06PM -0500, Valdis Kletnieks wrote:
> There's currently 6 filesystems that have the same #define. Move it
> into errno.h so it's defined in just one place.
>
> Signed-off-by: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
> Acked-by: Darrick J. Wong <darrick.wong@oracle.com>
> Reviewed-by: Jan Kara <jack@suse.cz>
> Acked-by: Theodore Ts'o <tytso@mit.edu>
For EROFS part,
Acked-by: Gao Xiang <gaoxiang25@huawei.com>
> ---
> drivers/staging/exfat/exfat.h | 2 --
> fs/erofs/internal.h | 2 --
> fs/ext4/ext4.h | 1 -
> fs/f2fs/f2fs.h | 1 -
> fs/xfs/xfs_linux.h | 1 -
> include/linux/jbd2.h | 1 -
> include/uapi/asm-generic/errno.h | 1 +
> 7 files changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
> index 72cf40e123de..58b091a077e8 100644
> --- a/drivers/staging/exfat/exfat.h
> +++ b/drivers/staging/exfat/exfat.h
> @@ -30,8 +30,6 @@
> #undef DEBUG
> #endif
>
> -#define EFSCORRUPTED EUCLEAN /* Filesystem is corrupted */
> -
> #define DENTRY_SIZE 32 /* dir entry size */
> #define DENTRY_SIZE_BITS 5
>
> diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h
> index 544a453f3076..3980026a8882 100644
> --- a/fs/erofs/internal.h
> +++ b/fs/erofs/internal.h
> @@ -425,7 +425,5 @@ static inline int z_erofs_init_zip_subsystem(void) { return 0; }
> static inline void z_erofs_exit_zip_subsystem(void) {}
> #endif /* !CONFIG_EROFS_FS_ZIP */
>
> -#define EFSCORRUPTED EUCLEAN /* Filesystem is corrupted */
> -
> #endif /* __EROFS_INTERNAL_H */
>
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index 03db3e71676c..a86c2585457d 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -3396,6 +3396,5 @@ static inline int ext4_buffer_uptodate(struct buffer_head *bh)
> #endif /* __KERNEL__ */
>
> #define EFSBADCRC EBADMSG /* Bad CRC detected */
> -#define EFSCORRUPTED EUCLEAN /* Filesystem is corrupted */
>
> #endif /* _EXT4_H */
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index 4024790028aa..04ebe77569a3 100644
> --- a/fs/f2fs/f2fs.h
> +++ b/fs/f2fs/f2fs.h
> @@ -3752,6 +3752,5 @@ static inline bool is_journalled_quota(struct f2fs_sb_info *sbi)
> }
>
> #define EFSBADCRC EBADMSG /* Bad CRC detected */
> -#define EFSCORRUPTED EUCLEAN /* Filesystem is corrupted */
>
> #endif /* _LINUX_F2FS_H */
> diff --git a/fs/xfs/xfs_linux.h b/fs/xfs/xfs_linux.h
> index ca15105681ca..3409d02a7d21 100644
> --- a/fs/xfs/xfs_linux.h
> +++ b/fs/xfs/xfs_linux.h
> @@ -123,7 +123,6 @@ typedef __u32 xfs_nlink_t;
>
> #define ENOATTR ENODATA /* Attribute not found */
> #define EWRONGFS EINVAL /* Mount with wrong filesystem type */
> -#define EFSCORRUPTED EUCLEAN /* Filesystem is corrupted */
> #define EFSBADCRC EBADMSG /* Bad CRC detected */
>
> #define SYNCHRONIZE() barrier()
> diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
> index 603fbc4e2f70..69411d7e0431 100644
> --- a/include/linux/jbd2.h
> +++ b/include/linux/jbd2.h
> @@ -1657,6 +1657,5 @@ static inline tid_t jbd2_get_latest_transaction(journal_t *journal)
> #endif /* __KERNEL__ */
>
> #define EFSBADCRC EBADMSG /* Bad CRC detected */
> -#define EFSCORRUPTED EUCLEAN /* Filesystem is corrupted */
>
> #endif /* _LINUX_JBD2_H */
> diff --git a/include/uapi/asm-generic/errno.h b/include/uapi/asm-generic/errno.h
> index cf9c51ac49f9..1d5ffdf54cb0 100644
> --- a/include/uapi/asm-generic/errno.h
> +++ b/include/uapi/asm-generic/errno.h
> @@ -98,6 +98,7 @@
> #define EINPROGRESS 115 /* Operation now in progress */
> #define ESTALE 116 /* Stale file handle */
> #define EUCLEAN 117 /* Structure needs cleaning */
> +#define EFSCORRUPTED EUCLEAN
BTW, minor, how about adding some comments right after EFSCORRUPTED
like the other error codes although it's now an alias...
Just my personal thought.
Thanks,
Gao Xiang
> #define ENOTNAM 118 /* Not a XENIX named type file */
> #define ENAVAIL 119 /* No XENIX semaphores available */
> #define EISNAM 120 /* Is a named type file */
> --
> 2.24.0.rc1
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 10/10] errno.h: Provide EFSCORRUPTED for everybody
2019-11-04 1:45 ` [PATCH 10/10] errno.h: Provide EFSCORRUPTED for everybody Valdis Kletnieks
2019-11-04 1:45 ` Valdis Kletnieks
2019-11-04 2:09 ` Gao Xiang
@ 2019-11-05 0:33 ` Christoph Hellwig
2019-11-05 0:33 ` Christoph Hellwig
2019-11-05 0:54 ` Valdis Klētnieks
2019-11-05 3:43 ` Chao Yu
3 siblings, 2 replies; 12+ messages in thread
From: Christoph Hellwig @ 2019-11-05 0:33 UTC (permalink / raw)
To: Valdis Kletnieks
Cc: Darrick J . Wong, Jan Kara, Theodore Ts'o, Greg Kroah-Hartman,
Gao Xiang, Chao Yu, Andreas Dilger, Jaegeuk Kim, linux-xfs,
Jan Kara, Arnd Bergmann, linux-fsdevel, devel, linux-kernel,
linux-erofs, linux-ext4, linux-f2fs-devel, linux-arch
On Sun, Nov 03, 2019 at 08:45:06PM -0500, Valdis Kletnieks wrote:
> There's currently 6 filesystems that have the same #define. Move it
> into errno.h so it's defined in just one place.
And 4 out of 6 also define EFSBADCRC, so please lift that as well.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 10/10] errno.h: Provide EFSCORRUPTED for everybody
2019-11-05 0:33 ` Christoph Hellwig
@ 2019-11-05 0:33 ` Christoph Hellwig
2019-11-05 0:54 ` Valdis Klētnieks
1 sibling, 0 replies; 12+ messages in thread
From: Christoph Hellwig @ 2019-11-05 0:33 UTC (permalink / raw)
To: Valdis Kletnieks
Cc: Darrick J . Wong, Jan Kara, Theodore Ts'o, Greg Kroah-Hartman,
Gao Xiang, Chao Yu, Andreas Dilger, Jaegeuk Kim, linux-xfs,
Jan Kara, Arnd Bergmann, linux-fsdevel, devel, linux-kernel,
linux-erofs, linux-ext4, linux-f2fs-devel, linux-arch
On Sun, Nov 03, 2019 at 08:45:06PM -0500, Valdis Kletnieks wrote:
> There's currently 6 filesystems that have the same #define. Move it
> into errno.h so it's defined in just one place.
And 4 out of 6 also define EFSBADCRC, so please lift that as well.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 10/10] errno.h: Provide EFSCORRUPTED for everybody
2019-11-05 0:33 ` Christoph Hellwig
2019-11-05 0:33 ` Christoph Hellwig
@ 2019-11-05 0:54 ` Valdis Klētnieks
2019-11-05 0:54 ` Valdis Klētnieks
1 sibling, 1 reply; 12+ messages in thread
From: Valdis Klētnieks @ 2019-11-05 0:54 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Darrick J . Wong, Jan Kara, Theodore Ts'o, Greg Kroah-Hartman,
Gao Xiang, Chao Yu, Andreas Dilger, Jaegeuk Kim, linux-xfs,
Jan Kara, Arnd Bergmann, linux-fsdevel, devel, linux-kernel,
linux-erofs, linux-ext4, linux-f2fs-devel, linux-arch
[-- Attachment #1: Type: text/plain, Size: 365 bytes --]
On Mon, 04 Nov 2019 16:33:06 -0800, Christoph Hellwig said:
> On Sun, Nov 03, 2019 at 08:45:06PM -0500, Valdis Kletnieks wrote:
> > There's currently 6 filesystems that have the same #define. Move it
> > into errno.h so it's defined in just one place.
>
> And 4 out of 6 also define EFSBADCRC, so please lift that as well.
Will do so in a separate patch shortly.
[-- Attachment #2: Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 10/10] errno.h: Provide EFSCORRUPTED for everybody
2019-11-05 0:54 ` Valdis Klētnieks
@ 2019-11-05 0:54 ` Valdis Klētnieks
0 siblings, 0 replies; 12+ messages in thread
From: Valdis Klētnieks @ 2019-11-05 0:54 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Darrick J . Wong, Jan Kara, Theodore Ts'o, Greg Kroah-Hartman,
Gao Xiang, Chao Yu, Andreas Dilger, Jaegeuk Kim, linux-xfs,
Jan Kara, Arnd Bergmann, linux-fsdevel, devel, linux-kernel,
linux-erofs, linux-ext4, linux-f2fs-devel, linux-arch
[-- Attachment #1: Type: text/plain, Size: 365 bytes --]
On Mon, 04 Nov 2019 16:33:06 -0800, Christoph Hellwig said:
> On Sun, Nov 03, 2019 at 08:45:06PM -0500, Valdis Kletnieks wrote:
> > There's currently 6 filesystems that have the same #define. Move it
> > into errno.h so it's defined in just one place.
>
> And 4 out of 6 also define EFSBADCRC, so please lift that as well.
Will do so in a separate patch shortly.
[-- Attachment #2: Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 10/10] errno.h: Provide EFSCORRUPTED for everybody
2019-11-04 1:45 ` [PATCH 10/10] errno.h: Provide EFSCORRUPTED for everybody Valdis Kletnieks
` (2 preceding siblings ...)
2019-11-05 0:33 ` Christoph Hellwig
@ 2019-11-05 3:43 ` Chao Yu
2019-11-05 3:43 ` Chao Yu
2019-11-06 21:37 ` Pavel Machek
3 siblings, 2 replies; 12+ messages in thread
From: Chao Yu @ 2019-11-05 3:43 UTC (permalink / raw)
To: Valdis Kletnieks
Cc: Darrick J . Wong, Jan Kara, Theodore Ts'o, Greg Kroah-Hartman,
Gao Xiang, Chao Yu, Andreas Dilger, Jaegeuk Kim, linux-xfs,
Jan Kara, Arnd Bergmann, linux-fsdevel, devel, linux-kernel,
linux-erofs, linux-ext4, linux-f2fs-devel, linux-arch
On 2019/11/4 9:45, Valdis Kletnieks wrote:
> There's currently 6 filesystems that have the same #define. Move it
> into errno.h so it's defined in just one place.
>
> Signed-off-by: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
> Acked-by: Darrick J. Wong <darrick.wong@oracle.com>
> Reviewed-by: Jan Kara <jack@suse.cz>
> Acked-by: Theodore Ts'o <tytso@mit.edu>
> fs/erofs/internal.h | 2 --
> fs/f2fs/f2fs.h | 1 -
Acked-by: Chao Yu <yuchao0@huawei.com>
Thanks,
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 10/10] errno.h: Provide EFSCORRUPTED for everybody
2019-11-05 3:43 ` Chao Yu
@ 2019-11-05 3:43 ` Chao Yu
2019-11-06 21:37 ` Pavel Machek
1 sibling, 0 replies; 12+ messages in thread
From: Chao Yu @ 2019-11-05 3:43 UTC (permalink / raw)
To: Valdis Kletnieks
Cc: Darrick J . Wong, Jan Kara, Theodore Ts'o, Greg Kroah-Hartman,
Gao Xiang, Chao Yu, Andreas Dilger, Jaegeuk Kim, linux-xfs,
Jan Kara, Arnd Bergmann, linux-fsdevel, devel, linux-kernel,
linux-erofs, linux-ext4, linux-f2fs-devel, linux-arch
On 2019/11/4 9:45, Valdis Kletnieks wrote:
> There's currently 6 filesystems that have the same #define. Move it
> into errno.h so it's defined in just one place.
>
> Signed-off-by: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
> Acked-by: Darrick J. Wong <darrick.wong@oracle.com>
> Reviewed-by: Jan Kara <jack@suse.cz>
> Acked-by: Theodore Ts'o <tytso@mit.edu>
> fs/erofs/internal.h | 2 --
> fs/f2fs/f2fs.h | 1 -
Acked-by: Chao Yu <yuchao0@huawei.com>
Thanks,
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 10/10] errno.h: Provide EFSCORRUPTED for everybody
2019-11-05 3:43 ` Chao Yu
2019-11-05 3:43 ` Chao Yu
@ 2019-11-06 21:37 ` Pavel Machek
2019-11-06 21:37 ` Pavel Machek
1 sibling, 1 reply; 12+ messages in thread
From: Pavel Machek @ 2019-11-06 21:37 UTC (permalink / raw)
To: Chao Yu
Cc: Valdis Kletnieks, Darrick J . Wong, Jan Kara, Theodore Ts'o,
Greg Kroah-Hartman, Gao Xiang, Chao Yu, Andreas Dilger,
Jaegeuk Kim, linux-xfs, Jan Kara, Arnd Bergmann, linux-fsdevel,
devel, linux-kernel, linux-erofs, linux-ext4, linux-f2fs-devel,
linux-arch
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
Hi!
> > There's currently 6 filesystems that have the same #define. Move it
> > into errno.h so it's defined in just one place.
> >
> > Signed-off-by: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
> > Acked-by: Darrick J. Wong <darrick.wong@oracle.com>
> > Reviewed-by: Jan Kara <jack@suse.cz>
> > Acked-by: Theodore Ts'o <tytso@mit.edu>
>
> > fs/erofs/internal.h | 2 --
>
> > fs/f2fs/f2fs.h | 1 -
>
> Acked-by: Chao Yu <yuchao0@huawei.com>
Are we still using EUCLEAN for something else than EFSCORRUPTED? Could
we perhaps change the glibc definiton to "your filesystem is
corrupted" in the long run?
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 10/10] errno.h: Provide EFSCORRUPTED for everybody
2019-11-06 21:37 ` Pavel Machek
@ 2019-11-06 21:37 ` Pavel Machek
0 siblings, 0 replies; 12+ messages in thread
From: Pavel Machek @ 2019-11-06 21:37 UTC (permalink / raw)
To: Chao Yu
Cc: Valdis Kletnieks, Darrick J . Wong, Jan Kara, Theodore Ts'o,
Greg Kroah-Hartman, Gao Xiang, Chao Yu, Andreas Dilger,
Jaegeuk Kim, linux-xfs, Jan Kara, Arnd Bergmann, linux-fsdevel,
devel, linux-kernel, linux-erofs, linux-ext4, linux-f2fs-devel,
linux-arch
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
Hi!
> > There's currently 6 filesystems that have the same #define. Move it
> > into errno.h so it's defined in just one place.
> >
> > Signed-off-by: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
> > Acked-by: Darrick J. Wong <darrick.wong@oracle.com>
> > Reviewed-by: Jan Kara <jack@suse.cz>
> > Acked-by: Theodore Ts'o <tytso@mit.edu>
>
> > fs/erofs/internal.h | 2 --
>
> > fs/f2fs/f2fs.h | 1 -
>
> Acked-by: Chao Yu <yuchao0@huawei.com>
Are we still using EUCLEAN for something else than EFSCORRUPTED? Could
we perhaps change the glibc definiton to "your filesystem is
corrupted" in the long run?
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread