From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Rapoport Subject: Re: [PATCH v4 05/13] m68k: mm: use pgtable-nopXd instead of 4level-fixup Date: Sun, 10 Nov 2019 10:41:26 +0200 Message-ID: <20191110084125.GA9494@rapoport-lnx> References: <1572938135-31886-1-git-send-email-rppt@kernel.org> <1572938135-31886-6-git-send-email-rppt@kernel.org> <20191108113917.a9c6ebb8373cc95fd684b734@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Geert Uytterhoeven Cc: Linux/m68k , "James E.J. Bottomley" , Linux MM , sparclinux , Rolf Eike Beer , Vincent Chen , Greg Ungerer , Anton Ivanov , Linux-Arch , linux-c6x-dev@linux-c6x.org, Richard Weinberger , Helge Deller , Russell King , Mike Rapoport , Mark Salter , Matt Turner , Vineet Gupta , Sam Creasey , Arnd Bergmann , Jeff Dike , linux-um@lists.infradead.org, Greentime Hu , "Kirill A. Shutemov" , Linux ARM List-Id: linux-arch.vger.kernel.org Hi Andrew, On Sat, Nov 09, 2019 at 03:26:29PM +0100, Geert Uytterhoeven wrote: > Hi Andrew, > > On Fri, Nov 8, 2019 at 8:39 PM Andrew Morton wrote: > > On Tue, 5 Nov 2019 09:15:27 +0200 Mike Rapoport wrote: > > > m68k has two or three levels of page tables and can use appropriate > > > pgtable-nopXd and folding of the upper layers. > > > > > > Replace usage of include/asm-generic/4level-fixup.h and explicit > > > definitions of __PAGETABLE_PxD_FOLDED in m68k with > > > include/asm-generic/pgtable-nopmd.h for two-level configurations and with > > > include/asm-generic/pgtable-nopud.h for three-lelve configurations and > > > adjust page table manipulation macros and functions accordingly. > > > > This one was messed up by linux-next changes in arch/m68k/mm/kmap.c. > > Can you please take a look? Can you please elaborate what was the problem? The patch applies cleanly to v5.4-rc6-mmots-2019-11-08-16-23 (from github.com/hnaz/linux-mm) and all the page table traversals in arch/m68k/mm/kmap.c look Ok. I've build atari_defconfig and it boots fine on aranym. > You mean due to the rename and move of __iounmap() to __free_io_area() > in commit aa3a1664285d0bec ("m68k: rename __iounmap and mark it static")? > > Commit 42d6c83d6180f800 ("m68k: mm: use pgtable-nopXd instead of > 4level-fixup") in next-20191108 looks good to me. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sun, 10 Nov 2019 10:41:26 +0200 From: Mike Rapoport Subject: Re: [PATCH v4 05/13] m68k: mm: use pgtable-nopXd instead of 4level-fixup Message-ID: <20191110084125.GA9494@rapoport-lnx> References: <1572938135-31886-1-git-send-email-rppt@kernel.org> <1572938135-31886-6-git-send-email-rppt@kernel.org> <20191108113917.a9c6ebb8373cc95fd684b734@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: Geert Uytterhoeven Cc: Andrew Morton , Linux MM , Anton Ivanov , Arnd Bergmann , "David S. Miller" , Greentime Hu , Greg Ungerer , Helge Deller , "James E.J. Bottomley" , Jeff Dike , "Kirill A. Shutemov" , Linus Torvalds , Mark Salter , Matt Turner , Michal Simek , Peter Rosin , Richard Weinberger , Rolf Eike Beer , Russell King , Sam Creasey , Vincent Chen , Vineet Gupta , alpha , Linux-Arch , Linux ARM , linux-c6x-dev@linux-c6x.org, Linux Kernel Mailing List , Linux/m68k , Parisc List , linux-um@lists.infradead.org, sparclinux , Mike Rapoport List-ID: Message-ID: <20191110084126.g6aBKWPhqlqJVuKZ2tChMr0qiz2D1JqaCkB5kFc0DsI@z> Hi Andrew, On Sat, Nov 09, 2019 at 03:26:29PM +0100, Geert Uytterhoeven wrote: > Hi Andrew, > > On Fri, Nov 8, 2019 at 8:39 PM Andrew Morton wrote: > > On Tue, 5 Nov 2019 09:15:27 +0200 Mike Rapoport wrote: > > > m68k has two or three levels of page tables and can use appropriate > > > pgtable-nopXd and folding of the upper layers. > > > > > > Replace usage of include/asm-generic/4level-fixup.h and explicit > > > definitions of __PAGETABLE_PxD_FOLDED in m68k with > > > include/asm-generic/pgtable-nopmd.h for two-level configurations and with > > > include/asm-generic/pgtable-nopud.h for three-lelve configurations and > > > adjust page table manipulation macros and functions accordingly. > > > > This one was messed up by linux-next changes in arch/m68k/mm/kmap.c. > > Can you please take a look? Can you please elaborate what was the problem? The patch applies cleanly to v5.4-rc6-mmots-2019-11-08-16-23 (from github.com/hnaz/linux-mm) and all the page table traversals in arch/m68k/mm/kmap.c look Ok. I've build atari_defconfig and it boots fine on aranym. > You mean due to the rename and move of __iounmap() to __free_io_area() > in commit aa3a1664285d0bec ("m68k: rename __iounmap and mark it static")? > > Commit 42d6c83d6180f800 ("m68k: mm: use pgtable-nopXd instead of > 4level-fixup") in next-20191108 looks good to me. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Sincerely yours, Mike.