From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH v2 11/29] vmlinux.lds.h: Replace RODATA with RO_DATA Date: Tue, 12 Nov 2019 10:07:36 +0100 Message-ID: <20191112090736.GA32336@zn.tnic> References: <20191011000609.29728-1-keescook@chromium.org> <20191011000609.29728-12-keescook@chromium.org> <201911110922.17A2112B0@keescook> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Kees Cook , Rick Edgecombe , Dave Hansen , Andy Lutomirski , Arnd Bergmann , Michael Ellerman , Heiko Carstens , Will Deacon , Linux-Arch , Linux ARM , linuxppc-dev , alpha , "linux-ia64@vger.kernel.org" , linux-s390 , linux-c6x-dev@linux-c6x.org, Yoshinori Sato , Michal Simek , Parisc List , linux-xtensa@linux-xtens List-Id: linux-arch.vger.kernel.org On Mon, Nov 11, 2019 at 07:08:51PM +0100, Geert Uytterhoeven wrote: > vmlinux-std.lds: All other classic 680x0 targets with an MMU, e.g. plain > defconfig aka multi_defconfig. FWIW, the defconfig doesn't build with the cross compiler¹ here, even with Kees' patch applied but for a different reason: $ make.cross ARCH=m68k defconfig ... $make.cross ARCH=m68k 2>w.log ... drivers/video/fbdev/c2p_planar.o: In function `transp8': c2p_planar.c:(.text+0x13a): undefined reference to `c2p_unsupported' c2p_planar.c:(.text+0x1de): undefined reference to `c2p_unsupported' drivers/video/fbdev/c2p_iplan2.o: In function `transp4x.constprop.0': c2p_iplan2.c:(.text+0x98): undefined reference to `c2p_unsupported' make: *** [Makefile:1094: vmlinux] Error 1 ¹ https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/x86_64/8.1.0/ -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.skyhub.de ([5.9.137.197]:44086 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725944AbfKLJIO (ORCPT ); Tue, 12 Nov 2019 04:08:14 -0500 Date: Tue, 12 Nov 2019 10:07:36 +0100 From: Borislav Petkov Subject: Re: [PATCH v2 11/29] vmlinux.lds.h: Replace RODATA with RO_DATA Message-ID: <20191112090736.GA32336@zn.tnic> References: <20191011000609.29728-1-keescook@chromium.org> <20191011000609.29728-12-keescook@chromium.org> <201911110922.17A2112B0@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Geert Uytterhoeven Cc: Kees Cook , Rick Edgecombe , Dave Hansen , Andy Lutomirski , Arnd Bergmann , Michael Ellerman , Heiko Carstens , Will Deacon , Linux-Arch , Linux ARM , linuxppc-dev , alpha , "linux-ia64@vger.kernel.org" , linux-s390 , linux-c6x-dev@linux-c6x.org, Yoshinori Sato , Michal Simek , Parisc List , linux-xtensa@linux-xtensa.org, the arch/x86 maintainers , Linux Kernel Mailing List Message-ID: <20191112090736.RU-72NZEXLptggvzdCL1Omsbt3aWGwHiaR2S29hafy0@z> On Mon, Nov 11, 2019 at 07:08:51PM +0100, Geert Uytterhoeven wrote: > vmlinux-std.lds: All other classic 680x0 targets with an MMU, e.g. plain > defconfig aka multi_defconfig. FWIW, the defconfig doesn't build with the cross compiler¹ here, even with Kees' patch applied but for a different reason: $ make.cross ARCH=m68k defconfig ... $make.cross ARCH=m68k 2>w.log ... drivers/video/fbdev/c2p_planar.o: In function `transp8': c2p_planar.c:(.text+0x13a): undefined reference to `c2p_unsupported' c2p_planar.c:(.text+0x1de): undefined reference to `c2p_unsupported' drivers/video/fbdev/c2p_iplan2.o: In function `transp4x.constprop.0': c2p_iplan2.c:(.text+0x98): undefined reference to `c2p_unsupported' make: *** [Makefile:1094: vmlinux] Error 1 ¹ https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/x86_64/8.1.0/ -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette