From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Rapoport Subject: Re: Bug 205201 - Booting halts if Dawicontrol DC-2976 UW SCSI board installed, unless RAM size limited to 3500M Date: Mon, 25 Nov 2019 11:32:00 +0200 Message-ID: <20191125093159.GA23118@linux.ibm.com> References: <20191121072943.GA24024@lst.de> <6eec5c42-019c-a988-fc2a-cb804194683d@xenosoft.de> <20191121180226.GA3852@lst.de> <2fde79cf-875f-94e6-4a1b-f73ebb2e2c32@xenosoft.de> <20191125073923.GA30168@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20191125073923.GA30168-jcswGhMUV9g@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Sender: "iommu" To: Christoph Hellwig Cc: linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, darren-YHtdit1eIT3easaKlIn9Lw@public.gmane.org, rtd2-kGM0oXzJM5p02iOg2JU2CQ@public.gmane.org, Benjamin Herrenschmidt , linuxppc-dev , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Rob Herring , paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org, mad skateman , Christian Zigotzky , "contact-+1neenJGU+oAvxtiuMwx3w@public.gmane.org" , Robin Murphy , nsaenzjulienne-l3A5Bk7waGM@public.gmane.org List-Id: linux-arch.vger.kernel.org On Mon, Nov 25, 2019 at 08:39:23AM +0100, Christoph Hellwig wrote: > On Sat, Nov 23, 2019 at 12:42:27PM +0100, Christian Zigotzky wrote: > > Hello Christoph, > > > > Please find attached the dmesg of your Git kernel. > > Thanks. It looks like on your platform the swiotlb buffer isn't > actually addressable based on the bus dma mask limit, which is rather > interesting. swiotlb_init uses memblock_alloc_low to allocate the > buffer, and I'll need some help from Mike and the powerpc maintainers > to figure out how that select where to allocate the buffer from, and > how we can move it to a lower address. My gut feeling would be to try > to do what arm64 does and define a new ARCH_LOW_ADDRESS_LIMIT, preferably > without needing too much arch specific magic. Presuming the problem is relevant for all CoreNet boards something like this could work: diff --git a/arch/powerpc/include/asm/dma.h b/arch/powerpc/include/asm/dma.h index 1b4f0254868f..7c6cfeeaff52 100644 --- a/arch/powerpc/include/asm/dma.h +++ b/arch/powerpc/include/asm/dma.h @@ -347,5 +347,11 @@ extern int isa_dma_bridge_buggy; #define isa_dma_bridge_buggy (0) #endif +#ifdef CONFIG_CORENET_GENERIC +extern phys_addr_t ppc_dma_phys_limit; +#define ARCH_LOW_ADDRESS_LIMIT (ppc_dma_phys_limit - 1) +#endif + + #endif /* __KERNEL__ */ #endif /* _ASM_POWERPC_DMA_H */ diff --git a/arch/powerpc/platforms/85xx/common.c b/arch/powerpc/platforms/85xx/common.c index fe0606439b5a..346b436b6d3f 100644 --- a/arch/powerpc/platforms/85xx/common.c +++ b/arch/powerpc/platforms/85xx/common.c @@ -126,3 +126,7 @@ void __init mpc85xx_qe_par_io_init(void) } } #endif + +#ifdef CONFIG_CORENET_GENERIC +phys_addr_t ppc_dma_phys_limit = 0xffffffffUL; +#endif diff --git a/arch/powerpc/platforms/85xx/corenet_generic.c b/arch/powerpc/platforms/85xx/corenet_generic.c index 7ee2c6628f64..673bcbdc7c75 100644 --- a/arch/powerpc/platforms/85xx/corenet_generic.c +++ b/arch/powerpc/platforms/85xx/corenet_generic.c @@ -64,7 +64,7 @@ void __init corenet_gen_setup_arch(void) mpc85xx_smp_init(); swiotlb_detect_4g(); - + ppc_dma_phys_limit = 0x0fffffffUL; pr_info("%s board\n", ppc_md.name); mpc85xx_qe_init(); > As a quick hack can you try this patch on top of the tree from Friday? > > diff --git a/include/linux/memblock.h b/include/linux/memblock.h > index f491690d54c6..e3f95c362922 100644 > --- a/include/linux/memblock.h > +++ b/include/linux/memblock.h > @@ -344,7 +344,7 @@ static inline int memblock_get_region_node(const struct memblock_region *r) > #define MEMBLOCK_LOW_LIMIT 0 > > #ifndef ARCH_LOW_ADDRESS_LIMIT > -#define ARCH_LOW_ADDRESS_LIMIT 0xffffffffUL > +#define ARCH_LOW_ADDRESS_LIMIT 0x0fffffffUL > #endif > > phys_addr_t memblock_phys_alloc_range(phys_addr_t size, phys_addr_t align, -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:54480 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725793AbfKYJcL (ORCPT ); Mon, 25 Nov 2019 04:32:11 -0500 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xAP9Rrj9061973 for ; Mon, 25 Nov 2019 04:32:10 -0500 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 2wfk9aanea-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 25 Nov 2019 04:32:10 -0500 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 25 Nov 2019 09:32:08 -0000 Date: Mon, 25 Nov 2019 11:32:00 +0200 From: Mike Rapoport Subject: Re: Bug 205201 - Booting halts if Dawicontrol DC-2976 UW SCSI board installed, unless RAM size limited to 3500M References: <20191121072943.GA24024@lst.de> <6eec5c42-019c-a988-fc2a-cb804194683d@xenosoft.de> <20191121180226.GA3852@lst.de> <2fde79cf-875f-94e6-4a1b-f73ebb2e2c32@xenosoft.de> <20191125073923.GA30168@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191125073923.GA30168@lst.de> Message-ID: <20191125093159.GA23118@linux.ibm.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Christoph Hellwig Cc: Christian Zigotzky , Robin Murphy , linux-arch@vger.kernel.org, darren@stevens-zone.net, mad skateman , Benjamin Herrenschmidt , linux-kernel@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Rob Herring , paulus@samba.org, rtd2@xtra.co.nz, "contact@a-eon.com" , linuxppc-dev , nsaenzjulienne@suse.de Message-ID: <20191125093200.GMv9yXnDQsJL8yHD9wgHwrd_0MNjo8IhmizlOoPOsKc@z> On Mon, Nov 25, 2019 at 08:39:23AM +0100, Christoph Hellwig wrote: > On Sat, Nov 23, 2019 at 12:42:27PM +0100, Christian Zigotzky wrote: > > Hello Christoph, > > > > Please find attached the dmesg of your Git kernel. > > Thanks. It looks like on your platform the swiotlb buffer isn't > actually addressable based on the bus dma mask limit, which is rather > interesting. swiotlb_init uses memblock_alloc_low to allocate the > buffer, and I'll need some help from Mike and the powerpc maintainers > to figure out how that select where to allocate the buffer from, and > how we can move it to a lower address. My gut feeling would be to try > to do what arm64 does and define a new ARCH_LOW_ADDRESS_LIMIT, preferably > without needing too much arch specific magic. Presuming the problem is relevant for all CoreNet boards something like this could work: diff --git a/arch/powerpc/include/asm/dma.h b/arch/powerpc/include/asm/dma.h index 1b4f0254868f..7c6cfeeaff52 100644 --- a/arch/powerpc/include/asm/dma.h +++ b/arch/powerpc/include/asm/dma.h @@ -347,5 +347,11 @@ extern int isa_dma_bridge_buggy; #define isa_dma_bridge_buggy (0) #endif +#ifdef CONFIG_CORENET_GENERIC +extern phys_addr_t ppc_dma_phys_limit; +#define ARCH_LOW_ADDRESS_LIMIT (ppc_dma_phys_limit - 1) +#endif + + #endif /* __KERNEL__ */ #endif /* _ASM_POWERPC_DMA_H */ diff --git a/arch/powerpc/platforms/85xx/common.c b/arch/powerpc/platforms/85xx/common.c index fe0606439b5a..346b436b6d3f 100644 --- a/arch/powerpc/platforms/85xx/common.c +++ b/arch/powerpc/platforms/85xx/common.c @@ -126,3 +126,7 @@ void __init mpc85xx_qe_par_io_init(void) } } #endif + +#ifdef CONFIG_CORENET_GENERIC +phys_addr_t ppc_dma_phys_limit = 0xffffffffUL; +#endif diff --git a/arch/powerpc/platforms/85xx/corenet_generic.c b/arch/powerpc/platforms/85xx/corenet_generic.c index 7ee2c6628f64..673bcbdc7c75 100644 --- a/arch/powerpc/platforms/85xx/corenet_generic.c +++ b/arch/powerpc/platforms/85xx/corenet_generic.c @@ -64,7 +64,7 @@ void __init corenet_gen_setup_arch(void) mpc85xx_smp_init(); swiotlb_detect_4g(); - + ppc_dma_phys_limit = 0x0fffffffUL; pr_info("%s board\n", ppc_md.name); mpc85xx_qe_init(); > As a quick hack can you try this patch on top of the tree from Friday? > > diff --git a/include/linux/memblock.h b/include/linux/memblock.h > index f491690d54c6..e3f95c362922 100644 > --- a/include/linux/memblock.h > +++ b/include/linux/memblock.h > @@ -344,7 +344,7 @@ static inline int memblock_get_region_node(const struct memblock_region *r) > #define MEMBLOCK_LOW_LIMIT 0 > > #ifndef ARCH_LOW_ADDRESS_LIMIT > -#define ARCH_LOW_ADDRESS_LIMIT 0xffffffffUL > +#define ARCH_LOW_ADDRESS_LIMIT 0x0fffffffUL > #endif > > phys_addr_t memblock_phys_alloc_range(phys_addr_t size, phys_addr_t align, -- Sincerely yours, Mike.