From: Alex Kogan <alex.kogan@oracle.com>
To: linux@armlinux.org.uk, peterz@infradead.org, mingo@redhat.com,
will.deacon@arm.com, arnd@arndb.de, longman@redhat.com,
linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, tglx@linutronix.de, bp@alien8.de,
hpa@zytor.com, x86@kernel.org, guohanjun@huawei.com,
jglauber@marvell.com
Cc: steven.sistare@oracle.com, daniel.m.jordan@oracle.com,
alex.kogan@oracle.com, dave.dice@oracle.com,
rahul.x.yadav@oracle.com
Subject: [PATCH v7 0/5] Add NUMA-awareness to qspinlock
Date: Mon, 25 Nov 2019 16:07:04 -0500 [thread overview]
Message-ID: <20191125210709.10293-1-alex.kogan@oracle.com> (raw)
Minor change from v6:
---------------------
- fixed a 32-bit build failure by adding dependency on 64BIT in Kconfig.
Reported-by: kbuild test robot <lkp@intel.com>
Summary
-------
Lock throughput can be increased by handing a lock to a waiter on the
same NUMA node as the lock holder, provided care is taken to avoid
starvation of waiters on other NUMA nodes. This patch introduces CNA
(compact NUMA-aware lock) as the slow path for qspinlock. It is
enabled through a configuration option (NUMA_AWARE_SPINLOCKS).
CNA is a NUMA-aware version of the MCS lock. Spinning threads are
organized in two queues, a main queue for threads running on the same
node as the current lock holder, and a secondary queue for threads
running on other nodes. Threads store the ID of the node on which
they are running in their queue nodes. After acquiring the MCS lock and
before acquiring the spinlock, the lock holder scans the main queue
looking for a thread running on the same node (pre-scan). If found (call
it thread T), all threads in the main queue between the current lock
holder and T are moved to the end of the secondary queue. If such T
is not found, we make another scan of the main queue after acquiring
the spinlock when unlocking the MCS lock (post-scan), starting at the
node where pre-scan stopped. If both scans fail to find such T, the
MCS lock is passed to the first thread in the secondary queue. If the
secondary queue is empty, the MCS lock is passed to the next thread in the
main queue. To avoid starvation of threads in the secondary queue, those
threads are moved back to the head of the main queue after a certain
number of intra-node lock hand-offs.
More details are available at https://arxiv.org/abs/1810.05600.
The series applies on top of v5.4.0, commit eae56099de85.
Performance numbers are available in previous revisions
of the series.
Further comments are welcome and appreciated.
Alex Kogan (5):
locking/qspinlock: Rename mcs lock/unlock macros and make them more
generic
locking/qspinlock: Refactor the qspinlock slow path
locking/qspinlock: Introduce CNA into the slow path of qspinlock
locking/qspinlock: Introduce starvation avoidance into CNA
locking/qspinlock: Introduce the shuffle reduction optimization into
CNA
.../admin-guide/kernel-parameters.txt | 18 +
arch/arm/include/asm/mcs_spinlock.h | 6 +-
arch/x86/Kconfig | 20 ++
arch/x86/include/asm/qspinlock.h | 4 +
arch/x86/kernel/alternative.c | 70 ++++
include/asm-generic/mcs_spinlock.h | 4 +-
kernel/locking/mcs_spinlock.h | 20 +-
kernel/locking/qspinlock.c | 77 ++++-
kernel/locking/qspinlock_cna.h | 319 ++++++++++++++++++
kernel/locking/qspinlock_paravirt.h | 2 +-
10 files changed, 517 insertions(+), 23 deletions(-)
create mode 100644 kernel/locking/qspinlock_cna.h
--
2.21.0 (Apple Git-122.2)
next reply other threads:[~2019-11-25 21:07 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 21:07 Alex Kogan [this message]
2019-11-25 21:07 ` [PATCH v7 0/5] Add NUMA-awareness to qspinlock Alex Kogan
2019-11-25 21:07 ` [PATCH v7 1/5] locking/qspinlock: Rename mcs lock/unlock macros and make them more generic Alex Kogan
2019-11-25 21:07 ` Alex Kogan
2020-01-22 9:15 ` Peter Zijlstra
2020-01-22 9:15 ` Peter Zijlstra
[not found] ` <C608A39E-CAFC-4C79-9EB6-3DFD9621E3F6@oracle.com>
2020-01-25 11:23 ` Peter Zijlstra
2020-01-25 11:23 ` Peter Zijlstra
2019-11-25 21:07 ` [PATCH v7 2/5] locking/qspinlock: Refactor the qspinlock slow path Alex Kogan
2019-11-25 21:07 ` Alex Kogan
2019-11-25 21:07 ` [PATCH v7 3/5] locking/qspinlock: Introduce CNA into the slow path of qspinlock Alex Kogan
2019-11-25 21:07 ` Alex Kogan
2019-12-06 17:21 ` Waiman Long
2019-12-06 17:21 ` Waiman Long
2019-12-06 19:50 ` Alex Kogan
2019-12-06 19:50 ` Alex Kogan
2020-01-21 20:29 ` Peter Zijlstra
2020-01-21 20:29 ` Peter Zijlstra
2020-01-22 8:58 ` Will Deacon
2020-01-22 9:22 ` Peter Zijlstra
2020-01-22 9:22 ` Peter Zijlstra
2020-01-22 9:51 ` Peter Zijlstra
2020-01-22 9:51 ` Peter Zijlstra
2020-01-22 17:04 ` Peter Zijlstra
2020-01-22 17:04 ` Peter Zijlstra
2020-01-23 9:00 ` Peter Zijlstra
2020-01-23 9:00 ` Peter Zijlstra
2020-01-30 22:01 ` Alex Kogan
2020-01-31 13:35 ` Peter Zijlstra
2020-01-31 13:35 ` Peter Zijlstra
2020-01-31 18:33 ` Alex Kogan
2020-01-31 18:33 ` Alex Kogan
2019-11-25 21:07 ` [PATCH v7 4/5] locking/qspinlock: Introduce starvation avoidance into CNA Alex Kogan
2019-11-25 21:07 ` Alex Kogan
2019-12-06 18:09 ` Waiman Long
2019-12-06 18:09 ` Waiman Long
2019-11-25 21:07 ` [PATCH v7 5/5] locking/qspinlock: Introduce the shuffle reduction optimization " Alex Kogan
2019-11-25 21:07 ` Alex Kogan
2019-12-06 22:00 ` Waiman Long
2019-12-06 22:00 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125210709.10293-1-alex.kogan@oracle.com \
--to=alex.kogan@oracle.com \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=daniel.m.jordan@oracle.com \
--cc=dave.dice@oracle.com \
--cc=guohanjun@huawei.com \
--cc=hpa@zytor.com \
--cc=jglauber@marvell.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rahul.x.yadav@oracle.com \
--cc=steven.sistare@oracle.com \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).