From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Dobriyan Subject: Re: [PATCH] exec: warn if process starts with executable stack Date: Sun, 8 Dec 2019 19:43:54 +0300 Message-ID: <20191208164354.GA19908@avx2> References: <20191118145114.GA9228@avx2> <20191118125457.778e44dfd4740d24795484c7@linux-foundation.org> <20191118215227.GA24536@avx2> <20191120191752.GC4799@willie-the-truck> <87d0dm47ii.fsf@x220.int.ebiederm.org> <20191121093806.GB1091@willie-the-truck> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20191121093806.GB1091@willie-the-truck> Sender: linux-kernel-owner@vger.kernel.org To: Will Deacon Cc: "Eric W. Biederman" , Andrew Morton , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, security@kernel.org, ben.dooks@codethink.co.uk List-Id: linux-arch.vger.kernel.org On Thu, Nov 21, 2019 at 09:38:06AM +0000, Will Deacon wrote: > On Wed, Nov 20, 2019 at 02:28:37PM -0600, Eric W. Biederman wrote: > > Will Deacon writes: > > > > > On Tue, Nov 19, 2019 at 12:52:27AM +0300, Alexey Dobriyan wrote: > > >> There were few episodes of silent downgrade to an executable stack: > > >> > > >> 1) linking innocent looking assembly file > > >> > > >> $ cat f.S > > >> .intel_syntax noprefix > > >> .text > > >> .globl f > > >> f: > > >> ret > > >> > > >> $ cat main.c > > >> void f(void); > > >> int main(void) > > >> { > > >> f(); > > >> return 0; > > >> } > > >> > > >> $ gcc main.c f.S > > >> $ readelf -l ./a.out > > >> GNU_STACK 0x0000000000000000 0x0000000000000000 0x0000000000000000 > > >> 0x0000000000000000 0x0000000000000000 RWE 0x10 > > >> > > >> 2) converting C99 nested function into a closure > > >> https://nullprogram.com/blog/2019/11/15/ > > >> > > >> void intsort2(int *base, size_t nmemb, _Bool invert) > > >> { > > >> int cmp(const void *a, const void *b) > > >> { > > >> int r = *(int *)a - *(int *)b; > > >> return invert ? -r : r; > > >> } > > >> qsort(base, nmemb, sizeof(*base), cmp); > > >> } > > >> > > >> will silently require stack trampolines while non-closure version will not. > > >> > > >> While without a double this behaviour is documented somewhere, add a warning > > >> so that developers and users can at least notice. After so many years of x86_64 > > >> having proper executable stack support it should not cause too much problems. > > >> > > >> If the system is old or CPU is old, then there will be an early warning > > >> against init and/or support personnel will write that "uh-oh, our Enterprise > > >> Software absolutely requires executable stack" and close tickets and customers > > >> will nod heads and life moves on. > > >> > > >> Signed-off-by: Alexey Dobriyan > > >> --- > > >> > > >> fs/exec.c | 5 +++++ > > >> 1 file changed, 5 insertions(+) > > >> > > >> --- a/fs/exec.c > > >> +++ b/fs/exec.c > > >> @@ -762,6 +762,11 @@ int setup_arg_pages(struct linux_binprm *bprm, > > >> goto out_unlock; > > >> BUG_ON(prev != vma); > > >> > > >> + if (vm_flags & VM_EXEC) { > > >> + pr_warn_once("process '%s'/%u started with executable stack\n", > > >> + current->comm, current->pid); > > >> + } > > > > > > Given that this is triggerable by userspace, is there a concern about PID > > > namespaces here? > > > > In what sense? Are you thinking about the printing of the pid? > > > > Pretty much by fiat and by definition the kernel log always print things > > in the initial pid namespace. Which this printk does. > > Ok, fair enough. Just wanted to make sure it was ok, since we're not using > a task_pid_nr*() accessor and it might have been overlooked. PID is printed both as ->pid and a task_pid_vnr(). I'll just print filename, so that executable can be easily found. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f67.google.com ([209.85.128.67]:55805 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726460AbfLHQoC (ORCPT ); Sun, 8 Dec 2019 11:44:02 -0500 Date: Sun, 8 Dec 2019 19:43:54 +0300 From: Alexey Dobriyan Subject: Re: [PATCH] exec: warn if process starts with executable stack Message-ID: <20191208164354.GA19908@avx2> References: <20191118145114.GA9228@avx2> <20191118125457.778e44dfd4740d24795484c7@linux-foundation.org> <20191118215227.GA24536@avx2> <20191120191752.GC4799@willie-the-truck> <87d0dm47ii.fsf@x220.int.ebiederm.org> <20191121093806.GB1091@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191121093806.GB1091@willie-the-truck> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Will Deacon Cc: "Eric W. Biederman" , Andrew Morton , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, security@kernel.org, ben.dooks@codethink.co.uk Message-ID: <20191208164354.cDv0Gzo1F8o7X15UsbkI-Nxv9i_i7amCTc7dRmCnOmU@z> On Thu, Nov 21, 2019 at 09:38:06AM +0000, Will Deacon wrote: > On Wed, Nov 20, 2019 at 02:28:37PM -0600, Eric W. Biederman wrote: > > Will Deacon writes: > > > > > On Tue, Nov 19, 2019 at 12:52:27AM +0300, Alexey Dobriyan wrote: > > >> There were few episodes of silent downgrade to an executable stack: > > >> > > >> 1) linking innocent looking assembly file > > >> > > >> $ cat f.S > > >> .intel_syntax noprefix > > >> .text > > >> .globl f > > >> f: > > >> ret > > >> > > >> $ cat main.c > > >> void f(void); > > >> int main(void) > > >> { > > >> f(); > > >> return 0; > > >> } > > >> > > >> $ gcc main.c f.S > > >> $ readelf -l ./a.out > > >> GNU_STACK 0x0000000000000000 0x0000000000000000 0x0000000000000000 > > >> 0x0000000000000000 0x0000000000000000 RWE 0x10 > > >> > > >> 2) converting C99 nested function into a closure > > >> https://nullprogram.com/blog/2019/11/15/ > > >> > > >> void intsort2(int *base, size_t nmemb, _Bool invert) > > >> { > > >> int cmp(const void *a, const void *b) > > >> { > > >> int r = *(int *)a - *(int *)b; > > >> return invert ? -r : r; > > >> } > > >> qsort(base, nmemb, sizeof(*base), cmp); > > >> } > > >> > > >> will silently require stack trampolines while non-closure version will not. > > >> > > >> While without a double this behaviour is documented somewhere, add a warning > > >> so that developers and users can at least notice. After so many years of x86_64 > > >> having proper executable stack support it should not cause too much problems. > > >> > > >> If the system is old or CPU is old, then there will be an early warning > > >> against init and/or support personnel will write that "uh-oh, our Enterprise > > >> Software absolutely requires executable stack" and close tickets and customers > > >> will nod heads and life moves on. > > >> > > >> Signed-off-by: Alexey Dobriyan > > >> --- > > >> > > >> fs/exec.c | 5 +++++ > > >> 1 file changed, 5 insertions(+) > > >> > > >> --- a/fs/exec.c > > >> +++ b/fs/exec.c > > >> @@ -762,6 +762,11 @@ int setup_arg_pages(struct linux_binprm *bprm, > > >> goto out_unlock; > > >> BUG_ON(prev != vma); > > >> > > >> + if (vm_flags & VM_EXEC) { > > >> + pr_warn_once("process '%s'/%u started with executable stack\n", > > >> + current->comm, current->pid); > > >> + } > > > > > > Given that this is triggerable by userspace, is there a concern about PID > > > namespaces here? > > > > In what sense? Are you thinking about the printing of the pid? > > > > Pretty much by fiat and by definition the kernel log always print things > > in the initial pid namespace. Which this printk does. > > Ok, fair enough. Just wanted to make sure it was ok, since we're not using > a task_pid_nr*() accessor and it might have been overlooked. PID is printed both as ->pid and a task_pid_vnr(). I'll just print filename, so that executable can be easily found.