Re: [patch V2 05/17] x86/traps: Make interrupt enable/disable symmetric in C code

Alexandre Chartre
2019-11-06T16:19:44Z

On 10/23/19 2:27 PM, Thomas Gleixner wrote:
> Traps enable interrupts conditionally but rely on the ASM return code to
> disable them again. That results in redundant interrupt disable and trace
> calls.
>
> Make the trap handlers disable interrupts before returning to avoid that,
> which allows simplification of the ASM entry code.
>
> Originally-by: Peter Zijlstra <peterz@infradead.org>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
> arch/x86/kernel/traps.c | 32 +++++++++++++++++++++-----------
> arch/x86/mm/fault.c | 7 +++++--
> 2 files changed, 26 insertions(+), 13 deletions(-)
>

Reviewed-by: Alexandre Chartre <alexandre.chartre@oracle.com>

alex.