From mboxrd@z Thu Jan 1 00:00:00 1970 From: Catalin Marinas Subject: Re: [PATCH v4 02/12] ELF: Add ELF program property parsing support Date: Tue, 14 Jan 2020 16:34:03 +0000 Message-ID: <20200114163402.GH30444@arrakis.emea.arm.com> References: <20191211154206.46260-1-broonie@kernel.org> <20191211154206.46260-3-broonie@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20191211154206.46260-3-broonie@kernel.org> Sender: linux-kernel-owner@vger.kernel.org To: Mark Brown Cc: Will Deacon , Paul Elliott , Peter Zijlstra , Yu-cheng Yu , Amit Kachhap , Vincenzo Frascino , Marc Zyngier , Eugene Syromiatnikov , Szabolcs Nagy , "H.J. Lu" , Andrew Jones , Kees Cook , Arnd Bergmann , Jann Horn , Richard Henderson , Kristina =?utf-8?Q?Mart=C5=A1enko?= , Thomas Gleixner , Florian Weimer , Sudakshina Das , linux-arm-kernel@lists.infradead.orgli List-Id: linux-arch.vger.kernel.org On Wed, Dec 11, 2019 at 03:41:56PM +0000, Mark Brown wrote: > From: Dave Martin > > ELF program properties will be needed for detecting whether to > enable optional architecture or ABI features for a new ELF process. > > For now, there are no generic properties that we care about, so do > nothing unless CONFIG_ARCH_USE_GNU_PROPERTY=y. > > Otherwise, the presence of properties using the PT_PROGRAM_PROPERTY > phdrs entry (if any), and notify each property to the arch code. > > For now, the added code is not used. > > Signed-off-by: Dave Martin > Signed-off-by: Mark Brown As with the previous patch, this should also go to linux-fsdevel. The logic looks fine to me but I'm not sure the choice of returning -EIO is suitable in most cases. I think apart from kernel_read() returning an error, there rest look like malformed ELF notes, so rather -ENOEXEC. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com ([217.140.110.172]:54502 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726121AbgANQeJ (ORCPT ); Tue, 14 Jan 2020 11:34:09 -0500 Date: Tue, 14 Jan 2020 16:34:03 +0000 From: Catalin Marinas Subject: Re: [PATCH v4 02/12] ELF: Add ELF program property parsing support Message-ID: <20200114163402.GH30444@arrakis.emea.arm.com> References: <20191211154206.46260-1-broonie@kernel.org> <20191211154206.46260-3-broonie@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191211154206.46260-3-broonie@kernel.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Mark Brown Cc: Will Deacon , Paul Elliott , Peter Zijlstra , Yu-cheng Yu , Amit Kachhap , Vincenzo Frascino , Marc Zyngier , Eugene Syromiatnikov , Szabolcs Nagy , "H.J. Lu" , Andrew Jones , Kees Cook , Arnd Bergmann , Jann Horn , Richard Henderson , Kristina =?utf-8?Q?Mart=C5=A1enko?= , Thomas Gleixner , Florian Weimer , Sudakshina Das , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Dave Martin Message-ID: <20200114163403.FnxYXv-UTU4ZeDPRkodYVmJzljUHB1z8ZgqQugSOLVs@z> On Wed, Dec 11, 2019 at 03:41:56PM +0000, Mark Brown wrote: > From: Dave Martin > > ELF program properties will be needed for detecting whether to > enable optional architecture or ABI features for a new ELF process. > > For now, there are no generic properties that we care about, so do > nothing unless CONFIG_ARCH_USE_GNU_PROPERTY=y. > > Otherwise, the presence of properties using the PT_PROGRAM_PROPERTY > phdrs entry (if any), and notify each property to the arch code. > > For now, the added code is not used. > > Signed-off-by: Dave Martin > Signed-off-by: Mark Brown As with the previous patch, this should also go to linux-fsdevel. The logic looks fine to me but I'm not sure the choice of returning -EIO is suitable in most cases. I think apart from kernel_read() returning an error, there rest look like malformed ELF notes, so rather -ENOEXEC. -- Catalin