From: Peter Zijlstra <peterz@infradead.org>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Marco Elver <elver@google.com>,
andreyknvl@google.com, glider@google.com, dvyukov@google.com,
kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org,
mark.rutland@arm.com, will@kernel.org, boqun.feng@gmail.com,
arnd@arndb.de, viro@zeniv.linux.org.uk, christophe.leroy@c-s.fr,
dja@axtens.net, mpe@ellerman.id.au, rostedt@goodmis.org,
mhiramat@kernel.org, mingo@kernel.org,
christian.brauner@ubuntu.com, daniel@iogearbox.net,
cyphar@cyphar.com, keescook@chromium.org,
linux-arch@vger.kernel.org
Subject: Re: [PATCH 3/5] asm-generic, kcsan: Add KCSAN instrumentation for bitops
Date: Mon, 20 Jan 2020 17:52:23 +0100 [thread overview]
Message-ID: <20200120165223.GC14914@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200120162725.GE2935@paulmck-ThinkPad-P72>
On Mon, Jan 20, 2020 at 08:27:25AM -0800, Paul E. McKenney wrote:
> On Mon, Jan 20, 2020 at 03:40:48PM +0100, Peter Zijlstra wrote:
> > On Mon, Jan 20, 2020 at 03:19:25PM +0100, Marco Elver wrote:
> > > Add explicit KCSAN checks for bitops.
> > >
> > > Note that test_bit() is an atomic bitop, and we instrument it as such,
> >
> > Well, it is 'atomic' in the same way that atomic_read() is. Both are
> > very much not atomic ops, but are part of an interface that facilitates
> > atomic operations.
>
> True, but they all are either inline assembly or have either an
> implicit or explicit cast to volatile, so they could be treated
> the same as atomic_read(), correct? If not, what am I missing?
Sure, but that is due to instrumentation requirements, not anything
else.
Also note the distinct lack of __test_bit(), to mirror the non-atomic
__set_bit() and __clear_bit().
next prev parent reply other threads:[~2020-01-20 16:52 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 14:19 [PATCH 1/5] include/linux: Add instrumented.h infrastructure Marco Elver
2020-01-20 14:19 ` [PATCH 2/5] asm-generic, atomic-instrumented: Use generic instrumented.h Marco Elver
2020-01-20 14:19 ` Marco Elver
2020-01-20 14:19 ` [PATCH 3/5] asm-generic, kcsan: Add KCSAN instrumentation for bitops Marco Elver
2020-01-20 14:19 ` Marco Elver
2020-01-20 14:40 ` Peter Zijlstra
2020-01-20 16:27 ` Paul E. McKenney
2020-01-20 16:52 ` Peter Zijlstra [this message]
2020-01-20 16:52 ` Peter Zijlstra
2020-01-20 20:23 ` Paul E. McKenney
2020-01-20 20:23 ` Paul E. McKenney
2020-01-21 9:15 ` Peter Zijlstra
2020-01-21 9:15 ` Peter Zijlstra
2020-01-21 14:21 ` Paul E. McKenney
2020-01-21 14:47 ` Peter Zijlstra
2020-01-21 14:47 ` Peter Zijlstra
2020-01-21 15:07 ` Marco Elver
2020-01-21 15:07 ` Marco Elver
2020-01-21 16:16 ` Paul E. McKenney
2020-01-21 16:16 ` Paul E. McKenney
2020-01-20 14:19 ` [PATCH 4/5] iov_iter: Use generic instrumented.h Marco Elver
2020-01-20 14:19 ` Marco Elver
2020-01-20 14:19 ` [PATCH 5/5] copy_to_user, copy_from_user: " Marco Elver
2020-01-20 14:51 ` Dmitry Vyukov
2020-01-20 14:51 ` Dmitry Vyukov
2020-01-20 15:05 ` Marco Elver
2020-01-20 15:05 ` Marco Elver
2020-01-20 14:25 ` [PATCH 1/5] include/linux: Add instrumented.h infrastructure Alexander Potapenko
2020-01-20 14:25 ` Alexander Potapenko
2020-01-20 14:34 ` Dmitry Vyukov
2020-01-20 14:34 ` Dmitry Vyukov
2020-01-20 15:53 ` Marco Elver
2020-01-20 15:53 ` Marco Elver
2020-01-20 14:45 ` Dmitry Vyukov
2020-01-20 14:45 ` Dmitry Vyukov
2020-01-20 14:58 ` Dmitry Vyukov
2020-01-20 14:58 ` Dmitry Vyukov
2020-01-20 15:09 ` Dmitry Vyukov
2020-01-20 15:09 ` Dmitry Vyukov
2020-01-20 15:40 ` Marco Elver
2020-01-20 15:40 ` Marco Elver
2020-01-20 16:06 ` Dmitry Vyukov
2020-01-20 16:06 ` Dmitry Vyukov
2020-01-20 16:25 ` Marco Elver
2020-01-20 16:25 ` Marco Elver
2020-01-20 16:39 ` Dmitry Vyukov
2020-01-20 16:39 ` Dmitry Vyukov
2020-01-21 9:44 ` Marco Elver
2020-01-21 9:44 ` Marco Elver
2020-01-21 13:01 ` Dmitry Vyukov
2020-01-21 13:01 ` Dmitry Vyukov
2020-01-21 16:14 ` Marco Elver
2020-01-21 16:14 ` Marco Elver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120165223.GC14914@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=andreyknvl@google.com \
--cc=arnd@arndb.de \
--cc=boqun.feng@gmail.com \
--cc=christian.brauner@ubuntu.com \
--cc=christophe.leroy@c-s.fr \
--cc=cyphar@cyphar.com \
--cc=daniel@iogearbox.net \
--cc=dja@axtens.net \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=keescook@chromium.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=paulmck@kernel.org \
--cc=rostedt@goodmis.org \
--cc=viro@zeniv.linux.org.uk \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox