From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH v1 6/7] kunit: Add 'kunit_shutdown' option Date: Tue, 28 Jan 2020 22:33:06 -0800 Message-ID: <20200129063307.19CB4206F0@mail.kernel.org> References: <20200128072002.79250-1-brendanhiggins@google.com> <20200128072002.79250-7-brendanhiggins@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20200128072002.79250-7-brendanhiggins@google.com> Sender: linux-doc-owner@vger.kernel.org To: akpm@linux-foundation.org, alan.maguire@oracle.com, anton.ivanov@cambridgegreys.com, arnd@arndb.de, davidgow@google.com, frowand.list@gmail.com, jdike@addtoit.com, keescook@chromium.org, richard@nod.at, rppt@linux.ibm.com, skhan@linuxfoundation.org, yzaikin@google.com Cc: gregkh@linuxfoundation.org, logang@deltatee.com, mcgrof@kernel.org, knut.omang@oracle.com, linux-um@lists.infradead.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Brendan Higgins List-Id: linux-arch.vger.kernel.org Quoting Brendan Higgins (2020-01-27 23:20:01) > From: David Gow >=20 > Add a new kernel command-line option, 'kunit_shutdown', which allows the > user to specify that the kernel poweroff, halt, or reboot after > completing all KUnit tests; this is very handy for running KUnit tests > on UML or a VM so that the UML/VM process exits cleanly immediately > after running all tests without needing a special initramfs. >=20 > Signed-off-by: David Gow > Signed-off-by: Brendan Higgins > --- Two nitpicks below Reviewed-by: Stephen Boyd > diff --git a/lib/kunit/executor.c b/lib/kunit/executor.c > index 7fd16feff157e..d3ec1265a72fd 100644 > --- a/lib/kunit/executor.c > +++ b/lib/kunit/executor.c > @@ -1,6 +1,7 @@ > // SPDX-License-Identifier: GPL-2.0 > =20 > #include > +#include Should this include come before kunit/test.h? I imagine the order of includes would be linux, kunit, local? > =20 > /* > * These symbols point to the .kunit_test_suites section and are defined= in > @@ -11,6 +12,23 @@ extern struct kunit_suite * const * const __kunit_suit= es_end[]; > =20 > #if IS_BUILTIN(CONFIG_KUNIT) > =20 > +static char *kunit_shutdown; > +core_param(kunit_shutdown, kunit_shutdown, charp, 0644); > + > +static void kunit_handle_shutdown(void) > +{ > + if (!kunit_shutdown) > + return; > + > + if (!strcmp(kunit_shutdown, "poweroff")) { > + kernel_power_off(); > + } else if (!strcmp(kunit_shutdown, "halt")) { > + kernel_halt(); > + } else if (!strcmp(kunit_shutdown, "reboot")) { > + kernel_restart(NULL); > + } Kernel style would be to not have braces on single line if statements. > +} > + > static void kunit_print_tap_header(void) > { > struct kunit_suite * const * const *suites, * const *subsuite; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20200128072002.79250-7-brendanhiggins@google.com> References: <20200128072002.79250-1-brendanhiggins@google.com> <20200128072002.79250-7-brendanhiggins@google.com> From: Stephen Boyd Subject: Re: [PATCH v1 6/7] kunit: Add 'kunit_shutdown' option Date: Tue, 28 Jan 2020 22:33:06 -0800 Message-ID: <20200129063307.19CB4206F0@mail.kernel.org> Sender: linux-doc-owner@vger.kernel.org To: Brendan Higgins , akpm@linux-foundation.org, alan.maguire@oracle.com, anton.ivanov@cambridgegreys.com, arnd@arndb.de, davidgow@google.com, frowand.list@gmail.com, jdike@addtoit.com, keescook@chromium.org, richard@nod.at, rppt@linux.ibm.com, skhan@linuxfoundation.org, yzaikin@google.com Cc: gregkh@linuxfoundation.org, logang@deltatee.com, mcgrof@kernel.org, knut.omang@oracle.com, linux-um@lists.infradead.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org List-ID: Message-ID: <20200129063306.sxdrL47y_GB1-JoekTwFIMvBQiFrGz2KZ_qNm4Sr4L0@z> Quoting Brendan Higgins (2020-01-27 23:20:01) > From: David Gow >=20 > Add a new kernel command-line option, 'kunit_shutdown', which allows the > user to specify that the kernel poweroff, halt, or reboot after > completing all KUnit tests; this is very handy for running KUnit tests > on UML or a VM so that the UML/VM process exits cleanly immediately > after running all tests without needing a special initramfs. >=20 > Signed-off-by: David Gow > Signed-off-by: Brendan Higgins > --- Two nitpicks below Reviewed-by: Stephen Boyd > diff --git a/lib/kunit/executor.c b/lib/kunit/executor.c > index 7fd16feff157e..d3ec1265a72fd 100644 > --- a/lib/kunit/executor.c > +++ b/lib/kunit/executor.c > @@ -1,6 +1,7 @@ > // SPDX-License-Identifier: GPL-2.0 > =20 > #include > +#include Should this include come before kunit/test.h? I imagine the order of includes would be linux, kunit, local? > =20 > /* > * These symbols point to the .kunit_test_suites section and are defined= in > @@ -11,6 +12,23 @@ extern struct kunit_suite * const * const __kunit_suit= es_end[]; > =20 > #if IS_BUILTIN(CONFIG_KUNIT) > =20 > +static char *kunit_shutdown; > +core_param(kunit_shutdown, kunit_shutdown, charp, 0644); > + > +static void kunit_handle_shutdown(void) > +{ > + if (!kunit_shutdown) > + return; > + > + if (!strcmp(kunit_shutdown, "poweroff")) { > + kernel_power_off(); > + } else if (!strcmp(kunit_shutdown, "halt")) { > + kernel_halt(); > + } else if (!strcmp(kunit_shutdown, "reboot")) { > + kernel_restart(NULL); > + } Kernel style would be to not have braces on single line if statements. > +} > + > static void kunit_print_tap_header(void) > { > struct kunit_suite * const * const *suites, * const *subsuite;