From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH v3 16/22] locking/atomics, kcsan: Add KCSAN instrumentation Date: Wed, 19 Feb 2020 17:03:18 +0100 Message-ID: <20200219160318.GG18400@hirez.programming.kicks-ass.net> References: <20200219144724.800607165@infradead.org> <20200219150745.299217979@infradead.org> <20200219104626.633f0650@gandalf.local.home> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20200219104626.633f0650@gandalf.local.home> Sender: linux-kernel-owner@vger.kernel.org To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, mingo@kernel.org, joel@joelfernandes.org, gregkh@linuxfoundation.org, gustavo@embeddedor.com, tglx@linutronix.de, paulmck@kernel.org, josh@joshtriplett.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, luto@kernel.org, tony.luck@intel.com, frederic@kernel.org, dan.carpenter@oracle.com, mhiramat@kernel.org, Marco Elver , Mark Rutland List-Id: linux-arch.vger.kernel.org On Wed, Feb 19, 2020 at 10:46:26AM -0500, Steven Rostedt wrote: > On Wed, 19 Feb 2020 15:47:40 +0100 > Peter Zijlstra wrote: > > > From: Marco Elver > > > > This adds KCSAN instrumentation to atomic-instrumented.h. > > > > Signed-off-by: Marco Elver > > Signed-off-by: Paul E. McKenney > > [peterz: removed the actual kcsan hooks] > > Signed-off-by: Peter Zijlstra (Intel) > > Reviewed-by: Mark Rutland > > --- > > include/asm-generic/atomic-instrumented.h | 390 +++++++++++++++--------------- > > scripts/atomic/gen-atomic-instrumented.sh | 14 - > > 2 files changed, 212 insertions(+), 192 deletions(-) > > > > > Does this and the rest of the series depend on the previous patches in > the series? Or can this be a series on to itself (patches 16-22)? It can probably stand on its own, but it very much is related in so far that it's fallout from staring at all this nonsense. Without these the do_int3() can actually have accidental tracing before reaching it's nmi_enter(). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.133]:47548 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726651AbgBSQDp (ORCPT ); Wed, 19 Feb 2020 11:03:45 -0500 Date: Wed, 19 Feb 2020 17:03:18 +0100 From: Peter Zijlstra Subject: Re: [PATCH v3 16/22] locking/atomics, kcsan: Add KCSAN instrumentation Message-ID: <20200219160318.GG18400@hirez.programming.kicks-ass.net> References: <20200219144724.800607165@infradead.org> <20200219150745.299217979@infradead.org> <20200219104626.633f0650@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200219104626.633f0650@gandalf.local.home> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, mingo@kernel.org, joel@joelfernandes.org, gregkh@linuxfoundation.org, gustavo@embeddedor.com, tglx@linutronix.de, paulmck@kernel.org, josh@joshtriplett.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, luto@kernel.org, tony.luck@intel.com, frederic@kernel.org, dan.carpenter@oracle.com, mhiramat@kernel.org, Marco Elver , Mark Rutland Message-ID: <20200219160318.bTSKSH3iNlQ2IUEta6J0XmQaSUOdBtpDETq28ZK6r8U@z> On Wed, Feb 19, 2020 at 10:46:26AM -0500, Steven Rostedt wrote: > On Wed, 19 Feb 2020 15:47:40 +0100 > Peter Zijlstra wrote: > > > From: Marco Elver > > > > This adds KCSAN instrumentation to atomic-instrumented.h. > > > > Signed-off-by: Marco Elver > > Signed-off-by: Paul E. McKenney > > [peterz: removed the actual kcsan hooks] > > Signed-off-by: Peter Zijlstra (Intel) > > Reviewed-by: Mark Rutland > > --- > > include/asm-generic/atomic-instrumented.h | 390 +++++++++++++++--------------- > > scripts/atomic/gen-atomic-instrumented.sh | 14 - > > 2 files changed, 212 insertions(+), 192 deletions(-) > > > > > Does this and the rest of the series depend on the previous patches in > the series? Or can this be a series on to itself (patches 16-22)? It can probably stand on its own, but it very much is related in so far that it's fallout from staring at all this nonsense. Without these the do_int3() can actually have accidental tracing before reaching it's nmi_enter().