From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH v3 22/22] x86/int3: Ensure that poke_int3_handler() is not sanitized Date: Wed, 19 Feb 2020 17:51:27 +0100 Message-ID: <20200219165127.GF14946@hirez.programming.kicks-ass.net> References: <20200219144724.800607165@infradead.org> <20200219150745.651901321@infradead.org> <20200219163025.GH18400@hirez.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from merlin.infradead.org ([205.233.59.134]:35476 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726450AbgBSQv6 (ORCPT ); Wed, 19 Feb 2020 11:51:58 -0500 Content-Disposition: inline In-Reply-To: <20200219163025.GH18400@hirez.programming.kicks-ass.net> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Dmitry Vyukov Cc: LKML , linux-arch , Steven Rostedt , Ingo Molnar , Joel Fernandes , Greg Kroah-Hartman , "Gustavo A. R. Silva" , Thomas Gleixner , "Paul E. McKenney" , Josh Triplett , Mathieu Desnoyers , Lai Jiangshan , Andy Lutomirski , tony.luck@intel.com, Frederic Weisbecker , Dan Carpenter , Masami Hiramatsu , Andrey Ryabinin , kasan-dev On Wed, Feb 19, 2020 at 05:30:25PM +0100, Peter Zijlstra wrote: > > It's quite fragile. Tomorrow poke_int3_handler handler calls more of > > fewer functions, and both ways it's not detected by anything. > > Yes; not having tools for this is pretty annoying. In 0/n I asked Dan if > smatch could do at least the normal tracing stuff, the compiler > instrumentation bits are going to be far more difficult because smatch > doesn't work at that level :/ > > (I actually have ... and I stopped typing ... I think I mean to say something like: ... more changes to poke_int3_handler() pending, but they're all quite simple).