From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kees Cook Subject: Re: [PATCH v6 05/11] arm64: elf: Enable BTI at exec based on ELF program properties Date: Tue, 25 Feb 2020 21:47:32 -0800 Message-ID: <202002252146.7230873E@keescook> References: <20200212192906.53366-1-broonie@kernel.org> <20200212192906.53366-6-broonie@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pg1-f196.google.com ([209.85.215.196]:46862 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726112AbgBZFrf (ORCPT ); Wed, 26 Feb 2020 00:47:35 -0500 Received: by mail-pg1-f196.google.com with SMTP id y30so730953pga.13 for ; Tue, 25 Feb 2020 21:47:35 -0800 (PST) Content-Disposition: inline In-Reply-To: <20200212192906.53366-6-broonie@kernel.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Mark Brown Cc: Catalin Marinas , Will Deacon , Alexander Viro , Paul Elliott , Peter Zijlstra , Yu-cheng Yu , Amit Kachhap , Vincenzo Frascino , Marc Zyngier , Eugene Syromiatnikov , Szabolcs Nagy , "H . J . Lu " , Andrew Jones , Arnd Bergmann , Jann Horn , Richard Henderson , Kristina =?utf-8?Q?Mart=C5=A1enko?= , Thomas Gleixner , Florian Weimer , Sudak On Wed, Feb 12, 2020 at 07:29:00PM +0000, Mark Brown wrote: > diff --git a/include/linux/elf.h b/include/linux/elf.h > index 1b6e8955c597..5d5b0321da0b 100644 > --- a/include/linux/elf.h > +++ b/include/linux/elf.h > @@ -63,7 +63,11 @@ extern int elf_coredump_extra_notes_size(void); > extern int elf_coredump_extra_notes_write(struct coredump_params *cprm); > #endif > > -/* NT_GNU_PROPERTY_TYPE_0 header */ > +/* > + * NT_GNU_PROPERTY_TYPE_0 header: > + * Keep this internal until/unless there is an agreed UAPI definition. > + * pr_type values (GNU_PROPERTY_*) are public and defined in the UAPI header. > + */ > struct gnu_property { > u32 pr_type; > u32 pr_datasz; I think this hunk should be in patch 1. -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f196.google.com ([209.85.215.196]:46862 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726112AbgBZFrf (ORCPT ); Wed, 26 Feb 2020 00:47:35 -0500 Received: by mail-pg1-f196.google.com with SMTP id y30so730953pga.13 for ; Tue, 25 Feb 2020 21:47:35 -0800 (PST) Date: Tue, 25 Feb 2020 21:47:32 -0800 From: Kees Cook Subject: Re: [PATCH v6 05/11] arm64: elf: Enable BTI at exec based on ELF program properties Message-ID: <202002252146.7230873E@keescook> References: <20200212192906.53366-1-broonie@kernel.org> <20200212192906.53366-6-broonie@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200212192906.53366-6-broonie@kernel.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Mark Brown Cc: Catalin Marinas , Will Deacon , Alexander Viro , Paul Elliott , Peter Zijlstra , Yu-cheng Yu , Amit Kachhap , Vincenzo Frascino , Marc Zyngier , Eugene Syromiatnikov , Szabolcs Nagy , "H . J . Lu " , Andrew Jones , Arnd Bergmann , Jann Horn , Richard Henderson , Kristina =?utf-8?Q?Mart=C5=A1enko?= , Thomas Gleixner , Florian Weimer , Sudakshina Das , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, Dave Martin Message-ID: <20200226054732.c_UL4n6JJ6Fq-qEoT73sr0jIl_esx-Gp6nuDti4X5MQ@z> On Wed, Feb 12, 2020 at 07:29:00PM +0000, Mark Brown wrote: > diff --git a/include/linux/elf.h b/include/linux/elf.h > index 1b6e8955c597..5d5b0321da0b 100644 > --- a/include/linux/elf.h > +++ b/include/linux/elf.h > @@ -63,7 +63,11 @@ extern int elf_coredump_extra_notes_size(void); > extern int elf_coredump_extra_notes_write(struct coredump_params *cprm); > #endif > > -/* NT_GNU_PROPERTY_TYPE_0 header */ > +/* > + * NT_GNU_PROPERTY_TYPE_0 header: > + * Keep this internal until/unless there is an agreed UAPI definition. > + * pr_type values (GNU_PROPERTY_*) are public and defined in the UAPI header. > + */ > struct gnu_property { > u32 pr_type; > u32 pr_datasz; I think this hunk should be in patch 1. -- Kees Cook