From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: decruft the vmalloc API Date: Wed, 8 Apr 2020 18:07:43 +0200 Message-ID: <20200408160743.GA30662@lst.de> References: <20200408115926.1467567-1-hch@lst.de> <20200408160324.GS25745@shell.armlinux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from verein.lst.de ([213.95.11.211]:43068 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729684AbgDHQHs (ORCPT ); Wed, 8 Apr 2020 12:07:48 -0400 Content-Disposition: inline In-Reply-To: <20200408160324.GS25745@shell.armlinux.org.uk> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Russell King - ARM Linux admin Cc: Christoph Hellwig , Andrew Morton , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , x86@kernel.org, David Airlie , Daniel Vetter , Laura Abbott , Sumit Semwal , Sakari Ailus , Minchan Kim , Nitin Gupta , Christophe Leroy , linux-arch@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-s390@vger.kernel.org, Peter Zijlstra , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org On Wed, Apr 08, 2020 at 05:03:24PM +0100, Russell King - ARM Linux admin wrote: > I haven't read all your patches yet. > > Have you tested it on 32-bit ARM, where the module area is located > _below_ PAGE_OFFSET and outside of the vmalloc area? I have not tested it. However existing in-kernel users that use different areas (and we have quite a few of those) have not been changed at all. I think the arm32 module loader (like various other module loaders) falls into that category. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 8 Apr 2020 18:07:43 +0200 From: Christoph Hellwig Subject: Re: decruft the vmalloc API Message-ID: <20200408160743.GA30662@lst.de> References: <20200408115926.1467567-1-hch@lst.de> <20200408160324.GS25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200408160324.GS25745@shell.armlinux.org.uk> Sender: owner-linux-mm@kvack.org To: Russell King - ARM Linux admin Cc: Christoph Hellwig , Andrew Morton , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , x86@kernel.org, David Airlie , Daniel Vetter , Laura Abbott , Sumit Semwal , Sakari Ailus , Minchan Kim , Nitin Gupta , Christophe Leroy , linux-arch@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-s390@vger.kernel.org, Peter Zijlstra , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, bpf@vger.kernel.org, Robin Murphy , linux-arm-kernel@lists.infradead.org List-ID: Message-ID: <20200408160743.th-lvxsUhnqEX-waCz3n3ozoXH-RDAm3b77STnV0hjE@z> On Wed, Apr 08, 2020 at 05:03:24PM +0100, Russell King - ARM Linux admin wrote: > I haven't read all your patches yet. > > Have you tested it on 32-bit ARM, where the module area is located > _below_ PAGE_OFFSET and outside of the vmalloc area? I have not tested it. However existing in-kernel users that use different areas (and we have quite a few of those) have not been changed at all. I think the arm32 module loader (like various other module loaders) falls into that category.