From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH V4 6/6] x86/Hyper-V: Report crash data in die() when panic_on_oops is set Date: Fri, 10 Apr 2020 15:27:57 +0100 Message-ID: <20200410142757.comrxjvnf3akllmc@debian> References: <20200406155331.2105-1-Tianyu.Lan@microsoft.com> <20200406155331.2105-7-Tianyu.Lan@microsoft.com> <20200409164054.72es2ykmbef3jbui@debian> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Michael Kelley Cc: Wei Liu , "ltykernel@gmail.com" , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , Wei Liu , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "hpa@zytor.com" , "x86@kernel.org" , "arnd@arndb.de" , Tianyu Lan , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arch@vger.kernel.org" , vkuznets List-Id: linux-arch.vger.kernel.org On Thu, Apr 09, 2020 at 11:06:13PM +0000, Michael Kelley wrote: > From: Wei Liu Sent: Thursday, April 9, 2020 9:41 AM > > > > On Wed, Apr 08, 2020 at 08:19:47PM +0000, Michael Kelley wrote: > > > From: Tianyu Lan Sent: Monday, April 6, 2020 8:54 AM > > > > > > > > When oops happens with panic_on_oops unset, the oops > > > > thread is killed by die() and system continues to run. > > > > In such case, guest should not report crash register > > > > data to host since system still runs. Check panic_on_oops > > > > and return directly in hyperv_report_panic() when the function > > > > is called in the die() and panic_on_oops is unset. Fix it. > > > > > > > > Fixes: 7ed4325a44ea ("Drivers: hv: vmbus: Make panic reporting to be more useful") > > > > Signed-off-by: Tianyu Lan > > > > --- > > > > Change since v3: > > > > - Fix compile error. > > > > - Add fix commit in the change log > > > > --- > > > > arch/x86/hyperv/hv_init.c | 6 +++++- > > > > drivers/hv/vmbus_drv.c | 5 +++-- > > > > include/asm-generic/mshyperv.h | 2 +- > > > > 3 files changed, 9 insertions(+), 4 deletions(-) > > > > > > Reviewed-by: Michael Kelley > > > > It seems to me only the last patch is new, others are already in my > > tree, so I only apply the last one. > > > > Let me know if my understanding is wrong. > > > > Tianyu added "Fixes:" tags to some of the other patches in > the series. It appears the version you had already queued doesn't > have those "Fixes:" tags. Oh, I only read the subject lines and checked the Reviewed-by tags. I will queue the new series instead. Wei. > > Michael From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f65.google.com ([209.85.128.65]:52374 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726145AbgDJO2C (ORCPT ); Fri, 10 Apr 2020 10:28:02 -0400 Date: Fri, 10 Apr 2020 15:27:57 +0100 From: Wei Liu Subject: Re: [PATCH V4 6/6] x86/Hyper-V: Report crash data in die() when panic_on_oops is set Message-ID: <20200410142757.comrxjvnf3akllmc@debian> References: <20200406155331.2105-1-Tianyu.Lan@microsoft.com> <20200406155331.2105-7-Tianyu.Lan@microsoft.com> <20200409164054.72es2ykmbef3jbui@debian> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Michael Kelley Cc: Wei Liu , "ltykernel@gmail.com" , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , Wei Liu , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "hpa@zytor.com" , "x86@kernel.org" , "arnd@arndb.de" , Tianyu Lan , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arch@vger.kernel.org" , vkuznets Message-ID: <20200410142757.B2XfxQ49Uq4fN4mG-GxFvMwHdHKQYWYetJStUc8etII@z> On Thu, Apr 09, 2020 at 11:06:13PM +0000, Michael Kelley wrote: > From: Wei Liu Sent: Thursday, April 9, 2020 9:41 AM > > > > On Wed, Apr 08, 2020 at 08:19:47PM +0000, Michael Kelley wrote: > > > From: Tianyu Lan Sent: Monday, April 6, 2020 8:54 AM > > > > > > > > When oops happens with panic_on_oops unset, the oops > > > > thread is killed by die() and system continues to run. > > > > In such case, guest should not report crash register > > > > data to host since system still runs. Check panic_on_oops > > > > and return directly in hyperv_report_panic() when the function > > > > is called in the die() and panic_on_oops is unset. Fix it. > > > > > > > > Fixes: 7ed4325a44ea ("Drivers: hv: vmbus: Make panic reporting to be more useful") > > > > Signed-off-by: Tianyu Lan > > > > --- > > > > Change since v3: > > > > - Fix compile error. > > > > - Add fix commit in the change log > > > > --- > > > > arch/x86/hyperv/hv_init.c | 6 +++++- > > > > drivers/hv/vmbus_drv.c | 5 +++-- > > > > include/asm-generic/mshyperv.h | 2 +- > > > > 3 files changed, 9 insertions(+), 4 deletions(-) > > > > > > Reviewed-by: Michael Kelley > > > > It seems to me only the last patch is new, others are already in my > > tree, so I only apply the last one. > > > > Let me know if my understanding is wrong. > > > > Tianyu added "Fixes:" tags to some of the other patches in > the series. It appears the version you had already queued doesn't > have those "Fixes:" tags. Oh, I only read the subject lines and checked the Reviewed-by tags. I will queue the new series instead. Wei. > > Michael