From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: Implement close-on-fork Date: Wed, 22 Apr 2020 16:01:07 +0100 Message-ID: <20200422150107.GK23230@ZenIV.linux.org.uk> References: <20200420071548.62112-1-nate.karstens@garmin.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20200420071548.62112-1-nate.karstens@garmin.com> Sender: linux-kernel-owner@vger.kernel.org To: Nate Karstens Cc: Jeff Layton , "J. Bruce Fields" , Arnd Bergmann , Richard Henderson , Ivan Kokshaysky , Matt Turner , "James E.J. Bottomley" , Helge Deller , "David S. Miller" , Jakub Kicinski , linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-alpha@vger.kernel.org, linux-parisc@vger.kernel.org, sparclinux@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Changli Gao List-Id: linux-arch.vger.kernel.org On Mon, Apr 20, 2020 at 02:15:44AM -0500, Nate Karstens wrote: > Series of 4 patches to implement close-on-fork. Tests have been > published to https://github.com/nkarstens/ltp/tree/close-on-fork. > > close-on-fork addresses race conditions in system(), which > (depending on the implementation) is non-atomic in that it > first calls a fork() and then an exec(). > > This functionality was approved by the Austin Common Standards > Revision Group for inclusion in the next revision of the POSIX > standard (see issue 1318 in the Austin Group Defect Tracker). What exactly the reasons are and why would we want to implement that? Pardon me, but going by the previous history, "The Austin Group Says It's Good" is more of a source of concern regarding the merits, general sanity and, most of all, good taste of a proposal. I'm not saying that it's automatically bad, but you'll have to go much deeper into the rationale of that change before your proposal is taken seriously. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725934AbgDVPBo (ORCPT ); Wed, 22 Apr 2020 11:01:44 -0400 Date: Wed, 22 Apr 2020 16:01:07 +0100 From: Al Viro Subject: Re: Implement close-on-fork Message-ID: <20200422150107.GK23230@ZenIV.linux.org.uk> References: <20200420071548.62112-1-nate.karstens@garmin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200420071548.62112-1-nate.karstens@garmin.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Nate Karstens Cc: Jeff Layton , "J. Bruce Fields" , Arnd Bergmann , Richard Henderson , Ivan Kokshaysky , Matt Turner , "James E.J. Bottomley" , Helge Deller , "David S. Miller" , Jakub Kicinski , linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-alpha@vger.kernel.org, linux-parisc@vger.kernel.org, sparclinux@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Changli Gao Message-ID: <20200422150107.COX9VKp2BwGhjmjZdQo_ifSgW7MuyvPoB0fG3LswdqE@z> On Mon, Apr 20, 2020 at 02:15:44AM -0500, Nate Karstens wrote: > Series of 4 patches to implement close-on-fork. Tests have been > published to https://github.com/nkarstens/ltp/tree/close-on-fork. > > close-on-fork addresses race conditions in system(), which > (depending on the implementation) is non-atomic in that it > first calls a fork() and then an exec(). > > This functionality was approved by the Austin Common Standards > Revision Group for inclusion in the next revision of the POSIX > standard (see issue 1318 in the Austin Group Defect Tracker). What exactly the reasons are and why would we want to implement that? Pardon me, but going by the previous history, "The Austin Group Says It's Good" is more of a source of concern regarding the merits, general sanity and, most of all, good taste of a proposal. I'm not saying that it's automatically bad, but you'll have to go much deeper into the rationale of that change before your proposal is taken seriously.