From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyril Hrubis Subject: Re: [fs] ce436509a8: ltp.openat203.fail Date: Tue, 28 Apr 2020 17:30:22 +0200 Message-ID: <20200428153022.GC4244@yuki.lan> References: <20200427135210.GB5770@shao2-debian> <20200427142733.GD7661@rei> <20200428005126.6wncibudt6ohghvc@yavin.dot.cyphar.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20200428005126.6wncibudt6ohghvc-DDZ4AMo6ZIKk7xURhxcYY1aTQe2KTcn/@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ltp-bounces+glt-ltp-list=m.gmane-mx.org-cunTk1MwBs91InPhgRC9rw@public.gmane.org Sender: "ltp" To: Aleksa Sarai Cc: linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jens Axboe , Arnd Bergmann , kernel test robot , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Josh Triplett , lkp-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, Alexander Viro , linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, io-uring-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ltp-cunTk1MwBs91InPhgRC9rw@public.gmane.org List-Id: linux-arch.vger.kernel.org Hi! > > > commit: ce436509a8e109330c56bb4d8ec87d258788f5f4 ("[PATCH v4 2/3] fs: openat2: Extend open_how to allow userspace-selected fds") > > > url: https://github.com/0day-ci/linux/commits/Josh-Triplett/Support-userspace-selected-fds/20200414-102939 > > > base: https://git.kernel.org/cgit/linux/kernel/git/shuah/linux-kselftest.git next > > > > This commit adds fd parameter to the how structure where LTP test was > > previously passing garbage, which obviously causes the difference in > > errno. > > > > This could be safely ignored for now, if the patch gets merged the test > > needs to be updated. > > It wouldn't be a bad idea to switch the test to figure out the ksize of > the struct, so that you only add bad padding after that. But then again, > this would be a bit ugly -- having CHECK_FIELDS would make this simpler. Any pointers how can be the size figured out without relying on the E2BIG we are testing for? Does the kernel export it somewhere? -- Cyril Hrubis chrubis-AlSwsSmVLrQ@public.gmane.org -- Mailing list info: https://lists.linux.it/listinfo/ltp From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:45866 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727931AbgD1PaG (ORCPT ); Tue, 28 Apr 2020 11:30:06 -0400 Date: Tue, 28 Apr 2020 17:30:22 +0200 From: Cyril Hrubis Subject: Re: [LTP] [fs] ce436509a8: ltp.openat203.fail Message-ID: <20200428153022.GC4244@yuki.lan> References: <20200427135210.GB5770@shao2-debian> <20200427142733.GD7661@rei> <20200428005126.6wncibudt6ohghvc@yavin.dot.cyphar.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200428005126.6wncibudt6ohghvc@yavin.dot.cyphar.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Aleksa Sarai Cc: kernel test robot , Josh Triplett , linux-arch@vger.kernel.org, Jens Axboe , Arnd Bergmann , linux-kernel@vger.kernel.org, lkp@lists.01.org, Alexander Viro , linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, ltp@lists.linux.it Message-ID: <20200428153022.2IQV2gg-rHvJpLJH9B-4TvW7tC8pmRiPZMDRrdkAUnk@z> Hi! > > > commit: ce436509a8e109330c56bb4d8ec87d258788f5f4 ("[PATCH v4 2/3] fs: openat2: Extend open_how to allow userspace-selected fds") > > > url: https://github.com/0day-ci/linux/commits/Josh-Triplett/Support-userspace-selected-fds/20200414-102939 > > > base: https://git.kernel.org/cgit/linux/kernel/git/shuah/linux-kselftest.git next > > > > This commit adds fd parameter to the how structure where LTP test was > > previously passing garbage, which obviously causes the difference in > > errno. > > > > This could be safely ignored for now, if the patch gets merged the test > > needs to be updated. > > It wouldn't be a bad idea to switch the test to figure out the ksize of > the struct, so that you only add bad padding after that. But then again, > this would be a bit ugly -- having CHECK_FIELDS would make this simpler. Any pointers how can be the size figured out without relying on the E2BIG we are testing for? Does the kernel export it somewhere? -- Cyril Hrubis chrubis@suse.cz