From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH v3 2/7] mm/vmalloc: Track which page-table levels were modified Date: Sat, 16 May 2020 14:56:41 +0200 Message-ID: <20200516125641.GK8135@suse.de> References: <20200515140023.25469-1-joro@8bytes.org> <20200515140023.25469-3-joro@8bytes.org> <20200515130142.4ca90ee590e9d8ab88497676@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20200515130142.4ca90ee590e9d8ab88497676@linux-foundation.org> Sender: linux-acpi-owner@vger.kernel.org To: Andrew Morton Cc: Joerg Roedel , x86@kernel.org, hpa@zytor.com, Dave Hansen , Andy Lutomirski , Peter Zijlstra , rjw@rjwysocki.net, Arnd Bergmann , Steven Rostedt , Vlastimil Babka , Michal Hocko , Matthew Wilcox , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig List-Id: linux-arch.vger.kernel.org Hi Andrew, On Fri, May 15, 2020 at 01:01:42PM -0700, Andrew Morton wrote: > On Fri, 15 May 2020 16:00:18 +0200 Joerg Roedel wrote: > Lots of collisions here with Christoph's "decruft the vmalloc API" series > (http://lkml.kernel.org/r/20200414131348.444715-1-hch@lst.de). > > I attempted to fix things up. > > unmap_kernel_range_noflush() needed to be redone. > > map_kernel_range_noflush() might need the arch_sync_kernel_mappings() call? Yes, map_kernel_range_noflush() needs the arch_sync_kernel_mappings() call as well. Regards, Joerg From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:60782 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726295AbgEPM4p (ORCPT ); Sat, 16 May 2020 08:56:45 -0400 Date: Sat, 16 May 2020 14:56:41 +0200 From: Joerg Roedel Subject: Re: [PATCH v3 2/7] mm/vmalloc: Track which page-table levels were modified Message-ID: <20200516125641.GK8135@suse.de> References: <20200515140023.25469-1-joro@8bytes.org> <20200515140023.25469-3-joro@8bytes.org> <20200515130142.4ca90ee590e9d8ab88497676@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200515130142.4ca90ee590e9d8ab88497676@linux-foundation.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Andrew Morton Cc: Joerg Roedel , x86@kernel.org, hpa@zytor.com, Dave Hansen , Andy Lutomirski , Peter Zijlstra , rjw@rjwysocki.net, Arnd Bergmann , Steven Rostedt , Vlastimil Babka , Michal Hocko , Matthew Wilcox , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig Message-ID: <20200516125641.VLhAPe-tDZF7sMzCfdNxoXmH6WolyozHbKtZNn3J8aI@z> Hi Andrew, On Fri, May 15, 2020 at 01:01:42PM -0700, Andrew Morton wrote: > On Fri, 15 May 2020 16:00:18 +0200 Joerg Roedel wrote: > Lots of collisions here with Christoph's "decruft the vmalloc API" series > (http://lkml.kernel.org/r/20200414131348.444715-1-hch@lst.de). > > I attempted to fix things up. > > unmap_kernel_range_noflush() needed to be redone. > > map_kernel_range_noflush() might need the arch_sync_kernel_mappings() call? Yes, map_kernel_range_noflush() needs the arch_sync_kernel_mappings() call as well. Regards, Joerg