From mboxrd@z Thu Jan 1 00:00:00 1970 From: Catalin Marinas Subject: Re: [PATCH v2 5/6] mm: tlb: Provide flush_*_tlb_range wrappers Date: Fri, 22 May 2020 16:42:55 +0100 Message-ID: <20200522154254.GD26492@gaia> References: <20200423135656.2712-1-yezhenyu2@huawei.com> <20200423135656.2712-6-yezhenyu2@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20200423135656.2712-6-yezhenyu2@huawei.com> Sender: linux-kernel-owner@vger.kernel.org To: Zhenyu Ye Cc: peterz@infradead.org, mark.rutland@arm.com, will@kernel.org, aneesh.kumar@linux.ibm.com, akpm@linux-foundation.org, npiggin@gmail.com, arnd@arndb.de, rostedt@goodmis.org, maz@kernel.org, suzuki.poulose@arm.com, tglx@linutronix.de, yuzhao@google.com, Dave.Martin@arm.com, steven.price@arm.com, broonie@kernel.org, guohanjun@huawei.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arm@kernel.org, xiexiangyou@huawei.com, prime.zeng@hisilicon.com, zhangshaokun@hisilicon.com, kuhn.chenqun@huawei.com List-Id: linux-arch.vger.kernel.org On Thu, Apr 23, 2020 at 09:56:55PM +0800, Zhenyu Ye wrote: > diff --git a/mm/pgtable-generic.c b/mm/pgtable-generic.c > index 3d7c01e76efc..3eff199d3507 100644 > --- a/mm/pgtable-generic.c > +++ b/mm/pgtable-generic.c > @@ -101,6 +101,28 @@ pte_t ptep_clear_flush(struct vm_area_struct *vma, unsigned long address, > > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > > +#ifndef __HAVE_ARCH_FLUSH_PMD_TLB_RANGE > + > +#define FLUSH_Pxx_TLB_RANGE(_pxx) \ > +void flush_##_pxx##_tlb_range(struct vm_area_struct *vma, \ > + unsigned long addr, unsigned long end) \ > +{ \ > + struct mmu_gather tlb; \ > + \ > + tlb_gather_mmu(&tlb, vma->vm_mm, addr, end); \ > + tlb_start_vma(&tlb, vma); \ > + tlb_flush_##_pxx##_range(&tlb, addr, end - addr); \ > + tlb_end_vma(&tlb, vma); \ > + tlb_finish_mmu(&tlb, addr, end); \ > +} I may have confused myself (flush_p??_tlb_* vs. tlb_flush_p??_*) but do actually need this whole tlb_gather thing here? IIUC (by grep'ing), flush_p?d_tlb_range() is only called on huge pages, so we should know the level already. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 22 May 2020 16:42:55 +0100 From: Catalin Marinas Subject: Re: [PATCH v2 5/6] mm: tlb: Provide flush_*_tlb_range wrappers Message-ID: <20200522154254.GD26492@gaia> References: <20200423135656.2712-1-yezhenyu2@huawei.com> <20200423135656.2712-6-yezhenyu2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200423135656.2712-6-yezhenyu2@huawei.com> Sender: owner-linux-mm@kvack.org To: Zhenyu Ye Cc: peterz@infradead.org, mark.rutland@arm.com, will@kernel.org, aneesh.kumar@linux.ibm.com, akpm@linux-foundation.org, npiggin@gmail.com, arnd@arndb.de, rostedt@goodmis.org, maz@kernel.org, suzuki.poulose@arm.com, tglx@linutronix.de, yuzhao@google.com, Dave.Martin@arm.com, steven.price@arm.com, broonie@kernel.org, guohanjun@huawei.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arm@kernel.org, xiexiangyou@huawei.com, prime.zeng@hisilicon.com, zhangshaokun@hisilicon.com, kuhn.chenqun@huawei.com List-ID: Message-ID: <20200522154255.r_Qc7N4hinr5seSEwjT461kvBie4ua1MoAyFwhwl6hw@z> On Thu, Apr 23, 2020 at 09:56:55PM +0800, Zhenyu Ye wrote: > diff --git a/mm/pgtable-generic.c b/mm/pgtable-generic.c > index 3d7c01e76efc..3eff199d3507 100644 > --- a/mm/pgtable-generic.c > +++ b/mm/pgtable-generic.c > @@ -101,6 +101,28 @@ pte_t ptep_clear_flush(struct vm_area_struct *vma, unsigned long address, > > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > > +#ifndef __HAVE_ARCH_FLUSH_PMD_TLB_RANGE > + > +#define FLUSH_Pxx_TLB_RANGE(_pxx) \ > +void flush_##_pxx##_tlb_range(struct vm_area_struct *vma, \ > + unsigned long addr, unsigned long end) \ > +{ \ > + struct mmu_gather tlb; \ > + \ > + tlb_gather_mmu(&tlb, vma->vm_mm, addr, end); \ > + tlb_start_vma(&tlb, vma); \ > + tlb_flush_##_pxx##_range(&tlb, addr, end - addr); \ > + tlb_end_vma(&tlb, vma); \ > + tlb_finish_mmu(&tlb, addr, end); \ > +} I may have confused myself (flush_p??_tlb_* vs. tlb_flush_p??_*) but do actually need this whole tlb_gather thing here? IIUC (by grep'ing), flush_p?d_tlb_range() is only called on huge pages, so we should know the level already. -- Catalin