Generic Linux architectural discussions
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux-kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-arch@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [RFC PATCH 1/2] Explicitly include linux/major.h where it is needed
Date: Wed, 17 Jun 2020 07:58:43 +0200	[thread overview]
Message-ID: <20200617055843.GB25631@kroah.com> (raw)
In-Reply-To: <20200617092747.0cadb2de@canb.auug.org.au>

On Wed, Jun 17, 2020 at 09:27:47AM +1000, Stephen Rothwell wrote:
> This is in preparation for removing the include of major.h where it is
> not needed.
> 
> These files were found using
> 
> 	grep -E -L '[<"](uapi/)?linux/major\.h' $(git grep -l -w -f /tmp/xx)
> 
> where /tmp/xx contains all the symbols defined in major.h.  There were
> a couple of files in that list that did not need the include since the
> references are in comments.
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

Any reason this had an RFC, but patch 2/2 did not?

They look good to me, I will be glad to take these, but do you still
want reviews from others for this?  It seems simple enough to me...

thanks,

greg k-h

  reply	other threads:[~2020-06-17  5:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-16 23:26 [RFC Patch 0/2] fix up includes of linux/major.h Stephen Rothwell
2020-06-16 23:26 ` Stephen Rothwell
2020-06-16 23:27 ` [RFC PATCH 1/2] Explicitly include linux/major.h where it is needed Stephen Rothwell
2020-06-17  5:58   ` Greg KH [this message]
2020-06-17  6:18     ` Stephen Rothwell
2020-06-17  6:18       ` Stephen Rothwell
2020-06-22  4:25       ` Stephen Rothwell
2020-06-22  7:22         ` Arnd Bergmann
2020-06-29 23:12     ` Stephen Rothwell
2020-06-30  8:45       ` Greg KH
2020-06-16 23:30 ` [PATCH 2/2] Remove the include of linux/major.h from files that do not need it Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200617055843.GB25631@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox