From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fangrui Song Subject: Re: [PATCH v2 3/3] x86/boot: Warn on orphan section placement Date: Mon, 22 Jun 2020 15:49:28 -0700 Message-ID: <20200622224928.o2a7jkq33guxfci4@google.com> References: <20200622205341.2987797-1-keescook@chromium.org> <20200622205341.2987797-4-keescook@chromium.org> <20200622220628.t5fklwmbtqoird5f@google.com> <202006221543.EA2FCFA2FF@keescook> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Return-path: Content-Disposition: inline In-Reply-To: <202006221543.EA2FCFA2FF@keescook> Sender: linux-kernel-owner@vger.kernel.org To: Kees Cook Cc: Borislav Petkov , Thomas Gleixner , Ingo Molnar , x86@kernel.org, Arnd Bergmann , Nick Desaulniers , Nathan Chancellor , clang-built-linux@googlegroups.com, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-arch.vger.kernel.org On 2020-06-22, Kees Cook wrote: >On Mon, Jun 22, 2020 at 03:06:28PM -0700, Fangrui Song wrote: >> LLD may report warnings for 3 synthetic sections if they are orphans: >> >> ld.lld: warning: :(.symtab) is being placed in '.symtab' >> ld.lld: warning: :(.shstrtab) is being placed in '.shstrtab' >> ld.lld: warning: :(.strtab) is being placed in '.strtab' >> >> Are they described? > >Perhaps: > >diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h >index db600ef218d7..57e9c142e401 100644 >--- a/include/asm-generic/vmlinux.lds.h >+++ b/include/asm-generic/vmlinux.lds.h >@@ -792,6 +792,9 @@ > .stab.exclstr 0 : { *(.stab.exclstr) } \ > .stab.index 0 : { *(.stab.index) } \ > .stab.indexstr 0 : { *(.stab.indexstr) } \ >+ .symtab 0 : { *(.symtab) } \ >+ .strtab 0 : { *(.strtab) } \ >+ .shstrtab 0 : { *(.shstrtab) } \ > .comment 0 : { *(.comment) } > > #ifdef CONFIG_GENERIC_BUG This LGTM. Nit: .comment before .symtab is a more common order. Reviewed-by: Fangrui Song From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730943AbgFVWtg (ORCPT ); Mon, 22 Jun 2020 18:49:36 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2888BC061573 for ; Mon, 22 Jun 2020 15:49:32 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id y18so8234516plr.4 for ; Mon, 22 Jun 2020 15:49:32 -0700 (PDT) Date: Mon, 22 Jun 2020 15:49:28 -0700 From: Fangrui Song Subject: Re: [PATCH v2 3/3] x86/boot: Warn on orphan section placement Message-ID: <20200622224928.o2a7jkq33guxfci4@google.com> References: <20200622205341.2987797-1-keescook@chromium.org> <20200622205341.2987797-4-keescook@chromium.org> <20200622220628.t5fklwmbtqoird5f@google.com> <202006221543.EA2FCFA2FF@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <202006221543.EA2FCFA2FF@keescook> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Kees Cook Cc: Borislav Petkov , Thomas Gleixner , Ingo Molnar , x86@kernel.org, Arnd Bergmann , Nick Desaulniers , Nathan Chancellor , clang-built-linux@googlegroups.com, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20200622224928.ZgtS2x_EICFmCiewM5jyfXiefkuBgQhVgrwn4N5k6u4@z> On 2020-06-22, Kees Cook wrote: >On Mon, Jun 22, 2020 at 03:06:28PM -0700, Fangrui Song wrote: >> LLD may report warnings for 3 synthetic sections if they are orphans: >> >> ld.lld: warning: :(.symtab) is being placed in '.symtab' >> ld.lld: warning: :(.shstrtab) is being placed in '.shstrtab' >> ld.lld: warning: :(.strtab) is being placed in '.strtab' >> >> Are they described? > >Perhaps: > >diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h >index db600ef218d7..57e9c142e401 100644 >--- a/include/asm-generic/vmlinux.lds.h >+++ b/include/asm-generic/vmlinux.lds.h >@@ -792,6 +792,9 @@ > .stab.exclstr 0 : { *(.stab.exclstr) } \ > .stab.index 0 : { *(.stab.index) } \ > .stab.indexstr 0 : { *(.stab.indexstr) } \ >+ .symtab 0 : { *(.symtab) } \ >+ .strtab 0 : { *(.strtab) } \ >+ .shstrtab 0 : { *(.shstrtab) } \ > .comment 0 : { *(.comment) } > > #ifdef CONFIG_GENERIC_BUG This LGTM. Nit: .comment before .symtab is a more common order. Reviewed-by: Fangrui Song