From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arvind Sankar Subject: Re: [PATCH v3 2/9] vmlinux.lds.h: Add .symtab, .strtab, and .shstrtab to STABS_DEBUG Date: Wed, 24 Jun 2020 11:39:30 -0400 Message-ID: <20200624153930.GA1337895@rani.riverdale.lan> References: <20200624014940.1204448-1-keescook@chromium.org> <20200624014940.1204448-3-keescook@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404146AbgFXPje (ORCPT ); Wed, 24 Jun 2020 11:39:34 -0400 Content-Disposition: inline In-Reply-To: <20200624014940.1204448-3-keescook@chromium.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Kees Cook Cc: Will Deacon , Fangrui Song , Catalin Marinas , Mark Rutland , Ard Biesheuvel , Peter Collingbourne , James Morse , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Russell King , Masahiro Yamada , Arvind Sankar , Nick Desaulniers , Nathan Chancellor , Arnd Bergmann , x86@kernel.org, clang-built-linux@googlegroups.com, linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel On Tue, Jun 23, 2020 at 06:49:33PM -0700, Kees Cook wrote: > When linking vmlinux with LLD, the synthetic sections .symtab, .strtab, > and .shstrtab are listed as orphaned. Add them to the STABS_DEBUG section > so there will be no warnings when --orphan-handling=warn is used more > widely. (They are added above comment as it is the more common Nit 1: is "after .comment" better than "above comment"? It's above in the sense of higher file offset, but it's below in readelf output. Nit 2: These aren't actually debugging sections, no? Is it better to add a new macro for it, and is there any plan to stop LLD from warning about them? > order[1].) > > ld.lld: warning: :(.symtab) is being placed in '.symtab' > ld.lld: warning: :(.shstrtab) is being placed in '.shstrtab' > ld.lld: warning: :(.strtab) is being placed in '.strtab' > > [1] https://lore.kernel.org/lkml/20200622224928.o2a7jkq33guxfci4@google.com/ > > Reported-by: Fangrui Song > Reviewed-by: Fangrui Song > Signed-off-by: Kees Cook > --- > include/asm-generic/vmlinux.lds.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h > index 1248a206be8d..8e71757f485b 100644 > --- a/include/asm-generic/vmlinux.lds.h > +++ b/include/asm-generic/vmlinux.lds.h > @@ -792,7 +792,10 @@ > .stab.exclstr 0 : { *(.stab.exclstr) } \ > .stab.index 0 : { *(.stab.index) } \ > .stab.indexstr 0 : { *(.stab.indexstr) } \ > - .comment 0 : { *(.comment) } > + .comment 0 : { *(.comment) } \ > + .symtab 0 : { *(.symtab) } \ > + .strtab 0 : { *(.strtab) } \ > + .shstrtab 0 : { *(.shstrtab) } > > #ifdef CONFIG_GENERIC_BUG > #define BUG_TABLE \ > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404146AbgFXPje (ORCPT ); Wed, 24 Jun 2020 11:39:34 -0400 From: Arvind Sankar Date: Wed, 24 Jun 2020 11:39:30 -0400 Subject: Re: [PATCH v3 2/9] vmlinux.lds.h: Add .symtab, .strtab, and .shstrtab to STABS_DEBUG Message-ID: <20200624153930.GA1337895@rani.riverdale.lan> References: <20200624014940.1204448-1-keescook@chromium.org> <20200624014940.1204448-3-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200624014940.1204448-3-keescook@chromium.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Kees Cook Cc: Will Deacon , Fangrui Song , Catalin Marinas , Mark Rutland , Ard Biesheuvel , Peter Collingbourne , James Morse , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Russell King , Masahiro Yamada , Arvind Sankar , Nick Desaulniers , Nathan Chancellor , Arnd Bergmann , x86@kernel.org, clang-built-linux@googlegroups.com, linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Message-ID: <20200624153930.dJAHUOfWXq5ysqH8byz0v38ABUyAZlk_FfW-fiNuXJM@z> On Tue, Jun 23, 2020 at 06:49:33PM -0700, Kees Cook wrote: > When linking vmlinux with LLD, the synthetic sections .symtab, .strtab, > and .shstrtab are listed as orphaned. Add them to the STABS_DEBUG section > so there will be no warnings when --orphan-handling=warn is used more > widely. (They are added above comment as it is the more common Nit 1: is "after .comment" better than "above comment"? It's above in the sense of higher file offset, but it's below in readelf output. Nit 2: These aren't actually debugging sections, no? Is it better to add a new macro for it, and is there any plan to stop LLD from warning about them? > order[1].) > > ld.lld: warning: :(.symtab) is being placed in '.symtab' > ld.lld: warning: :(.shstrtab) is being placed in '.shstrtab' > ld.lld: warning: :(.strtab) is being placed in '.strtab' > > [1] https://lore.kernel.org/lkml/20200622224928.o2a7jkq33guxfci4@google.com/ > > Reported-by: Fangrui Song > Reviewed-by: Fangrui Song > Signed-off-by: Kees Cook > --- > include/asm-generic/vmlinux.lds.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h > index 1248a206be8d..8e71757f485b 100644 > --- a/include/asm-generic/vmlinux.lds.h > +++ b/include/asm-generic/vmlinux.lds.h > @@ -792,7 +792,10 @@ > .stab.exclstr 0 : { *(.stab.exclstr) } \ > .stab.index 0 : { *(.stab.index) } \ > .stab.indexstr 0 : { *(.stab.indexstr) } \ > - .comment 0 : { *(.comment) } > + .comment 0 : { *(.comment) } \ > + .symtab 0 : { *(.symtab) } \ > + .strtab 0 : { *(.strtab) } \ > + .shstrtab 0 : { *(.shstrtab) } > > #ifdef CONFIG_GENERIC_BUG > #define BUG_TABLE \ > -- > 2.25.1 >