From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH 2/2] locking/pvqspinlock: Optionally store lock holder cpu into lock Date: Mon, 13 Jul 2020 11:21:35 +0200 Message-ID: <20200713092135.GC10769@hirez.programming.kicks-ass.net> References: <20200711182128.29130-1-longman@redhat.com> <20200711182128.29130-3-longman@redhat.com> <20200712173452.GB10769@hirez.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Waiman Long Cc: Ingo Molnar , Will Deacon , Thomas Gleixner , Borislav Petkov , Arnd Bergmann , linux-kernel@vger.kernel.org, x86@kernel.org, linux-arch@vger.kernel.org, Nicholas Piggin , Davidlohr Bueso List-Id: linux-arch.vger.kernel.org On Sun, Jul 12, 2020 at 07:05:36PM -0400, Waiman Long wrote: > On 7/12/20 1:34 PM, Peter Zijlstra wrote: > > And this kills it,.. if it doesn't make unconditional sense, we're not > > going to do this. It's just too ugly. > > > You mean it has to be unconditional, no option config if we want to do it. > Right? Yeah, the very last thing we need in this code is spurious complexity. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726360AbgGMJV4 (ORCPT ); Mon, 13 Jul 2020 05:21:56 -0400 Date: Mon, 13 Jul 2020 11:21:35 +0200 From: Peter Zijlstra Subject: Re: [PATCH 2/2] locking/pvqspinlock: Optionally store lock holder cpu into lock Message-ID: <20200713092135.GC10769@hirez.programming.kicks-ass.net> References: <20200711182128.29130-1-longman@redhat.com> <20200711182128.29130-3-longman@redhat.com> <20200712173452.GB10769@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Waiman Long Cc: Ingo Molnar , Will Deacon , Thomas Gleixner , Borislav Petkov , Arnd Bergmann , linux-kernel@vger.kernel.org, x86@kernel.org, linux-arch@vger.kernel.org, Nicholas Piggin , Davidlohr Bueso Message-ID: <20200713092135.Iudf-niKhT3vWjNgJvMj_6fdJfBb6Y46d0G15WY-uBM@z> On Sun, Jul 12, 2020 at 07:05:36PM -0400, Waiman Long wrote: > On 7/12/20 1:34 PM, Peter Zijlstra wrote: > > And this kills it,.. if it doesn't make unconditional sense, we're not > > going to do this. It's just too ugly. > > > You mean it has to be unconditional, no option config if we want to do it. > Right? Yeah, the very last thing we need in this code is spurious complexity.