From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 1/6] syscalls: use uaccess_kernel in addr_limit_user_check Date: Sat, 18 Jul 2020 11:48:46 +0200 Message-ID: <20200718094846.GA8593@lst.de> References: <20200714105505.935079-1-hch@lst.de> <20200714105505.935079-2-hch@lst.de> <20200718013849.GA157764@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from verein.lst.de ([213.95.11.211]:41559 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726262AbgGRJsu (ORCPT ); Sat, 18 Jul 2020 05:48:50 -0400 Content-Disposition: inline In-Reply-To: <20200718013849.GA157764@roeck-us.net> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Guenter Roeck Cc: Christoph Hellwig , Nick Hu , Greentime Hu , Vincent Chen , Paul Walmsley , Palmer Dabbelt , Andrew Morton , Linus Torvalds , linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org On Fri, Jul 17, 2020 at 06:38:50PM -0700, Guenter Roeck wrote: > Hi, > > On Tue, Jul 14, 2020 at 12:55:00PM +0200, Christoph Hellwig wrote: > > Use the uaccess_kernel helper instead of duplicating it. > > > > Signed-off-by: Christoph Hellwig > > This patch causes a severe hiccup with my mps2-an385 boot test. I guess that is a nommu config? Can you try this patch? diff --git a/arch/arm/include/asm/uaccess.h b/arch/arm/include/asm/uaccess.h index b19c9bec1f7a63..cc7daf374a6eb6 100644 --- a/arch/arm/include/asm/uaccess.h +++ b/arch/arm/include/asm/uaccess.h @@ -263,7 +263,7 @@ extern int __put_user_8(void *, unsigned long long); */ #define USER_DS KERNEL_DS -#define uaccess_kernel() (true) +#define uaccess_kernel() (false) #define __addr_ok(addr) ((void)(addr), 1) #define __range_ok(addr, size) ((void)(addr), 0) #define get_fs() (KERNEL_DS)