Re: [PATCH v20 05/12] LSM: Infrastructure management of the superblock

Stephen Smalley
2020-08-12T19:26:44Z

On 8/2/20 5:58 PM, Mickaël Salaün wrote:
> From: Casey Schaufler <casey@schaufler-ca.com>
>
> Move management of the superblock->sb_security blob out
> of the individual security modules and into the security
> infrastructure. Instead of allocating the blobs from within
> the modules the modules tell the infrastructure how much
> space is required, and the space is allocated there.
>
> Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
> Reviewed-by: Kees Cook <keescook@chromium.org>
> Reviewed-by: John Johansen <john.johansen@canonical.com>
> Reviewed-by: Stephen Smalley <sds@tycho.nsa.gov>
> Reviewed-by: Mickaël Salaün <mic@digikod.net>
> Link: https://lore.kernel.org/r/20190829232935.7099-2-casey@schaufler-ca.com
> ---
>
> Changes since v17:
> * Rebase the original LSM stacking patch from v5.3 to v5.7: I fixed some
> diff conflicts caused by code moves and function renames in
> selinux/include/objsec.h and selinux/hooks.c . I checked that it
> builds but I didn't test the changes for SELinux nor SMACK.

You shouldn't retain Signed-off-by and Reviewed-by lines from an earlier
patch if you made non-trivial changes to it (even more so if you didn't
test them).