From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D77B9C43461 for ; Wed, 2 Sep 2020 02:54:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B359820707 for ; Wed, 2 Sep 2020 02:54:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Mmg3k909" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726380AbgIBCyV (ORCPT ); Tue, 1 Sep 2020 22:54:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726140AbgIBCx7 (ORCPT ); Tue, 1 Sep 2020 22:53:59 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FE5FC06125E for ; Tue, 1 Sep 2020 19:53:54 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id l191so1786858pgd.5 for ; Tue, 01 Sep 2020 19:53:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HVX5iGApWsA6cOcKpocM02MsLs3Cms0hUFmAcEqMm6M=; b=Mmg3k909Im5tPr616qMO7eR07LAJFZClo5qultGvx7lHP5OI+oj6Z0PZ+3rp3MvDA3 EKIdRq33UoHLNu/CJNmyG2b1rFixQhYPrXAA7dqL2iwb7efBZBRwDdWCR5SgWF4hYhHi lpG+N67GmcyXWCsOwQrq7S6QnuK7PbTqvLQO8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HVX5iGApWsA6cOcKpocM02MsLs3Cms0hUFmAcEqMm6M=; b=mDvcW5Dm+t/plJxc2o3+IZ5Cxg7yhsKHdiy0+v8q4W/kYcNGBYMLv2fvZxXkfHV0Fb 1C55oSKlZNU8/t2TjlG9smowV9qs7HHmPZJMk9uJBX30M9WgDKnDTNBaTEG4DKXS5it8 yfWnv/SU+ssYBsY3owLhuuwf0Cj0g0hH2zEPl2HdRUs54gqOaIKoo876sQ9DXRgLMzKG D7znGdc6dkyUDnrnUZLbo04dGPEkwlhfx4mbsKQYUD9ZM4ddNWngXBBUaYXB4lvwzBEZ ILFFIed3m3OJda1TaSLOT5Ut+Ug37WGzPoc4PnelcUim6uy9svIDHo+UZIlRHA7iG11F SwBA== X-Gm-Message-State: AOAM533VwH2NhbNZlnie+QlJ1pt3iZPdMjljxTQHBnqS12Q28AS8ExqT ytCUjtxmD9PPkth+iTqegFilTA== X-Google-Smtp-Source: ABdhPJxr15UxFlZO57N08QLgROI0XgkvScTspshNJ0zdFmYYhSNaiyEAMbuocRhYqDliU1QV3ZPnLQ== X-Received: by 2002:a63:6d41:: with SMTP id i62mr199101pgc.279.1599015233901; Tue, 01 Sep 2020 19:53:53 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id q7sm3438860pgg.10.2020.09.01.19.53.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 19:53:50 -0700 (PDT) From: Kees Cook To: Ingo Molnar Cc: Kees Cook , Will Deacon , Borislav Petkov , Catalin Marinas , Mark Rutland , Ard Biesheuvel , Peter Collingbourne , James Morse , Ingo Molnar , Russell King , Masahiro Yamada , Arvind Sankar , Nick Desaulniers , Nathan Chancellor , Arnd Bergmann , x86@kernel.org, clang-built-linux@googlegroups.com, linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v7 1/5] arm64/build: Warn on orphan section placement Date: Tue, 1 Sep 2020 19:53:43 -0700 Message-Id: <20200902025347.2504702-2-keescook@chromium.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200902025347.2504702-1-keescook@chromium.org> References: <20200902025347.2504702-1-keescook@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-arch-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org We don't want to depend on the linker's orphan section placement heuristics as these can vary between linkers, and may change between versions. All sections need to be explicitly handled in the linker script. With all sections now handled, enable orphan section warnings. Acked-by: Will Deacon Signed-off-by: Kees Cook --- arch/arm64/Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile index 6de7f551b821..081144fcc3da 100644 --- a/arch/arm64/Makefile +++ b/arch/arm64/Makefile @@ -29,6 +29,10 @@ LDFLAGS_vmlinux += --fix-cortex-a53-843419 endif endif +# We never want expected sections to be placed heuristically by the +# linker. All sections should be explicitly named in the linker script. +LDFLAGS_vmlinux += $(call ld-option, --orphan-handling=warn) + ifeq ($(CONFIG_ARM64_USE_LSE_ATOMICS), y) ifneq ($(CONFIG_ARM64_LSE_ATOMICS), y) $(warning LSE atomics not supported by binutils) -- 2.25.1