From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A884C433DF for ; Thu, 15 Oct 2020 02:24:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3631222257 for ; Thu, 15 Oct 2020 02:24:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="WE3ire40" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730361AbgJOCYh (ORCPT ); Wed, 14 Oct 2020 22:24:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726575AbgJOCYh (ORCPT ); Wed, 14 Oct 2020 22:24:37 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2355C05BD28 for ; Wed, 14 Oct 2020 15:47:01 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id gv6so625761pjb.4 for ; Wed, 14 Oct 2020 15:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1ZkeuWYx0x8NcK97W3bc1qXSyhy0ywO9Zu1gztVJSpU=; b=WE3ire40GLinUOppIi7ZcbOVETm0WyX7RLx7xCaymADCWSNOR8y2/RwcPtSnft1aFu 0ChZJ7ygTGlmsX8EVM6bGmei1Zx5q2bj0yebVv+SOHsAiV0uEn+oar9jyVds8dZOPeFt NDilDA6BdcrnvpJnue+wzGel9tWEzsFUzutQ0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1ZkeuWYx0x8NcK97W3bc1qXSyhy0ywO9Zu1gztVJSpU=; b=icFAqeP2IG0TcZNYNcqZzIWG2a1GjUgYN/e5dyuZoIzPfLwLMe3ECYu0L7wYHTO+Fe VCsXf1mQh3KxXrO1S48fNeVg+rY2/A4xWUm/UiNUTWRQpAyne0wk7q7uUm62/zUbcU8r kjyKrws2JcZGTdFuawHECSYOVpuueaqn49baiGXZ/QeKg70f6cstqO+VtCEbkeNUdC3x YhNAukNjZ6E5PH1HY0YJUVsabaLNyPa1cTHfKFkdV/kj3BdT86Rl4ecvSFkvP8uUxqit /mQjkGrHiVpyOi8W3vEnhJP1uXSotoA714QbpeIBCezTx+w10Bh4q1qi5Gn+HBeDJiFt XeMw== X-Gm-Message-State: AOAM532TLTPvpR1xHePzKpIDFmjjmORtKmh2mE9dtx12K5hnNGf3plkW eBn38Y/Uyjz/ji1I3y/hUSvYyQ== X-Google-Smtp-Source: ABdhPJw7BSKlM7cAv8r7/0jhJx32xhaKYpzsb2RiBeH0xy7bNtYmDuLkURklLKzHhQnxbTes9rTU2A== X-Received: by 2002:a17:90a:f0ca:: with SMTP id fa10mr1313834pjb.130.1602715621497; Wed, 14 Oct 2020 15:47:01 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id d9sm591245pjx.47.2020.10.14.15.47.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2020 15:47:00 -0700 (PDT) Date: Wed, 14 Oct 2020 15:46:59 -0700 From: Kees Cook To: Thomas Gleixner , Josh Poimboeuf Cc: Masahiro Yamada , Sami Tolvanen , Steven Rostedt , Will Deacon , Peter Zijlstra , Greg Kroah-Hartman , "Paul E. McKenney" , Nick Desaulniers , clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v6 22/25] x86/asm: annotate indirect jumps Message-ID: <202010141545.1E2A393C62@keescook> References: <20201013003203.4168817-1-samitolvanen@google.com> <20201013003203.4168817-23-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201013003203.4168817-23-samitolvanen@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Mon, Oct 12, 2020 at 05:32:00PM -0700, Sami Tolvanen wrote: > Running objtool --vmlinux --duplicate on vmlinux.o produces a few > warnings about indirect jumps with retpoline: > > vmlinux.o: warning: objtool: wakeup_long64()+0x61: indirect jump > found in RETPOLINE build > ... > > This change adds ANNOTATE_RETPOLINE_SAFE annotations to the jumps > in assembly code to stop the warnings. > > Signed-off-by: Sami Tolvanen Reviewed-by: Kees Cook This looks like it's an independent fix -- can an x86 maintainer pick up this patch directly? -- Kees Cook