From: Christoph Hellwig <hch@infradead.org>
To: Zhaoxiu Zeng <zengzhaoxiu@163.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com>
Subject: Re: [PATCH 1/3] lib: Introduce copy_from_back()
Date: Mon, 16 Nov 2020 17:24:35 +0000 [thread overview]
Message-ID: <20201116172435.GA29722@infradead.org> (raw)
In-Reply-To: <092552df-204e-beee-58f8-da194b866d0f@163.com>
> +#define FAST_COPY_SAFEGUARD_SIZE (sizeof(long) * 2 - 1)
> +
> +#ifdef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
> +
> +/*
> + * The caller must ensure that the output buffer has enough space (len + FAST_COPY_SAFEGUARD_SIZE),
> + * so we can write 2 words per loop without overflowing the output buffer
> + */
> +static __always_inline u8 *copy_from_back_fast(u8 *out, size_t dist, size_t len)
The code is pretty unreadable with these longs lines. Please stick to
the normal 80 char limit.
next prev parent reply other threads:[~2020-11-16 17:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 19:16 [PATCH 1/3] lib: Introduce copy_from_back() zengzhaoxiu
2020-11-16 16:35 ` Christoph Hellwig
2020-11-16 17:22 ` Zhaoxiu Zeng
2020-11-16 17:24 ` Christoph Hellwig [this message]
2020-11-18 15:10 ` Zhaoxiu Zeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116172435.GA29722@infradead.org \
--to=hch@infradead.org \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zengzhaoxiu@163.com \
--cc=zhaoxiu.zeng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).