From: "Paul E. McKenney" <paulmck@kernel.org>
To: "Björn Töpel" <bjorn.topel@intel.com>
Cc: "Alan Stern" <stern@rowland.harvard.edu>,
"Björn Töpel" <bjorn.topel@gmail.com>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
"Andrea Parri" <parri.andrea@gmail.com>,
"Will Deacon" <will@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Nicholas Piggin" <npiggin@gmail.com>,
"David Howells" <dhowells@redhat.com>,
"Jade Alglave" <j.alglave@ucl.ac.uk>,
"Luc Maranget" <luc.maranget@inria.fr>,
"Akira Yokosawa" <akiyks@gmail.com>,
"Daniel Lustig" <dlustig@nvidia.com>,
"Joel Fernandes" <joel@joelfernandes.org>
Subject: Re: [PATCH] tools/memory-model: Fix smp_mb__after_spinlock() spelling
Date: Fri, 5 Mar 2021 10:26:50 -0800 [thread overview]
Message-ID: <20210305182650.GA2713@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <e90fee12-a29e-cddb-5db3-24d92d4e03f8@intel.com>
On Fri, Mar 05, 2021 at 04:41:49PM +0100, Björn Töpel wrote:
> On 2021-03-05 16:36, Alan Stern wrote:
> > On Fri, Mar 05, 2021 at 11:28:23AM +0100, Björn Töpel wrote:
> > > From: Björn Töpel <bjorn.topel@intel.com>
> > >
> > > A misspelled invokation of git-grep, revealed that
> > -------------------^
> >
> > Smetimes my brain is a little slow... Do you confirm that this is a
> > joke?
> >
>
> I wish, Alan. I wish.
>
> Looks like I can only spel function names correctly.
Heh! I missed that one completely. Please see below for a wortschmied
commit.
Thanx, Paul
------------------------------------------------------------------------
commit 1c737ce34715db9431f6b034f92dbf09d954126d
Author: Björn Töpel <bjorn.topel@intel.com>
Date: Fri Mar 5 11:28:23 2021 +0100
tools/memory-model: Fix smp_mb__after_spinlock() spelling
A misspelled git-grep regex revealed that smp_mb__after_spinlock()
was misspelled in explanation.txt.
This commit adds the missing "_" to smp_mb__after_spinlock().
Fixes: 1c27b644c0fd ("Automate memory-barriers.txt; provide Linux-kernel memory model")
[ paulmck: Apply Alan Stern commit-log feedback. ]
Signed-off-by: Björn Töpel <bjorn.topel@intel.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
diff --git a/tools/memory-model/Documentation/explanation.txt b/tools/memory-model/Documentation/explanation.txt
index f9d610d..5d72f31 100644
--- a/tools/memory-model/Documentation/explanation.txt
+++ b/tools/memory-model/Documentation/explanation.txt
@@ -2510,7 +2510,7 @@ they behave as follows:
smp_mb__after_atomic() orders po-earlier atomic updates and
the events preceding them against all po-later events;
- smp_mb_after_spinlock() orders po-earlier lock acquisition
+ smp_mb__after_spinlock() orders po-earlier lock acquisition
events and the events preceding them against all po-later
events.
next prev parent reply other threads:[~2021-03-05 18:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 10:28 [PATCH] tools/memory-model: Fix smp_mb__after_spinlock() spelling Björn Töpel
2021-03-05 14:50 ` Paul E. McKenney
2021-03-05 15:36 ` Alan Stern
2021-03-05 15:41 ` Björn Töpel
2021-03-05 18:26 ` Paul E. McKenney [this message]
2021-03-05 18:59 ` Alan Stern
2021-03-05 19:09 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210305182650.GA2713@paulmck-ThinkPad-P72 \
--to=paulmck@kernel.org \
--cc=akiyks@gmail.com \
--cc=bjorn.topel@gmail.com \
--cc=bjorn.topel@intel.com \
--cc=boqun.feng@gmail.com \
--cc=dhowells@redhat.com \
--cc=dlustig@nvidia.com \
--cc=j.alglave@ucl.ac.uk \
--cc=joel@joelfernandes.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luc.maranget@inria.fr \
--cc=npiggin@gmail.com \
--cc=parri.andrea@gmail.com \
--cc=peterz@infradead.org \
--cc=stern@rowland.harvard.edu \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox