From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9F2BC433E1 for ; Fri, 19 Mar 2021 19:16:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F9266197B for ; Fri, 19 Mar 2021 19:16:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230288AbhCSTPu (ORCPT ); Fri, 19 Mar 2021 15:15:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230221AbhCSTPj (ORCPT ); Fri, 19 Mar 2021 15:15:39 -0400 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 848FDC061764 for ; Fri, 19 Mar 2021 12:15:38 -0700 (PDT) Received: by mail-pg1-x52b.google.com with SMTP id n11so4335483pgm.12 for ; Fri, 19 Mar 2021 12:15:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=UhVshRutOq0lszJbq/YX4dDlC5l4aOjl7AUjxQMu52w=; b=bBKx+9uN8xnCc5sshFh2/XhWXlYamoIzo+jRJ+PEm23+wwPHDN30u21VYQIXFuEQpD w+w4KIEC/rk6vS+80NpNCv+5zSBGLevW+p8ahQVPa2S2k9ZqiIfInhQI3nIlyFhnIbyL FS7xcu7RdHUC6pgg3s5aV9vLgE7MofLySVDYY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=UhVshRutOq0lszJbq/YX4dDlC5l4aOjl7AUjxQMu52w=; b=c5nrVD5OK5g2yqfNbCChliH2qP0xq0bW8rEFWtBnfig/WD+CIvFFMJjZg/pi0tcya3 FbZPE7oLDoc5bMKUoBTT4QK+wxryxraCwEnH3KNalJ4RgcvnXgCWjcFQSbG0O46uQqHY cwRRFU+xynA9ooeQareH8W6ekODQ2v4vxMUOlH9oMBPbcbJuSKeDjj9xOOp6AGTeawYX 3iPPzuAXD0DF9nV3jungbCoXJwNt/BSLv5miV5idib3V9VSm6tTKqqQrRTNQdID9arLs rXKllPXiwjIo/aVOmw2Vgdhfp8+5nv19Enfyarxv37XkOxksJGE8HK5eAHSUTFM8Dj7Q GceQ== X-Gm-Message-State: AOAM532qbhgWBJsvPc/6nl0WT8mXg3uIdueU7jUyDjqeiPMHiPt8cfXS bGFwgLMsK9eZnrpYK7JkjYldlA== X-Google-Smtp-Source: ABdhPJyocwGZ+YCdp+AEKehahWsjJ+Q+SCbixvse5NoSiTvSwxOgE6bO6/4QIhmDO4axWxnOK6O7hQ== X-Received: by 2002:a63:4761:: with SMTP id w33mr12829462pgk.118.1616181337860; Fri, 19 Mar 2021 12:15:37 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id e65sm6741175pfe.9.2021.03.19.12.15.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Mar 2021 12:15:37 -0700 (PDT) Date: Fri, 19 Mar 2021 12:15:36 -0700 From: Kees Cook To: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= Cc: James Morris , Jann Horn , "Serge E . Hallyn" , Al Viro , Andrew Morton , Andy Lutomirski , Anton Ivanov , Arnd Bergmann , Casey Schaufler , David Howells , Jeff Dike , Jonathan Corbet , Michael Kerrisk , Richard Weinberger , Shuah Khan , Vincent Dagonneau , kernel-hardening@lists.openwall.com, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-security-module@vger.kernel.org, x86@kernel.org, =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= Subject: Re: [PATCH v30 02/12] landlock: Add ruleset and domain management Message-ID: <202103191213.D6B1B27423@keescook> References: <20210316204252.427806-1-mic@digikod.net> <20210316204252.427806-3-mic@digikod.net> <202103191114.C87C5E2B69@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Fri, Mar 19, 2021 at 08:03:22PM +0100, Mickaël Salaün wrote: > On 19/03/2021 19:40, Kees Cook wrote: > > On Tue, Mar 16, 2021 at 09:42:42PM +0100, Mickaël Salaün wrote: > >> [...] > >> +static void put_rule(struct landlock_rule *const rule) > >> +{ > >> + might_sleep(); > >> + if (!rule) > >> + return; > >> + landlock_put_object(rule->object); > >> + kfree(rule); > >> +} > > > > I'd expect this to be named "release" rather than "put" since it doesn't > > do any lifetime reference counting. > > It does decrement rule->object->usage . Well, landlock_put_object() decrements rule->object's lifetime. It seems "rule" doesn't have a lifetime. (There is no refcounter on rule.) I just find it strange to see "put" without a matching "get". Not a big deal. -- Kees Cook