Re: [PATCH v23 21/28] mm: Re-introduce vm_flags to do_mmap()

Borislav Petkov
2021-03-18T11:43:10Z

On Tue, Mar 16, 2021 at 08:10:47AM -0700, Yu-cheng Yu wrote:
> There was no more caller passing vm_flags to do_mmap(), and vm_flags was
> removed from the function's input by:
>
> commit 45e55300f114 ("mm: remove unnecessary wrapper function do_mmap_pgoff()").
>
> There is a new user now. Shadow stack allocation passes VM_SHSTK to
> do_mmap(). Re-introduce vm_flags to do_mmap(), but without the old wrapper
> do_mmap_pgoff().

Why does this matter at all?

$ git grep do_mmap_pgoff
$

--
Regards/Gruss,
Boris.