From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B844C433E1 for ; Wed, 24 Mar 2021 10:09:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0EDB3619F2 for ; Wed, 24 Mar 2021 10:09:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235397AbhCXKIw (ORCPT ); Wed, 24 Mar 2021 06:08:52 -0400 Received: from elvis.franken.de ([193.175.24.41]:55080 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233361AbhCXKIo (ORCPT ); Wed, 24 Mar 2021 06:08:44 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lP0RM-0008Sw-09; Wed, 24 Mar 2021 11:08:40 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 08A30C1C69; Wed, 24 Mar 2021 11:04:14 +0100 (CET) Date: Wed, 24 Mar 2021 11:04:13 +0100 From: Thomas Bogendoerfer To: Huang Pei Cc: ambrosehua@gmail.com, Bibo Mao , linux-mips@vger.kernel.org, linux-arch@vger.kernel.org, Jiaxun Yang , Paul Burton , Li Xuefeng , Yang Tiezhu , Gao Juxin , Huacai Chen , Jinyang He Subject: Re: [PATCH] MIPS: fix local_irq_{disable,enable} in asmmacro.h Message-ID: <20210324100413.GJ2378@alpha.franken.de> References: <20210323023402.9657-1-huangpei@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210323023402.9657-1-huangpei@loongson.cn> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Tue, Mar 23, 2021 at 10:34:02AM +0800, Huang Pei wrote: > commit ba9196d2e005 ("MIPS: Make DIEI support as a config option") > use CPU_HAS_DIEI to indicate whether di/ei is implemented correctly, > without this patch, "local_irq_disable" from entry.S in 3A1000 > (with buggy di/ei) lose protection of commit e97c5b609880 ("MIPS: > Make irqflags.h functions preempt-safe") > > Fixes: ba9196d2e005 ("MIPS: Make DIEI support as a config option") > Signed-off-by: Huang Pei > --- > arch/mips/include/asm/asmmacro.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]