From: Kees Cook <keescook@chromium.org>
To: Sami Tolvanen <samitolvanen@google.com>
Cc: Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Will Deacon <will@kernel.org>, Jessica Yu <jeyu@kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Tejun Heo <tj@kernel.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Peter Zijlstra <peterz@infradead.org>,
Sedat Dilek <sedat.dilek@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
bpf@vger.kernel.org, linux-hardening@vger.kernel.org,
linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kbuild@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com
Subject: Re: [PATCH v6 00/18] Add support for Clang CFI
Date: Thu, 8 Apr 2021 15:59:53 -0700 [thread overview]
Message-ID: <202104081558.9A5FE3A@keescook> (raw)
In-Reply-To: <20210408182843.1754385-1-samitolvanen@google.com>
On Thu, Apr 08, 2021 at 11:28:25AM -0700, Sami Tolvanen wrote:
> This series adds support for Clang's Control-Flow Integrity (CFI)
> checking. With CFI, the compiler injects a runtime check before each
> indirect function call to ensure the target is a valid function with
> the correct static type. This restricts possible call targets and
> makes it more difficult for an attacker to exploit bugs that allow the
> modification of stored function pointers. For more details, see:
>
> https://clang.llvm.org/docs/ControlFlowIntegrity.html
>
> The first patch contains build system changes and error handling,
> and implements support for cross-module indirect call checking. The
> remaining patches address issues caused by the compiler
> instrumentation. These include fixing known type mismatches, as well
> as issues with address space confusion and cross-module function
> address equality.
>
> These patches add support only for arm64, but I'll post patches also
> for x86_64 after we address the remaining issues there, including
> objtool support.
>
> You can also pull this series from
>
> https://github.com/samitolvanen/linux.git cfi-v6
This is working quite well for me and it looks like there are
good reviews. I'm going to toss it in linux-next unless anyone has
objections. I'm very excited to start using this. :)
-Kees
--
Kees Cook
prev parent reply other threads:[~2021-04-08 22:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 18:28 [PATCH v6 00/18] Add support for Clang CFI Sami Tolvanen
2021-04-08 18:28 ` [PATCH v6 01/18] add " Sami Tolvanen
2021-04-08 18:28 ` [PATCH v6 02/18] cfi: add __cficanonical Sami Tolvanen
2021-04-08 18:28 ` [PATCH v6 03/18] mm: add generic function_nocfi macro Sami Tolvanen
2021-04-08 18:28 ` [PATCH v6 04/18] module: ensure __cfi_check alignment Sami Tolvanen
2021-04-08 18:28 ` [PATCH v6 05/18] workqueue: use WARN_ON_FUNCTION_MISMATCH Sami Tolvanen
2021-04-08 18:28 ` [PATCH v6 06/18] kthread: " Sami Tolvanen
2021-04-08 18:28 ` [PATCH v6 07/18] kallsyms: strip ThinLTO hashes from static functions Sami Tolvanen
2021-04-08 18:28 ` [PATCH v6 08/18] bpf: disable CFI in dispatcher functions Sami Tolvanen
2021-04-08 18:28 ` [PATCH v6 09/18] treewide: Change list_sort to use const pointers Sami Tolvanen
2021-04-08 18:28 ` [PATCH v6 10/18] lkdtm: use function_nocfi Sami Tolvanen
2021-04-08 18:28 ` [PATCH v6 11/18] psci: use function_nocfi for cpu_resume Sami Tolvanen
2021-04-08 18:28 ` [PATCH v6 12/18] arm64: implement function_nocfi Sami Tolvanen
2021-04-08 18:28 ` [PATCH v6 13/18] arm64: use function_nocfi with __pa_symbol Sami Tolvanen
2021-04-08 18:28 ` [PATCH v6 14/18] arm64: add __nocfi to functions that jump to a physical address Sami Tolvanen
2021-04-08 18:28 ` [PATCH v6 15/18] arm64: add __nocfi to __apply_alternatives Sami Tolvanen
2021-04-08 18:28 ` [PATCH v6 16/18] arm64: ftrace: use function_nocfi for ftrace_call Sami Tolvanen
2021-04-08 18:28 ` [PATCH v6 17/18] KVM: arm64: Disable CFI for nVHE Sami Tolvanen
2021-04-08 18:28 ` [PATCH v6 18/18] arm64: allow CONFIG_CFI_CLANG to be selected Sami Tolvanen
2021-04-08 22:59 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202104081558.9A5FE3A@keescook \
--to=keescook@chromium.org \
--cc=arnd@arndb.de \
--cc=bpf@vger.kernel.org \
--cc=catalin.marinas@arm.com \
--cc=clang-built-linux@googlegroups.com \
--cc=hch@infradead.org \
--cc=jeyu@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=samitolvanen@google.com \
--cc=sedat.dilek@gmail.com \
--cc=tj@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).