From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: "H. Nikolaus Schaller" <hns@goldelico.com>,
Arnd Bergmann <arnd@arndb.de>,
Huacai Chen <chenhuacai@kernel.org>,
Huacai Chen <chenhuacai@loongson.cn>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
linux-arch@vger.kernel.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] MIPS: Avoid DIVU in `__div64_32' is result would be zero
Date: Thu, 22 Apr 2021 09:56:45 +0200 [thread overview]
Message-ID: <20210422075645.GA5996@alpha.franken.de> (raw)
In-Reply-To: <alpine.DEB.2.21.2104211810200.44318@angie.orcam.me.uk>
On Wed, Apr 21, 2021 at 06:16:18PM +0200, Maciej W. Rozycki wrote:
> On Wed, 21 Apr 2021, H. Nikolaus Schaller wrote:
>
> > > We already check the high part of the divident against zero to avoid the
> >
> > nit-picking: s/divident/dividend/
>
> Umm, I find this embarassing (and I hesitated reaching for a dictionary
> to double-check the spelling!). Indeed why would this be different from
> subtrahend or minuend?
>
> Thomas, as this mistake has spread across three out of these patches,
> both in change descriptions and actual code, would you mind dropping the
> series from mips-next altogether and I'll respin the series with all
> these issues corrected?
I'm sorry, but I don't rebase mips-next and the patches have been pushed
out before I received this mail.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2021-04-22 8:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 2:50 [PATCH 0/4] Reinstate and improve MIPS `do_div' implementation Maciej W. Rozycki
2021-04-20 2:50 ` [PATCH 1/4] lib/math: Add a `do_div' test module Maciej W. Rozycki
2021-04-20 2:50 ` [PATCH 2/4] div64: Correct inline documentation for `do_div' Maciej W. Rozycki
2021-04-20 2:50 ` [PATCH 3/4] MIPS: Reinstate platform `__div64_32' handler Maciej W. Rozycki
2021-04-22 18:36 ` Guenter Roeck
2021-04-22 20:43 ` Maciej W. Rozycki
2021-04-20 2:50 ` [PATCH 4/4] MIPS: Avoid DIVU in `__div64_32' is result would be zero Maciej W. Rozycki
2021-04-21 16:05 ` H. Nikolaus Schaller
2021-04-21 16:16 ` Maciej W. Rozycki
2021-04-22 7:56 ` Thomas Bogendoerfer [this message]
2021-04-22 9:12 ` Maciej W. Rozycki
2021-04-22 11:08 ` Thomas Bogendoerfer
2021-04-22 20:47 ` Maciej W. Rozycki
2021-04-27 12:16 ` Maciej W. Rozycki
2021-04-22 11:17 ` Andreas Schwab
2021-04-21 12:01 ` [PATCH 0/4] Reinstate and improve MIPS `do_div' implementation Thomas Bogendoerfer
2021-04-21 13:12 ` Maciej W. Rozycki
2021-04-21 16:00 ` H. Nikolaus Schaller
2021-04-21 19:04 ` Maciej W. Rozycki
2021-04-22 5:53 ` H. Nikolaus Schaller
2021-04-22 13:39 ` Jiaxun Yang
2021-04-22 15:58 ` Maciej W. Rozycki
2021-04-22 16:00 ` H. Nikolaus Schaller
2021-04-22 16:55 ` Maciej W. Rozycki
2021-04-22 17:06 ` H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210422075645.GA5996@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=arnd@arndb.de \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=hns@goldelico.com \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=macro@orcam.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).