From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94E07C433B4 for ; Thu, 6 May 2021 10:27:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6D6976109E for ; Thu, 6 May 2021 10:27:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234089AbhEFK2m (ORCPT ); Thu, 6 May 2021 06:28:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:42404 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231863AbhEFK2l (ORCPT ); Thu, 6 May 2021 06:28:41 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 32EBE611AC; Thu, 6 May 2021 10:27:39 +0000 (UTC) Date: Thu, 6 May 2021 11:27:36 +0100 From: Catalin Marinas To: Anshuman Khandual Cc: linux-mm@kvack.org, akpm@linux-foundation.org, Richard Henderson , Vineet Gupta , Will Deacon , Guo Ren , Brian Cain , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , Ley Foon Tan , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E.J. Bottomley" , Michael Ellerman , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Heiko Carstens , Yoshinori Sato , "David S. Miller" , Jeff Dike , Thomas Gleixner , Chris Zankel , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] mm: Define default value for FIRST_USER_ADDRESS Message-ID: <20210506102736.GB22164@arm.com> References: <1618550254-14511-1-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1618550254-14511-1-git-send-email-anshuman.khandual@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Fri, Apr 16, 2021 at 10:47:34AM +0530, Anshuman Khandual wrote: > Currently most platforms define FIRST_USER_ADDRESS as 0UL duplication the > same code all over. Instead just define a generic default value (i.e 0UL) > for FIRST_USER_ADDRESS and let the platforms override when required. This > makes it much cleaner with reduced code. > > The default FIRST_USER_ADDRESS here would be skipped in > when the given platform overrides its value via . > > Cc: Richard Henderson > Cc: Vineet Gupta > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Guo Ren > Cc: Brian Cain > Cc: Geert Uytterhoeven > Cc: Michal Simek > Cc: Thomas Bogendoerfer > Cc: Ley Foon Tan > Cc: Jonas Bonn > Cc: Stefan Kristiansson > Cc: Stafford Horne > Cc: "James E.J. Bottomley" > Cc: Michael Ellerman > Cc: Christophe Leroy > Cc: Paul Walmsley > Cc: Palmer Dabbelt > Cc: Heiko Carstens > Cc: Yoshinori Sato > Cc: "David S. Miller" > Cc: Jeff Dike > Cc: Thomas Gleixner > Cc: Chris Zankel > Cc: Andrew Morton > Cc: linux-arch@vger.kernel.org > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual [...] > diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h > index 47027796c2f9..f6ab8b64967e 100644 > --- a/arch/arm64/include/asm/pgtable.h > +++ b/arch/arm64/include/asm/pgtable.h > @@ -26,8 +26,6 @@ > > #define vmemmap ((struct page *)VMEMMAP_START - (memstart_addr >> PAGE_SHIFT)) > > -#define FIRST_USER_ADDRESS 0UL > - > #ifndef __ASSEMBLY__ > > #include For arm64: Acked-by: Catalin Marinas