Re: [PATCH 03/16] include: move find.h from asm_generic to linux

Geert Uytterhoeven
2021-10-02T09:25:22Z

Hi Yuri,

Thanks for your patch!

On Fri, Oct 1, 2021 at 8:12 PM Yury Norov <yury.norov@gmail.com> wrote:
> find_bit API and bitmap API are closely related, but inclusion paths
> are different - include/asm-generic and include/linux, correspondingly.
> In the past it made a lot of troubles due to circular dependencies
> and/or undefined symbols. Fix this by moving find.h under include/linux.

.. and including it from include/linux/bitmap.h, like the other helper includes?

> Signed-off-by: Yury Norov <yury.norov@gmail.com>
> Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

> arch/m68k/include/asm/bitops.h | 2 --

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

> --- a/include/linux/bitmap.h
> +++ b/include/linux/bitmap.h
> @@ -6,6 +6,7 @@
>
> #include <linux/align.h>
> #include <linux/bitops.h>
> +#include <linux/find.h>
> #include <linux/limits.h>
> #include <linux/string.h>
> #include <linux/types.h>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds