Re: [PATCH 12/20] exit/kthread: Have kernel threads return instead of calling do_exit

Kees Cook
2021-10-21T16:21:20Z

On Wed, Oct 20, 2021 at 12:43:58PM -0500, Eric W. Biederman wrote:
> In 2009 Oleg reworked[1] the kernel threads so that it is not
> necessary to call do_exit if you are not using kthread_stop(). Remove
> the explicit calls of do_exit and complete_and_exit (with a NULL
> completion) that were previously necessary.
>
> [1] 63706172f332 ("kthreads: rework kthread_stop()")
> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>

Looks sensible. Can you check that tools/testing/selftests/firmware
still passes? That test does a fair bit of kthread waiting, etc.

Reviewed-by: Kees Cook <keescook@chromium.org>

--
Kees Cook