Re: [PATCH 04/20] signal/sparc32: Remove unreachable do_exit in do_sparc_fault

Kees Cook
2021-10-21T16:06:02Z

On Wed, Oct 20, 2021 at 12:43:50PM -0500, Eric W. Biederman wrote:
> The call to do_exit in do_sparc_fault immediately follows a call to
> unhandled_fault. The function unhandled_fault never returns. This
> means the call to do_exit can never be reached.

Same thought: replace with unreachable() just to make this more
self-documenting? Either way:

Reviewed-by: Kees Cook <keescook@chromium.org>

>
> Cc: David Miller <davem@davemloft.net>
> Cc: sparclinux@vger.kernel.org
> Fixes: 2.3.41
> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
> ---
> arch/sparc/mm/fault_32.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/sparc/mm/fault_32.c b/arch/sparc/mm/fault_32.c
> index fa858626b85b..90dc4ae315c8 100644
> --- a/arch/sparc/mm/fault_32.c
> +++ b/arch/sparc/mm/fault_32.c
> @@ -248,7 +248,6 @@ asmlinkage void do_sparc_fault(struct pt_regs *regs, int text_fault, int write,
> }
>
> unhandled_fault(address, tsk, regs);
> - do_exit(SIGKILL);
>
> /*
> * We ran out of memory, or some other thing happened to us that made
> --
> 2.20.1
>

--
Kees Cook