linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Kristen Carlson Accardi <kristen@linux.intel.com>,
	Tony Luck <tony.luck@intel.com>,
	Alexander Lobakin <alexandr.lobakin@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@suse.de>,
	Arnd Bergmann <arnd@arndb.de>, Joerg Roedel <jroedel@suse.de>,
	Arvind Sankar <nivedita@alum.mit.edu>,
	Jing Yangyang <jing.yangyang@zte.com.cn>,
	Abaci Robot <abaci@linux.alibaba.com>,
	Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
	Andrey Konovalov <andreyknvl@gmail.com>,
	Miroslav Benes <mbenes@suse.cz>,
	"H. Nikolaus Schaller" <hns@goldelico.com>,
	Fangrui Song <maskray@google.com>,
	linux-kernel@vger.kernel.org, x86@kernel.org,
	linux-arch@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH 0/4] x86: Various clean-ups in support of FGKASLR
Date: Tue, 26 Oct 2021 23:10:06 -0700	[thread overview]
Message-ID: <202110262301.A1C8F597A@keescook> (raw)
In-Reply-To: <20211013175742.1197608-1-keescook@chromium.org>

On Wed, Oct 13, 2021 at 10:57:38AM -0700, Kees Cook wrote:
> Hi,
> 
> These are a small set of patches that clean up various things that are
> each stand-alone improvements, but they're also needed for the coming
> FGKASLR series[1]. I thought it best to just get these landed instead
> of having them continue to tag along with FGKASLR, especially the
> early malloc() fix, which is a foot-gun waiting to happen. :)
> 
> Thanks!
> 
> -Kees
> 
> [1] https://lore.kernel.org/lkml/20210831144114.154-1-alexandr.lobakin@intel.com/

Peter, Josh, Boris, can someone please take these through -tip?

They're each stand-alone correctness improvements, and while FGKASLR
depends on them, there is no reason to keep them tied to that series,
especially since anyone using the early-boot malloc or making changes to
text sections is going to trip over one or several of the issues fixed
here.

They've got a bunch of reviews and acks already:
https://patchwork.kernel.org/project/linux-hardening/list/?series=562929

Thanks!

-Kees

> 
> Kees Cook (2):
>   x86/boot: Allow a "silent" kaslr random byte fetch
>   x86/boot/compressed: Avoid duplicate malloc() implementations
> 
> Kristen Carlson Accardi (2):
>   x86/tools/relocs: Support >64K section headers
>   vmlinux.lds.h: Have ORC lookup cover entire _etext - _stext
> 
>  arch/x86/boot/compressed/kaslr.c  |   4 --
>  arch/x86/boot/compressed/misc.c   |   3 +
>  arch/x86/boot/compressed/misc.h   |   2 +
>  arch/x86/lib/kaslr.c              |  18 ++++--
>  arch/x86/tools/relocs.c           | 103 ++++++++++++++++++++++--------
>  include/asm-generic/vmlinux.lds.h |   3 +-
>  include/linux/decompress/mm.h     |  12 +++-
>  7 files changed, 107 insertions(+), 38 deletions(-)
> 
> -- 
> 2.30.2
> 

-- 
Kees Cook

  parent reply	other threads:[~2021-10-27  6:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-13 17:57 [PATCH 0/4] x86: Various clean-ups in support of FGKASLR Kees Cook
2021-10-13 17:57 ` [PATCH 1/4] x86/tools/relocs: Support >64K section headers Kees Cook
2021-10-13 17:57 ` [PATCH 2/4] x86/boot: Allow a "silent" kaslr random byte fetch Kees Cook
2021-10-13 18:10   ` Nick Desaulniers
2021-10-13 17:57 ` [PATCH 3/4] x86/boot/compressed: Avoid duplicate malloc() implementations Kees Cook
2021-10-13 17:57 ` [PATCH 4/4] vmlinux.lds.h: Have ORC lookup cover entire _etext - _stext Kees Cook
2021-10-14  0:29   ` Josh Poimboeuf
2021-10-15 18:27 ` [PATCH 0/4] x86: Various clean-ups in support of FGKASLR Alexander Lobakin
2021-10-27  6:10 ` Kees Cook [this message]
2021-10-27  6:57 ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202110262301.A1C8F597A@keescook \
    --to=keescook@chromium.org \
    --cc=abaci@linux.alibaba.com \
    --cc=alexandr.lobakin@intel.com \
    --cc=andreyknvl@gmail.com \
    --cc=arnd@arndb.de \
    --cc=bp@suse.de \
    --cc=hns@goldelico.com \
    --cc=hpa@zytor.com \
    --cc=jiapeng.chong@linux.alibaba.com \
    --cc=jing.yangyang@zte.com.cn \
    --cc=jpoimboe@redhat.com \
    --cc=jroedel@suse.de \
    --cc=kristen@linux.intel.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maskray@google.com \
    --cc=mbenes@suse.cz \
    --cc=mingo@redhat.com \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=nivedita@alum.mit.edu \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=vincenzo.frascino@arm.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).