* [PATCH] Revert "Makefile: Do not quote value for CONFIG_CC_IMPLICIT_FALLTHROUGH"
@ 2022-01-20 5:31 Masahiro Yamada
2022-01-24 19:55 ` Nick Desaulniers
0 siblings, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2022-01-20 5:31 UTC (permalink / raw)
To: linux-kbuild
Cc: linux-kernel, linux-arch, Masahiro Yamada, Michal Marek,
Nick Desaulniers
This reverts commit cd8c917a56f20f48748dd43d9ae3caff51d5b987.
Commit 129ab0d2d9f3 ("kbuild: do not quote string values in
include/config/auto.conf") provided the final solution.
Now reverting the temporary workaround.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 3f07f0f04475..c94559a97dca 100644
--- a/Makefile
+++ b/Makefile
@@ -778,7 +778,7 @@ stackp-flags-$(CONFIG_STACKPROTECTOR_STRONG) := -fstack-protector-strong
KBUILD_CFLAGS += $(stackp-flags-y)
KBUILD_CFLAGS-$(CONFIG_WERROR) += -Werror
-KBUILD_CFLAGS += $(KBUILD_CFLAGS-y) $(CONFIG_CC_IMPLICIT_FALLTHROUGH:"%"=%)
+KBUILD_CFLAGS += $(KBUILD_CFLAGS-y) $(CONFIG_CC_IMPLICIT_FALLTHROUGH)
ifdef CONFIG_CC_IS_CLANG
KBUILD_CPPFLAGS += -Qunused-arguments
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Revert "Makefile: Do not quote value for CONFIG_CC_IMPLICIT_FALLTHROUGH"
2022-01-20 5:31 [PATCH] Revert "Makefile: Do not quote value for CONFIG_CC_IMPLICIT_FALLTHROUGH" Masahiro Yamada
@ 2022-01-24 19:55 ` Nick Desaulniers
2022-01-24 20:04 ` Kees Cook
2022-01-24 20:45 ` Gustavo A. R. Silva
0 siblings, 2 replies; 4+ messages in thread
From: Nick Desaulniers @ 2022-01-24 19:55 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-kbuild, linux-kernel, linux-arch, Michal Marek, carnil,
Kees Cook, Gustavo A . R . Silva, Nathan Chancellor
+ Salvatore, Kees, Gustavo, Nathan
On Wed, Jan 19, 2022 at 9:31 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> This reverts commit cd8c917a56f20f48748dd43d9ae3caff51d5b987.
>
> Commit 129ab0d2d9f3 ("kbuild: do not quote string values in
> include/config/auto.conf") provided the final solution.
>
> Now reverting the temporary workaround.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
>
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 3f07f0f04475..c94559a97dca 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -778,7 +778,7 @@ stackp-flags-$(CONFIG_STACKPROTECTOR_STRONG) := -fstack-protector-strong
> KBUILD_CFLAGS += $(stackp-flags-y)
>
> KBUILD_CFLAGS-$(CONFIG_WERROR) += -Werror
> -KBUILD_CFLAGS += $(KBUILD_CFLAGS-y) $(CONFIG_CC_IMPLICIT_FALLTHROUGH:"%"=%)
> +KBUILD_CFLAGS += $(KBUILD_CFLAGS-y) $(CONFIG_CC_IMPLICIT_FALLTHROUGH)
>
> ifdef CONFIG_CC_IS_CLANG
> KBUILD_CPPFLAGS += -Qunused-arguments
> --
> 2.32.0
>
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Revert "Makefile: Do not quote value for CONFIG_CC_IMPLICIT_FALLTHROUGH"
2022-01-24 19:55 ` Nick Desaulniers
@ 2022-01-24 20:04 ` Kees Cook
2022-01-24 20:45 ` Gustavo A. R. Silva
1 sibling, 0 replies; 4+ messages in thread
From: Kees Cook @ 2022-01-24 20:04 UTC (permalink / raw)
To: Nick Desaulniers
Cc: Masahiro Yamada, linux-kbuild, linux-kernel, linux-arch,
Michal Marek, carnil, Gustavo A . R . Silva, Nathan Chancellor
On Mon, Jan 24, 2022 at 11:55:43AM -0800, Nick Desaulniers wrote:
> + Salvatore, Kees, Gustavo, Nathan
>
> On Wed, Jan 19, 2022 at 9:31 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > This reverts commit cd8c917a56f20f48748dd43d9ae3caff51d5b987.
> >
> > Commit 129ab0d2d9f3 ("kbuild: do not quote string values in
> > include/config/auto.conf") provided the final solution.
Oh nice!
> >
> > Now reverting the temporary workaround.
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
>
> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
>
> > ---
> >
> > Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Makefile b/Makefile
> > index 3f07f0f04475..c94559a97dca 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -778,7 +778,7 @@ stackp-flags-$(CONFIG_STACKPROTECTOR_STRONG) := -fstack-protector-strong
> > KBUILD_CFLAGS += $(stackp-flags-y)
> >
> > KBUILD_CFLAGS-$(CONFIG_WERROR) += -Werror
> > -KBUILD_CFLAGS += $(KBUILD_CFLAGS-y) $(CONFIG_CC_IMPLICIT_FALLTHROUGH:"%"=%)
> > +KBUILD_CFLAGS += $(KBUILD_CFLAGS-y) $(CONFIG_CC_IMPLICIT_FALLTHROUGH)
> >
> > ifdef CONFIG_CC_IS_CLANG
> > KBUILD_CPPFLAGS += -Qunused-arguments
> > --
> > 2.32.0
> >
>
>
> --
> Thanks,
> ~Nick Desaulniers
--
Kees Cook
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Revert "Makefile: Do not quote value for CONFIG_CC_IMPLICIT_FALLTHROUGH"
2022-01-24 19:55 ` Nick Desaulniers
2022-01-24 20:04 ` Kees Cook
@ 2022-01-24 20:45 ` Gustavo A. R. Silva
1 sibling, 0 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2022-01-24 20:45 UTC (permalink / raw)
To: Nick Desaulniers
Cc: Masahiro Yamada, linux-kbuild, linux-kernel, linux-arch,
Michal Marek, carnil, Kees Cook, Nathan Chancellor
On Mon, Jan 24, 2022 at 11:55:43AM -0800, Nick Desaulniers wrote:
> + Salvatore, Kees, Gustavo, Nathan
>
> On Wed, Jan 19, 2022 at 9:31 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > This reverts commit cd8c917a56f20f48748dd43d9ae3caff51d5b987.
> >
> > Commit 129ab0d2d9f3 ("kbuild: do not quote string values in
> > include/config/auto.conf") provided the final solution.
> >
> > Now reverting the temporary workaround.
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
>
> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Great!
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Thanks
--
Gustavo
>
> > ---
> >
> > Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Makefile b/Makefile
> > index 3f07f0f04475..c94559a97dca 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -778,7 +778,7 @@ stackp-flags-$(CONFIG_STACKPROTECTOR_STRONG) := -fstack-protector-strong
> > KBUILD_CFLAGS += $(stackp-flags-y)
> >
> > KBUILD_CFLAGS-$(CONFIG_WERROR) += -Werror
> > -KBUILD_CFLAGS += $(KBUILD_CFLAGS-y) $(CONFIG_CC_IMPLICIT_FALLTHROUGH:"%"=%)
> > +KBUILD_CFLAGS += $(KBUILD_CFLAGS-y) $(CONFIG_CC_IMPLICIT_FALLTHROUGH)
> >
> > ifdef CONFIG_CC_IS_CLANG
> > KBUILD_CPPFLAGS += -Qunused-arguments
> > --
> > 2.32.0
> >
>
>
> --
> Thanks,
> ~Nick Desaulniers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-25 2:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-20 5:31 [PATCH] Revert "Makefile: Do not quote value for CONFIG_CC_IMPLICIT_FALLTHROUGH" Masahiro Yamada
2022-01-24 19:55 ` Nick Desaulniers
2022-01-24 20:04 ` Kees Cook
2022-01-24 20:45 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).