From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 358D7C433FE for ; Wed, 16 Feb 2022 16:20:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236251AbiBPQUQ (ORCPT ); Wed, 16 Feb 2022 11:20:16 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:55462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233783AbiBPQUQ (ORCPT ); Wed, 16 Feb 2022 11:20:16 -0500 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C3152AE28B for ; Wed, 16 Feb 2022 08:20:04 -0800 (PST) Received: by mail-pg1-x52c.google.com with SMTP id 139so2581665pge.1 for ; Wed, 16 Feb 2022 08:20:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=SUEK1OPatjz/xS89rOiQIJkojmQppC70TLq4uXsnOCU=; b=awiYRJK7xVss9qUlz/+ZAsH80T6s71tCIdTOeiyrQ0x99UFr0wnuctr63kQIRgErZp Pjfqzv1BqeebYXL4GcrP/MyMzdMDlGQjvfr6bbW2B//BH8jrUYt1XEZHs+OKMGfIVuiv RJpsPjfFgg4A8/+DgzM1yTr8QymR2qoNgB2u0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=SUEK1OPatjz/xS89rOiQIJkojmQppC70TLq4uXsnOCU=; b=6wCDc9MEe9Rw8kZ4yTuPFizhzipCY2PeeMRCa3dA26jsGQyn0hMRCJCKbfPU/Tupfp iROjck0jeVLVQm2QlOKyNYg/Kzpm6VU0cItsPjAMFakXzb7ZjWWhdqC3dlQ9PGvdhTpi lEbzwy31mGXjpWNl+cjs8KYvf6UFs0BSqAHZVVUOgS7KR3V2hxYifBMDb6lG5rth09+c 18VCkFvCH4WYQG8QtiuBPn0RZpWxR8u3idEK+kvkBYRfp+rgNGIB35NpqbEzI0wsCr0H 8O9WyOA5FGcDcE05p9WxXErGNxlWhKcOgOFI6NL4XEzaLuSMndfzpg6+1UsVbB2k8ou4 E3EA== X-Gm-Message-State: AOAM5301/dMt/s3EwaK4/9R2e+Qx0dpklfu2dA+9HKvkvkhQujlJqNH9 P/tEbzeJ//E7CfXb0IB2fpT1+A== X-Google-Smtp-Source: ABdhPJwkMae/H/K70R+Ctzw/galxZ1wgyt9T2ZBccthHmsi3muEDVk9x1KPlstE3Ys6++5ijnUTmdw== X-Received: by 2002:a63:86:0:b0:36c:48e8:627e with SMTP id 128-20020a630086000000b0036c48e8627emr2940332pga.53.1645028403498; Wed, 16 Feb 2022 08:20:03 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id x4sm1535073pjq.2.2022.02.16.08.20.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Feb 2022 08:20:03 -0800 (PST) Date: Wed, 16 Feb 2022 08:20:02 -0800 From: Kees Cook To: Michael Ellerman Cc: Christophe Leroy , Benjamin Herrenschmidt , Paul Mackerras , Andrew Morton , "James E.J. Bottomley" , Helge Deller , Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v4 00/13] Fix LKDTM for PPC64/IA64/PARISC v4 Message-ID: <202202160818.7C3862B@keescook> References: <202202150807.D584917D34@keescook> <87y22bm25y.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87y22bm25y.fsf@mpe.ellerman.id.au> Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Wed, Feb 16, 2022 at 11:22:33PM +1100, Michael Ellerman wrote: > Kees Cook writes: > > On Tue, Feb 15, 2022 at 01:40:55PM +0100, Christophe Leroy wrote: > >> PPC64/IA64/PARISC have function descriptors. LKDTM doesn't work > >> on those three architectures because LKDTM messes up function > >> descriptors with functions. > >> > >> This series does some cleanup in the three architectures and > >> refactors function descriptors so that it can then easily use it > >> in a generic way in LKDTM. > > > > Thanks for doing this! It looks good to me. :) > > How should we merge this series, it's a bit all over the map. > > I could put it in a topic branch? That's fine by me -- I had assumed it'd go via the ppc tree. But if you'd rather I take it as a topic branch I can do that too. -- Kees Cook