From: Christoph Hellwig <hch@lst.de>
To: guoren@kernel.org
Cc: palmer@rivosinc.com, arnd@arndb.de, linux@roeck-us.net,
palmer@dabbelt.com, heiko@sntech.de,
linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org, Guo Ren <guoren@linux.alibaba.com>,
Eugene Syromiatnikov <esyr@redhat.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] uapi: Fixup strace compile error
Date: Mon, 13 Jun 2022 16:29:47 +0200 [thread overview]
Message-ID: <20220613142947.GA4110@lst.de> (raw)
In-Reply-To: <20220613013051.1741434-1-guoren@kernel.org>
The change looks fine, but the commit log could use some work, please
move the notes from the back to the front and make them a standalone
commit log and just drop the rest.
next prev parent reply other threads:[~2022-06-13 18:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 1:30 [PATCH] uapi: Fixup strace compile error guoren
2022-06-13 13:58 ` Heiko Stübner
2022-08-04 2:10 ` Guo Ren
2022-06-13 14:29 ` Christoph Hellwig [this message]
2022-08-04 0:40 ` Palmer Dabbelt
2022-08-04 2:12 ` Guo Ren
2022-08-04 2:09 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220613142947.GA4110@lst.de \
--to=hch@lst.de \
--cc=arnd@arndb.de \
--cc=esyr@redhat.com \
--cc=guoren@kernel.org \
--cc=guoren@linux.alibaba.com \
--cc=heiko@sntech.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=palmer@dabbelt.com \
--cc=palmer@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).