From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A93DFC433EF for ; Thu, 30 Jun 2022 16:57:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235364AbiF3Q5K (ORCPT ); Thu, 30 Jun 2022 12:57:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230223AbiF3Q5J (ORCPT ); Thu, 30 Jun 2022 12:57:09 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B188393DC; Thu, 30 Jun 2022 09:57:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656608229; x=1688144229; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=bL9nkQHpWXRcPQiclQNvTJObFea+2bIOo5Icywa3vMA=; b=fmrnj/6XuSpY1hnOWZabHa7oDtPIZ/7Bh+RzopLp14OHknBAX57nHps+ hL5jBriVpX/QkW93R0zu0Im+Scz9SCMknY/iOCVSHSS2S8n+mKecZgyHQ Bj7eBMp9wg9++qnorxgkRFae5QI68Ufol1Zw3FVTWM9ltXapLCo//Tj26 9Kxt8LZ2qLG3s4QZZ6QJUPHIBI+jiJrwD8thm/mMC7PGeyX+J3CV/8SMn PUlmia2grWt0+sj7f7hIdMOsNypeNBNyPtP/nF2FJrYVf6/8tUDwXrhTm a/SMH+lmmn9h8jAOslm763iFDv28yTpVnQqU9eUHwUpe3DyX9d9HKP6LI Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10394"; a="271175238" X-IronPort-AV: E=Sophos;i="5.92,234,1650956400"; d="scan'208";a="271175238" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2022 09:57:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,234,1650956400"; d="scan'208";a="623800223" Received: from irvmail001.ir.intel.com ([10.43.11.63]) by orsmga001.jf.intel.com with ESMTP; 30 Jun 2022 09:57:02 -0700 Received: from newjersey.igk.intel.com (newjersey.igk.intel.com [10.102.20.203]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id 25UGv0GF022621; Thu, 30 Jun 2022 17:57:00 +0100 From: Alexander Lobakin To: Yury Norov Cc: Alexander Lobakin , Arnd Bergmann , Andy Shevchenko , Mark Rutland , Matt Turner , Brian Cain , Geert Uytterhoeven , Yoshinori Sato , Rich Felker , "David S. Miller" , Kees Cook , "Peter Zijlstra (Intel)" , Marco Elver , Borislav Petkov , Tony Luck , Maciej Fijalkowski , Jesse Brandeburg , Greg Kroah-Hartman , Nathan Chancellor , Nick Desaulniers , Tom Rix , kernel test robot , linux-alpha@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, llvm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 0/9] bitops: let optimize out non-atomic bitops on compile-time constants Date: Thu, 30 Jun 2022 18:56:11 +0200 Message-Id: <20220630165611.1551808-1-alexandr.lobakin@intel.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220624121313.2382500-1-alexandr.lobakin@intel.com> References: <20220624121313.2382500-1-alexandr.lobakin@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org From: Alexander Lobakin Date: Fri, 24 Jun 2022 14:13:04 +0200 > While I was working on converting some structure fields from a fixed > type to a bitmap, I started observing code size increase not only in > places where the code works with the converted structure fields, but > also where the converted vars were on the stack. That said, the > following code: Hey, Seems like everything is fine this time. I got some reports, but those aren't caused by any of the changes from the series. Maybe we can take it to -next and see how it goes? [...] > arch/alpha/include/asm/bitops.h | 32 ++-- > arch/hexagon/include/asm/bitops.h | 24 ++- > arch/ia64/include/asm/bitops.h | 42 ++--- > arch/ia64/include/asm/processor.h | 2 +- > arch/m68k/include/asm/bitops.h | 49 ++++-- > arch/s390/include/asm/bitops.h | 61 +++---- > arch/sh/include/asm/bitops-op32.h | 34 ++-- > arch/sparc/include/asm/bitops_32.h | 18 +- > arch/sparc/lib/atomic32.c | 12 +- > arch/x86/include/asm/bitops.h | 22 +-- > drivers/net/ethernet/intel/ice/ice_switch.c | 2 +- > .../asm-generic/bitops/generic-non-atomic.h | 161 ++++++++++++++++++ > .../bitops/instrumented-non-atomic.h | 35 ++-- > include/asm-generic/bitops/non-atomic.h | 121 +------------ > .../bitops/non-instrumented-non-atomic.h | 16 ++ > include/linux/bitmap.h | 22 ++- > include/linux/bitops.h | 50 ++++++ > lib/test_bitmap.c | 62 +++++++ > tools/include/asm-generic/bitops/non-atomic.h | 34 ++-- > tools/include/linux/bitops.h | 16 ++ > 20 files changed, 544 insertions(+), 271 deletions(-) > create mode 100644 include/asm-generic/bitops/generic-non-atomic.h > create mode 100644 include/asm-generic/bitops/non-instrumented-non-atomic.h > > -- > 2.36.1 Thanks, Olek